Migrate to the staging instance of code search |
|||||
Issue descriptionMigrate to the new version of code search running at cs-staging.chromium.org. This new instance integrates with Git which makes access to the latest version of a file more or less instant. Note that there is still a delay in getting generated files and Xrefs. This new version also removes the restriction on file size for checked in files, as these do not need to be stored in a Bigtable.
,
Sep 30 2016
,
Oct 17 2016
,
Oct 27 2016
,
Jan 3 2017
Is there any update on this?
,
Jan 5 2017
Dave, any ETA?
,
Jan 6 2017
There are two bugs remaining: 1. Things in the overlay repo aren't reachable if they're nested inside 1 or more directories that are *only* in the overlay repo. For example https://cs-staging.chromium.org/chromium/infra/go/src/github.com/luci/luci-go/ - this exists in https://chromium.googlesource.com/infra/infra/codesearch/+/master/go/src/github.com/luci, but because the original repo only has "go/src", and is missing the "github.com/luci" directories, the gitlink resolution code that merges the directory hierarchies doesn't work. Search still works though, and you can see search results from inside the directory: https://cs-staging.chromium.org/search/?q=f:infra/go/src/github.com/luci/luci-go&type=cs - so this is just an issue with the frontend flows. 2. x-refs from grok create links with URLs with an old-style "rcl=1481847532" query parameter. Of course that's not a valid git revision, so the file isn't found when you click on it. We need to teach grok about the real git revision that the index pack was generated from.
,
Jan 6 2017
As a way to unblock other things, would it be possible to put this Git integration behind a flag to disable it in prod?
,
Jan 13 2017
Update: I've fixed those two remaining bugs. Unfortunately the request latency isn't quite as good now that the frontend is doing lots more requests to lookup gitlinks. I have cl/144293661 to add a cache that brings performance back in line with the current codesearch.
,
Feb 1 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by emso@chromium.org
, Sep 30 2016