New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651728 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Git

Blocked on:
issue 651725

Blocking:
issue 650280
issue 657589



Sign in to add a comment

Migrate to the staging instance of code search

Project Member Reported by emso@chromium.org, Sep 30 2016

Issue description

Migrate to the new version of code search running at cs-staging.chromium.org. This new instance integrates with Git which makes access to the latest version of a file more or less instant. Note that there is still a delay in getting generated files and Xrefs.

This new version also removes the restriction on file size for checked in files, as these do not need to be stored in a Bigtable.
 

Comment 1 by emso@chromium.org, Sep 30 2016

Blockedon: 651725

Comment 2 by emso@chromium.org, Sep 30 2016

Blocking: 650280

Comment 3 by aarya@google.com, Oct 17 2016

Cc: mbarbe...@chromium.org tanin@chromium.org infe...@chromium.org

Comment 4 by emso@chromium.org, Oct 27 2016

Blocking: 657589
Is there any update on this?
Dave, any ETA?
There are two bugs remaining:

1. Things in the overlay repo aren't reachable if they're nested inside 1 or more directories that are *only* in the overlay repo.  For example https://cs-staging.chromium.org/chromium/infra/go/src/github.com/luci/luci-go/ - this exists in https://chromium.googlesource.com/infra/infra/codesearch/+/master/go/src/github.com/luci, but because the original repo only has "go/src", and is missing the "github.com/luci" directories, the gitlink resolution code that merges the directory hierarchies doesn't work.  Search still works though, and you can see search results from inside the directory: https://cs-staging.chromium.org/search/?q=f:infra/go/src/github.com/luci/luci-go&type=cs - so this is just an issue with the frontend flows.

2. x-refs from grok create links with URLs with an old-style "rcl=1481847532" query parameter.  Of course that's not a valid git revision, so the file isn't found when you click on it.  We need to teach grok about the real git revision that the index pack was generated from.

Comment 8 by emso@chromium.org, Jan 6 2017

As a way to unblock other things, would it be possible to put this Git integration behind a flag to disable it in prod?
Update: I've fixed those two remaining bugs.  Unfortunately the request latency isn't quite as good now that the frontend is doing lots more requests to lookup gitlinks.  I have cl/144293661 to add a cache that brings performance back in line with the current codesearch.

Comment 10 by emso@chromium.org, Feb 1 2017

Status: Verified (was: Assigned)

Sign in to add a comment