Issue metadata
Sign in to add a comment
|
[MD Settings] Default browser should not have subpage arrow (doesn't go to a subpage)
Reported by
rk...@etouch.net,
Sep 30 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 55.0.2876.0 Revision 5c0e46df680c3284a99ae05aafaf52078674ea2d-refs/heads/master@{#421986} OS: Windows(7,8,10), Mac(10.10.5,10.11.4) What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://md-settings page and make chrome as 'Default browser' (2) Then press Tab key and observe. Actual: Unnecessary focus highlight is seen on iron icon which is not present there. Expected: No such focus highlight should seen on it. This is a regression issue, broken in 'M-55', will soon update the bisect info. Good Build: 55.0.2875.0 Bad Build: 55.0.2876.0
,
Sep 30 2016
,
Sep 30 2016
i don't really think we should have a subpage icon in there yet
,
Oct 3 2016
Using the per-revision bisect providing the bisect results, Good build: 55.0.2875.0 (Revision: 421703). Bad build: 55.0.2876.0 (Revision: 421986). You are probably looking for a change made after 421938 (known good), but no later than 421939 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/f1f0af26d41c5119403b0781d804f7860e237871..b65e0125470324a339ebf3831d755e68e3d8aea2 Thank You.
,
Oct 3 2016
- remove any indicators from the row - use the secondary ALL CAPS action with vertical separator ** Can we remove the "Yay!" from the default browser string. Replace it with something more internationally friendly: "Cheers." Mocks https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Browser.png%3Fz=width
,
Oct 3 2016
What will clicking on the left hand side of the row do? (Will it be click-able or have any result)? If the left hand side will have no effect on click, it seems strange to separate the left and right with a vertical bar. How about making this a toggle button? That would show the is/isn't effect of the row and match cleanly with the remaining UI.
,
Oct 3 2016
,
Oct 3 2016
My comments in #6 and #7 don't work well if a dialog or wizard is necessary to change the default browser. Hector mentioned that in Windows 10 there are more steps. A toggle button would be weird in that case. So the button makes more sense.
,
Oct 3 2016
aight, going ahead with | MAKE DEFAULT then
,
Oct 4 2016
bettes@: should both "MAKE DEFAULT" and the rest of the row be clickable in the not_default case?
,
Oct 4 2016
also, do we _need_ to say "default browser" 3 times?
,
Oct 4 2016
Re #10, my vote would be that only the button should be clickable. Re #11, the old Settings page included it 3x so it's not a regression. I played around a little but couldn't find a nice way to easily keep the 2-line row w/ button pattern and avoid that.
,
Oct 4 2016
It would be handy to know how often setting the default browser links out to external UI. I'm wondering if it would make sense to use the open-in-new icon on a two line row? My corp machines are controlled so I'm not able to change the default browser to see what happens.
,
Oct 4 2016
>> should both "MAKE DEFAULT" and the rest of the row be clickable in the not_default case? Just the button should be clickable >> "default browser" 3 times Not an issue for me.
,
Oct 4 2016
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe490e334ec2d4a543e0d1be91aacb6abaec688b commit fe490e334ec2d4a543e0d1be91aacb6abaec688b Author: dbeam <dbeam@chromium.org> Date: Tue Oct 04 18:53:54 2016 MD Settings: change "Yay!" to "Cheers." because Alan said so R=dschuyler@chromium.org BUG= 651720 Review-Url: https://codereview.chromium.org/2391803003 Cr-Commit-Position: refs/heads/master@{#422873} [modify] https://crrev.com/fe490e334ec2d4a543e0d1be91aacb6abaec688b/chrome/app/settings_chromium_strings.grdp [modify] https://crrev.com/fe490e334ec2d4a543e0d1be91aacb6abaec688b/chrome/app/settings_google_chrome_strings.grdp
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c59443f0412c8dd63a59f0e2ce556bfd7151e1d0 commit c59443f0412c8dd63a59f0e2ce556bfd7151e1d0 Author: dbeam <dbeam@chromium.org> Date: Tue Oct 04 20:09:20 2016 MD Settings: drop subpage arrow from default browser section Instead, show a "MAKE DEFAULT" button as a call to action so it's clearer how a user can change their default browser. R=dschuyler@chromium.org BUG= 651720 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2382243003 Cr-Commit-Position: refs/heads/master@{#422896} [modify] https://crrev.com/c59443f0412c8dd63a59f0e2ce556bfd7151e1d0/chrome/app/settings_strings.grdp [modify] https://crrev.com/c59443f0412c8dd63a59f0e2ce556bfd7151e1d0/chrome/browser/resources/settings/default_browser_page/default_browser_page.html [modify] https://crrev.com/c59443f0412c8dd63a59f0e2ce556bfd7151e1d0/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Oct 4 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Sep 30 2016