New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651720 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[MD Settings] Default browser should not have subpage arrow (doesn't go to a subpage)

Reported by rk...@etouch.net, Sep 30 2016

Issue description

Chrome Version: 55.0.2876.0 Revision 5c0e46df680c3284a99ae05aafaf52078674ea2d-refs/heads/master@{#421986}
OS: Windows(7,8,10), Mac(10.10.5,10.11.4) 

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://md-settings page and make chrome as 'Default browser'
(2) Then press Tab key and observe.

Actual: Unnecessary focus highlight is seen on iron icon which is not present there.

Expected: No such focus highlight should seen on it.

This is a regression issue, broken in 'M-55', will soon update the bisect info.

Good Build: 55.0.2875.0
Bad Build: 55.0.2876.0

 
Actual_Focus.mp4
372 KB View Download
Expected_Focus.mp4
507 KB View Download
Cc: dpa...@chromium.org

Comment 2 by dpa...@chromium.org, Sep 30 2016

Cc: dschuyler@chromium.org
Labels: -Pri-1 Proj-MaterialDesign-WebUI Pri-2

Comment 3 by dbeam@chromium.org, Sep 30 2016

Owner: dbeam@chromium.org
Status: Started (was: Unconfirmed)
i don't really think we should have a subpage icon in there yet
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2875.0 (Revision: 421703).
Bad build: 55.0.2876.0 (Revision: 421986).

You are probably looking for a change made after 421938 (known good), but no later than 421939 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/f1f0af26d41c5119403b0781d804f7860e237871..b65e0125470324a339ebf3831d755e68e3d8aea2

Thank You.
- remove any indicators from the row
- use the secondary ALL CAPS action with vertical separator 

** Can we remove the "Yay!" from the default browser string. Replace it with something more internationally friendly: "Cheers." 

Mocks
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Browser.png%3Fz=width


PREVIEW-Browser.png
109 KB View Download
What will clicking on the left hand side of the row do? (Will it be click-able or have any result)?

If the left hand side will have no effect on click, it seems strange to separate the left and right with a vertical bar.

How about making this a toggle button? That would show the is/isn't effect of the row and match cleanly with the remaining UI.
Screenshot from 2016-10-03 11:11:28.png
7.4 KB View Download
My comments in #6 and #7 don't work well if a dialog or wizard is necessary to change the default browser. Hector mentioned that in Windows 10 there are more steps. A toggle button would be weird in that case. So the button makes more sense.

Comment 9 by dbeam@chromium.org, Oct 3 2016

aight, going ahead with

  | MAKE DEFAULT

then
Cc: bettes@chromium.org
bettes@: should both "MAKE DEFAULT" and the rest of the row be clickable in the not_default case?
also, do we _need_ to say "default browser" 3 times?
Re #10, my vote would be that only the button should be clickable.

Re #11, the old Settings page included it 3x so it's not a regression. I played around a little but couldn't find a nice way to easily keep the 2-line row w/ button pattern and avoid that.
It would be handy to know how often setting the default browser links out to external UI. I'm wondering if it would make sense to use the open-in-new icon on a two line row? My corp machines are controlled so I'm not able to change the default browser to see what happens.
>> should both "MAKE DEFAULT" and the rest of the row be clickable in the not_default case?

Just the button should be clickable

>> "default browser" 3 times

Not an issue for me. 

Summary: [MD Settings] Default browser should not have subpage arrow (doesn't go to a subpage) (was: Regression:[MD Settings]Unnecessary focus highlight is seen on iron icon for 'Default browser' which is not present there.)
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c59443f0412c8dd63a59f0e2ce556bfd7151e1d0

commit c59443f0412c8dd63a59f0e2ce556bfd7151e1d0
Author: dbeam <dbeam@chromium.org>
Date: Tue Oct 04 20:09:20 2016

MD Settings: drop subpage arrow from default browser section

Instead, show a "MAKE DEFAULT" button as a call to action so it's clearer
how a user can change their default browser.

R=dschuyler@chromium.org
BUG= 651720 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2382243003
Cr-Commit-Position: refs/heads/master@{#422896}

[modify] https://crrev.com/c59443f0412c8dd63a59f0e2ce556bfd7151e1d0/chrome/app/settings_strings.grdp
[modify] https://crrev.com/c59443f0412c8dd63a59f0e2ce556bfd7151e1d0/chrome/browser/resources/settings/default_browser_page/default_browser_page.html
[modify] https://crrev.com/c59443f0412c8dd63a59f0e2ce556bfd7151e1d0/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Started)

Sign in to add a comment