New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651716 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Grey highlight is not seen properly on 'Arrow icon' in Md-settings for Arabic language.

Reported by dmascare...@etouch.net, Sep 30 2016 
Chrome Version:55.0.2876.0 (Official Build) 5c0e46df680c3284a99ae05aafaf52078674ea2d-refs/heads/master@{#421986}
OS: Windows (7,8,10)

Pre-condition: Change the browser language to Arabic.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/
2. Long press on arrow icon beside Customize font and observe highlight.

Actual:Grey highlight is not seen properly on 'Arrow icon'.
Expected:Grey highlight should be seen properly on 'Arrow icon'.

This is regression issue, broken in 'M 55' and below is manual bisect:

Good build:55.0.2875.0
Bad build:55.0.2876.0

Note: Issue is not issue on Mac and Linux OS.
Actual_grey.png
29.0 KB View Download

Comment 1 by msrchandra@chromium.org, Oct 3 2016

Labels: Proj-MaterialDesign-WebUI hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2875.0 (Revision: 421703).
Bad build: 55.0.2876.0 (Revision: 421986).

You are probably looking for a change made after 421938 (known good), but no later than 421939 (first known bad).
CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/f1f0af26d41c5119403b0781d804f7860e237871..b65e0125470324a339ebf3831d755e68e3d8aea2

@dschuyler -- Could you please look into the issue, pardon me if it is not related to your change and if possible please assign to the concern Dev.
Thank You.

Comment 2 by dschuyler@chromium.org, Oct 3 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a

commit f76c6502e7f4a6d57fe57aed25a60ce3845dd82a
Author: dschuyler <dschuyler@chromium.org>
Date: Tue Oct 18 00:43:49 2016

[MD settings] use arrow-forward to switch direction in rtl

This CL flips the arrow-forward to left or right based on the rtl/ltr
direction setting and corrects the placement of the paper ripple under
the icon on rtl.

Minor changes: changes the old style name from .arrow-right to
.arrow-forward (since left or right changes in rtl/ltr); there are also
some css variables added to replace some constants.

BUG= 651716 , 586579 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2390053002
Cr-Commit-Position: refs/heads/master@{#425837}

[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/reset_page/reset_page.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/settings_vars_css.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/f76c6502e7f4a6d57fe57aed25a60ce3845dd82a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Comment 4 by dschuyler@chromium.org, Oct 18 2016

Status: Fixed (was: Started)
►

Sign in to add a comment