Regression: Unnecessary page navigate to webstore after resetting to default theme in ‘chrome://md-settings'
Reported by
dmascare...@etouch.net,
Sep 30 2016
|
|||
Issue descriptionChrome Version:55.0.2876.0 (Official Build) 5c0e46df680c3284a99ae05aafaf52078674ea2d-refs/heads/master@{#421986} Os: Mac(10.10.4,10.11.5),Windows (7,8,10) Pre-condition: Theme should be installed on the profile What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings/ 2. Click on ‘Reset the theme’ and observe. Actual: Unnecessary page navigate to webstore after step 2. Expected: Page should not navigate to webstore after step 2. This is regression issue,broken ‘M55’ and will soon update the bisect info. Good build:55.0.2875.0 Bad build:55.0.2876.0 Will soon update Linux OS info.
,
Sep 30 2016
Using the per-revision bisect providing the bisect results, Good build:55.0.2875.0(Revision: 421703). Bad build: 55.0.2876.0 (Revision: 421986). You are probably looking for a change made after 421938 (known good), but no later than 421939 (first known bad). CHANGELOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/f1f0af26d41c5119403b0781d804f7860e237871..b65e0125470324a339ebf3831d755e68e3d8aea2 @dschuyler - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Review-Url: https://codereview.chromium.org/2356653002 Thanks!
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8e914c72b2e6e2d68f56e1f1d48c4f77f964859 commit a8e914c72b2e6e2d68f56e1f1d48c4f77f964859 Author: dschuyler <dschuyler@chromium.org> Date: Tue Oct 04 18:39:20 2016 [MD settings] remove icons from wallpaper and themes rows; avoid opening theme page on reset This CL removes the icons from the wallpaper and these rows (I believe that is approved by Alan). This also avoids having the themes page open up when resetting (removing) the current theme. BUG= 651715 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2390553004 Cr-Commit-Position: refs/heads/master@{#422866} [modify] https://crrev.com/a8e914c72b2e6e2d68f56e1f1d48c4f77f964859/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/a8e914c72b2e6e2d68f56e1f1d48c4f77f964859/chrome/browser/resources/settings/icons.html
,
Oct 4 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dmascare...@etouch.net
, Sep 30 2016706 KB
706 KB View Download