Loading chrome://history/syncedTabs results in an console error |
||
Issue description1. Open chrome://history/syncedTabs 2. Check console A console error happens when the synced tabs page is loaded directly, probably because lazy loading results in the synced device manager not having methods on it when history-app expects it to.
,
Sep 30 2016
yeah, probably an element upgrade issue
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a83af91846aa14ec789ea3b74eb11cac7b056a40 commit a83af91846aa14ec789ea3b74eb11cac7b056a40 Author: dbeam <dbeam@chromium.org> Date: Thu Nov 03 00:35:06 2016 MD History: fix script errors when navigating to /syncedTabs (or refreshing) Also simplifies sign in state changes by re-using existing updateSignInState method (which already exists and waits for upgrades). R=tsergeant@chromium.org BUG= 651707 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2456783006 Cr-Commit-Position: refs/heads/master@{#429478} [modify] https://crrev.com/a83af91846aa14ec789ea3b74eb11cac7b056a40/chrome/browser/resources/history/other_devices.js [modify] https://crrev.com/a83af91846aa14ec789ea3b74eb11cac7b056a40/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/a83af91846aa14ec789ea3b74eb11cac7b056a40/chrome/browser/resources/md_history/app.html [modify] https://crrev.com/a83af91846aa14ec789ea3b74eb11cac7b056a40/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/a83af91846aa14ec789ea3b74eb11cac7b056a40/chrome/browser/resources/md_history/compiled_resources2.gyp [modify] https://crrev.com/a83af91846aa14ec789ea3b74eb11cac7b056a40/chrome/browser/ui/webui/history_login_handler.cc
,
Nov 15 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by calamity@chromium.org
, Sep 30 2016