New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651705 link

Starred by 1 user
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Oct 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Debugger icon is seen misplaced in Sources tab of Dev tools.

Project Member Reported by susanjun...@techmahindra.com, Sep 30 2016 
Version: 55.0.2875.0 Dev
OS: Ubuntu 14.04, Windows

What steps will reproduce the problem?
(1)Launch Chrome and press F12 to open Dev tools windows.
(2)Go to Sources tab and observe the top/down Debugger icon on the RHS of the screen.

Expected:Top/down hide debugger icon is misplaced and placed on the top of the frame.
Actual:Instead, hide debugger icon should be at the bottom of the frame.

This is Regression issue broken in M-55. Will provide bisect soon.

Manual Bisect info:
Good build:55.0.2867.0 Dev
Bad build: 55.0.2868.0 Dev
actual_debugger.png
188 KB View Download
expected_debugger.png
159 KB View Download

Comment 1 by kavvaru@chromium.org, Sep 30 2016

Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.11.6 using chrome version 55.0.2875.0.

Comment 2 by susanjun...@techmahindra.com, Sep 30 2016

Labels: -Needs-Bisect hasbisect
Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)
Manual good and Bad Builds:
Good Build: 54.0.2867.0
Bad Build:  54.0.2868.0

Below is the Tool Bisect Info:

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/2215b4e8cb1fb332ad6e7b495435deb3f89f41f8..6f49ac36f10bb2c8fa3e1661dca9e9af8459134f

Suspecting https://codereview.chromium.org/2353033004

@dgozman : Please feel free to re-assign if this is not related to your change

Comment 4 by dgozman@chromium.org, Oct 11 2016

Labels: Merge-Request-55
Status: Fixed (was: Assigned)
Verified in mac canary 56.0.2886.0. Requesting merge to M-55.

Comment 5 by dimu@chromium.org, Oct 11 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 11 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45b55807ff8de03fa7d9057100ae0e3f3861b3ac

commit 45b55807ff8de03fa7d9057100ae0e3f3861b3ac
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Oct 11 02:02:49 2016

Merge to 2883 "[DevTools] Support top/bottom show sidebar button."
> [DevTools] Support top/bottom show sidebar button.
>
> BUG= 651705 
>
> Review-Url: https://codereview.chromium.org/2395333002
> Cr-Commit-Position: refs/heads/master@{#423998}
(cherry picked from commit 35bb5043ed9e6f455d3c725d755ebfc76b53cf2b)
TBR=lushnikov@chromium.org

Review URL: https://codereview.chromium.org/2401353004 .

Cr-Commit-Position: refs/branch-heads/2883@{#32}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/45b55807ff8de03fa7d9057100ae0e3f3861b3ac/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/45b55807ff8de03fa7d9057100ae0e3f3861b3ac/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
[modify] https://crrev.com/45b55807ff8de03fa7d9057100ae0e3f3861b3ac/third_party/WebKit/Source/devtools/front_end/sources/sourcesView.css
[modify] https://crrev.com/45b55807ff8de03fa7d9057100ae0e3f3861b3ac/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
[modify] https://crrev.com/45b55807ff8de03fa7d9057100ae0e3f3861b3ac/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css

Comment 7 by pbomm...@chromium.org, Oct 11 2016

Labels: TE-Verified-55.0.2883.9
Verified the fix on Chrome version 55.0.2883.9 on Windows 7,10, Mac 10.11.6 and Linux(ubuntu 14.04Lts).
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45b55807ff8de03fa7d9057100ae0e3f3861b3ac

commit 45b55807ff8de03fa7d9057100ae0e3f3861b3ac
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Oct 11 02:02:49 2016

Merge to 2883 "[DevTools] Support top/bottom show sidebar button."
> [DevTools] Support top/bottom show sidebar button.
>
> BUG= 651705 
>
> Review-Url: https://codereview.chromium.org/2395333002
> Cr-Commit-Position: refs/heads/master@{#423998}
(cherry picked from commit 35bb5043ed9e6f455d3c725d755ebfc76b53cf2b)
TBR=lushnikov@chromium.org

Review URL: https://codereview.chromium.org/2401353004 .

Cr-Commit-Position: refs/branch-heads/2883@{#32}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/45b55807ff8de03fa7d9057100ae0e3f3861b3ac/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/45b55807ff8de03fa7d9057100ae0e3f3861b3ac/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
[modify] https://crrev.com/45b55807ff8de03fa7d9057100ae0e3f3861b3ac/third_party/WebKit/Source/devtools/front_end/sources/sourcesView.css
[modify] https://crrev.com/45b55807ff8de03fa7d9057100ae0e3f3861b3ac/third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
[modify] https://crrev.com/45b55807ff8de03fa7d9057100ae0e3f3861b3ac/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment