Issue metadata
Sign in to add a comment
|
Regression: Spacing issue is seen in about page of md-settings |
||||||||||||||||||||||
Issue descriptionVersion: 55.0.2876.0 dev OS: Windows What steps will reproduce the problem? (1) Launch chrome and go to chrome://md-settings/help and observe spacing between tick mark and build number text Expected: Some space should be seen between text and tick mark. Actual: Instead no space is seen between. This is a regression issue broken in M55. Will provide other info soon Good Build: 55.0.2874.0 dev Bad Build: 55.0.2876.0 dev
,
Sep 30 2016
,
Oct 3 2016
Able to reproduce the issue on Windows 10 using chrome reported version #55.0.2876.0 and latest canary #55.0.2878.0. Bisect Information: ===================== Good build: 55.0.2875.0 Bad Build : 55.0.2876.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/f1f0af26d41c5119403b0781d804f7860e237871..b65e0125470324a339ebf3831d755e68e3d8aea2 From the above change log suspecting below change Review url: https://codereview.chromium.org/2356653002 dschuyler@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Oct 3 2016
,
Oct 4 2016
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a8c579d6896e1fe9cc3909770288e5cb63f2886 commit 3a8c579d6896e1fe9cc3909770288e5cb63f2886 Author: dschuyler <dschuyler@chromium.org> Date: Thu Oct 06 18:50:32 2016 [MD settings] tweaks to what is shown in about page; and css cleanup This CL hides the vertical grey bar (secondary action separator) in the version row of the About page (when appropriate). It also adjusts the spacing around the icon in that row to better match the mocks. While doing the above I noticed there was an old reference to --iron-icon-spacing which is obsolete so I removed references to that as well. BUG= 651697 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2387053004 Cr-Commit-Position: refs/heads/master@{#423607} [modify] https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html [modify] https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html [modify] https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886/chrome/browser/resources/settings/people_page/setup_pin_dialog.html [modify] https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886/chrome/test/data/webui/settings/about_page_tests.js
,
Oct 6 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a8c579d6896e1fe9cc3909770288e5cb63f2886 commit 3a8c579d6896e1fe9cc3909770288e5cb63f2886 Author: dschuyler <dschuyler@chromium.org> Date: Thu Oct 06 18:50:32 2016 [MD settings] tweaks to what is shown in about page; and css cleanup This CL hides the vertical grey bar (secondary action separator) in the version row of the About page (when appropriate). It also adjusts the spacing around the icon in that row to better match the mocks. While doing the above I noticed there was an old reference to --iron-icon-spacing which is obsolete so I removed references to that as well. BUG= 651697 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2387053004 Cr-Commit-Position: refs/heads/master@{#423607} [modify] https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html [modify] https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html [modify] https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886/chrome/browser/resources/settings/people_page/setup_pin_dialog.html [modify] https://crrev.com/3a8c579d6896e1fe9cc3909770288e5cb63f2886/chrome/test/data/webui/settings/about_page_tests.js
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kavvaru@chromium.org
, Sep 30 2016