Issue metadata
Sign in to add a comment
|
Rename Animation, AnimationPlayer to match Blink representations |
||||||||||||||||||||||||
Issue descriptionWe had the following changes in Blink: KeyframeEffect -> KeyframeEffectModel (internal) Animation -> KeyframeEffect AnimationEffect -> EffectModel AnimationNode -> AnimationEffect (internal), AnimationEffectReadOnly (idl) AnimationPlayer -> Animation Timing (internal), AnimationNodeTiming (idl), -> AnimationEffectTiming See this CL: https://codereview.chromium.org/1113173003 So we need to rename cc::Animation, cc::AnimationPlayer, blink::CompositorAnimation, blink::CompositorAnimationPlayer to match Blink core/animation representations.
,
Oct 18 2016
,
Nov 9 2016
,
Nov 22 2016
,
Nov 22 2016
,
Nov 22 2016
At the moment, I think that we don't need it. As a first stage, we need to design new names for cc::Animation (cc::KeyframeEffect?), cc::AnimationCurve (and all the derived classes), cc::KeyframedColorAnimationCurve and friends.
,
Nov 30 2016
ajuma@: we have two different notions of "Activate" in the animation code: pending-tree-to-active-tree "activation", and "activation" in the sense of going from not having any animations to having animations. This is pretty confusing so it might be worth renaming the latter.
,
Dec 11 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 13 2017
,
Mar 30 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by suzyh@chromium.org
, Oct 13 2016