New issue
Advanced search Search tips

Issue 651682 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug
Launch-M-Target: 64-Beta

Blocked on:
issue 774563

Blocking:
issue 630357


Show other hotlists

Hotlists containing this issue:
HarmonyFutureP1s


Sign in to add a comment

Harmony - update Smart Lock auto sign-in dialog

Project Member Reported by shrike@chromium.org, Sep 30 2016

Issue description

Labels: -OS-Mac

Comment 2 by shrike@chromium.org, Oct 11 2016

Owner: kylixrd@chromium.org

Comment 3 by shrike@chromium.org, Dec 14 2016

If you add a screenshot of this dialog as it exists now I can list the exact changes that need to be made to Harmonize it.

Comment 4 by tapted@chromium.org, Mar 14 2017

Description: Show this description
Labels: -M-56
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10
Here is the latest incarnation of the smart-lock dialog with a single credential.
SmartLockSingleCredential.png
5.1 KB View Download
The NextAction date has arrived: 2017-11-10
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98d6ac3cb23b5b06afa97b71a0f34e80c1060a24

commit 98d6ac3cb23b5b06afa97b71a0f34e80c1060a24
Author: Allen Bauer <kylixrd@chromium.org>
Date: Fri Nov 10 15:47:03 2017

Make sure the auto signin prompt is snapped to at least 320. Fix browser dialog test to show auto signin prompt.

Bug: 651682
Change-Id: I9da1c20d416df5f12900b9f94acf962691ea93b8
Reviewed-on: https://chromium-review.googlesource.com/761417
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515559}
[modify] https://crrev.com/98d6ac3cb23b5b06afa97b71a0f34e80c1060a24/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/98d6ac3cb23b5b06afa97b71a0f34e80c1060a24/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify] https://crrev.com/98d6ac3cb23b5b06afa97b71a0f34e80c1060a24/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

Here's the latest auto sign-in bubble.
AutoSignin.png
2.5 KB View Download
Blockedon: 774563
The body of the dialog is the same as the individual credential items in the dialog from https://crbug.com/651681. Should the login name (the email in the above examples) be a darker color in all instance or only this one? What is the darker color value. Currently that color is 0x212121, which is the same as "primary" colors.
Cc: kylixrd@chromium.org
Owner: bettes@chromium.org

Sign in to add a comment