New issue
Advanced search Search tips

Issue 651681 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug
Launch-M-Target: 64-Beta

Blocked on:
issue 774563

Blocking:
issue 630357



Sign in to add a comment

Harmony - update Smart Lock dialog

Project Member Reported by shrike@chromium.org, Sep 30 2016

Issue description

Please attach to this bug instructions for making this dialog visible.

Mock link here (and zoomed image attached):

https://docs.google.com/presentation/d/1NCYvxQ8VWuDDIK1uTiOL6zXQ1H0fJEoKxTivG8NIFVg/edit#slide=id.g15ebaef349_0_39
 
P - smartlock_03.png
72.2 KB View Download
P - smartlock_04.png
70.4 KB View Download
Screen Shot 2016-09-29 at 9.18.38 PM.png
74.6 KB View Download

Comment 2 by shrike@chromium.org, Sep 30 2016

Also, here's the mock with one of the accounts selected. This mock has a slightly larger dialog than the one in c#1 - the dialog should not resize when an account is selected.

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview#%2FP%20-%20smartlock_04.png%3Fz=width
Labels: -OS-Mac

Comment 4 by shrike@chromium.org, Oct 11 2016

Owner: kylixrd@chromium.org

Comment 5 by shrike@chromium.org, Oct 11 2016

Components: Internals>Views>Desktop

Comment 6 by shrike@chromium.org, Dec 14 2016

If you add a screenshot of this dialog as it exists now I can list the exact changes that need to be made to Harmonize it.

Comment 7 by tapted@chromium.org, Mar 14 2017

Description: Show this description

Comment 8 by tapted@chromium.org, Mar 14 2017

Cc: bettes@chromium.org
ping bettes@: What are the fonts?

Issue 651682 (auto-signin bubble) is easy, since it's an example in the spec ( Issue 691891 ) - for the bubble I think it's:
  "Signing in as" -> Body2+Hint
  "user@example.com" -> Body2+Primary

For this
  "Sign in with your account saved with" -> Title+Primary
  "Google Smart Lock" -> Title+Link
  "User Name" -> Body2+Primary
  "user@example.com" -> Body2+Secondary (or Hint?)

(also should "Google Smart Lock" always appear on a line by itself? .. (even if that would be a third line if the first line translates to a really long string?))
Having a multiline link in the title is a problem.  Can we change to something like:

Sign in

Account data saved with _Google Smart Lock_.

[Rest of body]

Here "Sign in" is the title and the subsequent sentence appears at the top of the body.  Wordsmithing subject to change, but shorter titles are better.
Cc: pkasting@chromium.org
This looks like a change in workflow in addition to mere UI changes.

This is the current dialog:

Instead of a "Sign in" button, there is only a "Cancel" button. This is because merely clicking on one of the listed accounts selects and dismisses the dialog.

The new work-flow looks like one selects an account (which adds the green check mark) and then presses the "Sign in" button.
Smart Lock Multi-Account.png
14.0 KB View Download
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc73643302ad7ea271c063fb21fbb8c047cf837e

commit cc73643302ad7ea271c063fb21fbb8c047cf837e
Author: Allen Bauer <kylixrd@chromium.org>
Date: Fri Jul 07 19:08:03 2017

In Harmony mode, the smart-lock account chooser dialog's size is calculated rather than hard-coded.


Added mulitple credential Sign In interacive browser test.

Bug: 651681
Change-Id: I62fb366f4d2304e5fff2c7703b79d4187c9e21ac

PreMD - https://drive.google.com/open?id=0B6LQg8CWo5bNZ3VqSzRiY2VXTWc
MD    - https://drive.google.com/open?id=0B6LQg8CWo5bNcm1SdGlCVmJvWXM

Change-Id: I62fb366f4d2304e5fff2c7703b79d4187c9e21ac
Reviewed-on: https://chromium-review.googlesource.com/561976
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485000}
[modify] https://crrev.com/cc73643302ad7ea271c063fb21fbb8c047cf837e/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
[modify] https://crrev.com/cc73643302ad7ea271c063fb21fbb8c047cf837e/chrome/browser/ui/views/passwords/account_chooser_dialog_view.h
[modify] https://crrev.com/cc73643302ad7ea271c063fb21fbb8c047cf837e/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

Labels: -M-56
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10
The NextAction date has arrived: 2017-11-10

Comment 16 Deleted

From what I can gather, the remaining tasks for this dialog are typography related. Forcing the width to 320px may also be needed.
Blockedon: 774563

Sign in to add a comment