Harmony - update Smart Lock first run dialog |
|||||||||
Issue descriptionPlease attach to this bug instructions for making this dialog visible. Mock here: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview#%2FP%20-%20smartlock_05.png%3Fz=width
,
Oct 11 2016
,
Jan 24 2017
Unassigning my Harmony bugs pending re-triage of who should own what.
,
Jun 29 2017
,
Jul 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8bac8b678e69aa152968a5099da30f3b6847ca6 commit f8bac8b678e69aa152968a5099da30f3b6847ca6 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Jul 04 09:33:52 2017 Harmonize Smart Lock First Run dialog. I couldn't find a clear reason why the dialog had hand-rolled its title and buttons, so I removed all that code and used a basic layout. This patch should be the extent of Harmony changes specific to this dialog. Bug: 651680 ,702196 Change-Id: I0e40d00c0bc13df19a25b4884e5d533e463c07a7 Reviewed-on: https://chromium-review.googlesource.com/557139 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#484076} [modify] https://crrev.com/f8bac8b678e69aa152968a5099da30f3b6847ca6/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc [modify] https://crrev.com/f8bac8b678e69aa152968a5099da30f3b6847ca6/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.h
,
Aug 9 2017
,
Sep 5 2017
,
Sep 5 2017
,
Nov 10 2017
The NextAction date has arrived: 2017-11-10
,
Jan 11 2018
- width should be 448 for centered, modal dialogs
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12b46ae00248f4076f6b9f1c1c262a9f59e422b0 commit 12b46ae00248f4076f6b9f1c1c262a9f59e422b0 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jan 17 04:12:19 2018 Change modal Smart Lock Auto-Signin First Run dialog width to 448. Also includes some minor refactoring. Bug: 651680 Change-Id: Ib0d47495151a8e3e9e1ce86f91e1207221896fc0 Reviewed-on: https://chromium-review.googlesource.com/865537 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#529597} [modify] https://crrev.com/12b46ae00248f4076f6b9f1c1c262a9f59e422b0/chrome/browser/ui/passwords/password_dialog_prompts.h [modify] https://crrev.com/12b46ae00248f4076f6b9f1c1c262a9f59e422b0/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc [modify] https://crrev.com/12b46ae00248f4076f6b9f1c1c262a9f59e422b0/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.h
,
Jan 17 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
/Secondary%20UI%20Previews%20and%20specs%20(exports)/Preview#%2FP%20-%20smartlock_05.png%3Fz=width){kind=link}
Comment 1 by shrike@chromium.org
, Oct 1 2016