New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651677 link

Starred by 1 user
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD History] Duplicate history entry seen when loading a new history page

Project Member Reported by tsergeant@chromium.org, Sep 30 2016 
Steps to reproduce:

1. Open MD history page in a profile with many results
2. Scroll to bottom of page so that new data loads in
3. Observe that the last history item from the first page of results is the same as the first item from the new page of results.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d556f1183c63ea3cda2f21dfe64187c885c9a32

commit 2d556f1183c63ea3cda2f21dfe64187c885c9a32
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Sep 30 05:38:15 2016

MD History: Round down timestamp used for incremental queries

This ensures that results from incremental queries are strictly
older than existing results, while retaining millisecond accuracy.
This is equivelant behavior to the old History page, which rounds
down the timestamp using new Date().

BUG= 651677 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2377383003
Cr-Commit-Position: refs/heads/master@{#422035}

[modify] https://crrev.com/2d556f1183c63ea3cda2f21dfe64187c885c9a32/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/2d556f1183c63ea3cda2f21dfe64187c885c9a32/chrome/browser/resources/md_history/list_container.js

Comment 2 by tsergeant@chromium.org, Sep 30 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment