Run http://w3c-test.org/touch-events/touch-touchevent-constructor.html Get: assert_throws: Touch constructor with null target function "function () {new Touch({ identifier: testIdentifier, target: null });}" did not throw at Object.<anonymous> (http://w3c-test.org/touch-events/touch-touchevent-constructor.html:32:5) at Object.Test.step (http://w3c-test.org/resources/testharness.js:1401:25) at test (http://w3c-test.org/resources/testharness.js:501:18) at http://w3c-test.org/touch-events/touch-touchevent-constructor.html:28:1 This is because target is defined to be nullable - issue 647693 . foolip@ only recently expanded the test to catch this: https://github.com/w3c/web-platform-tests/commit/8221d3049f6008c5adeb0555b7b37b4f6d7ca15d This API is rarely used, it should be fine to just make this non-nullable as a bug fix (no intent necessary). Also no reason to write a separate test for this, just need to make sure this test from WPT is imported and passing.
I want to handle this issue
I was going to measure this in https://codereview.chromium.org/2352333002/ but given that it's already required I think the risk is low enough that it's OK to just fix it. Please go ahead an upload a CL, corona10@.
foolip@ I upload CL on https://codereview.chromium.org/2377203004/ and I add you for reviewer too.
parking with chongz@ for now since it needs to be with a formal project member.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1684499da03309f51c4d7280ba1181a2419651f1 commit 1684499da03309f51c4d7280ba1181a2419651f1 Author: foolip <foolip@chromium.org> Date: Sat Oct 01 08:47:44 2016 Import wpt@09907a9c4bcee14986431d53e4381384c7c69107 Using update-w3c-deps in Chromium 2bce9cb8f98aaed076e6129966aaf38a9f001fd1. BUG= 651660 Review-Url: https://codereview.chromium.org/2376103007 Cr-Commit-Position: refs/heads/master@{#422309} [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/common/get-host-info.sub.js [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/CustomElementRegistry.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/adopted-callback-expected.txt [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/adopted-callback.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/attribute-changed-callback.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/connected-callbacks-expected.txt [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/connected-callbacks.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/disconnected-callbacks-expected.txt [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/disconnected-callbacks.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reaction-timing.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/ChildNode.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Document-expected.txt [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Document.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Element.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/Node.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/ParentNode.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/reactions/resources/reactions.js [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/resources/document-types.js [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/resources/empty-html-document.html [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/diff-manifest.py [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/dom/events/Event-dispatch-other-document.html [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/selectors.js [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/trusted-click.js [delete] https://crrev.com/84526ade9b6d246a8834309d0519d2255c0db91d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-checkValidity.html [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity.html [delete] https://crrev.com/84526ade9b6d246a8834309d0519d2255c0db91d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-validity-stepMismatch.html [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-validity-valid.html [delete] https://crrev.com/84526ade9b6d246a8834309d0519d2255c0db91d/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-meter-element/meter-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-meter-element/meter.html [delete] https://crrev.com/84526ade9b6d246a8834309d0519d2255c0db91d/third_party/WebKit/LayoutTests/imported/wpt/html/syntax/serializing-html-fragments/initial-linefeed-pre-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/html/syntax/serializing-html-fragments/initial-linefeed-pre.html [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/html/syntax/serializing-html-fragments/serializing-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/html/syntax/serializing-html-fragments/serializing.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_attributes_nohover_pointers-manual-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_capture_suppressing_mouse-manual.html [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_constructor.html [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_lostpointercapture_is_first-manual.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointermove_on_chorded_mouse_button-manual.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_releasepointercapture_events_to_original_target-manual-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_releasepointercapture_events_to_original_target-manual.html [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_setpointercapture_relatedtarget-manual.html [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_support.js [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/resources/pointerevent_pointerId_scope-iframe.html [add] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/touch-events/touch-touchevent-constructor-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/imported/wpt/touch-events/touch-touchevent-constructor.html [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/platform/linux/imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/platform/win/imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt [modify] https://crrev.com/1684499da03309f51c4d7280ba1181a2419651f1/third_party/WebKit/LayoutTests/platform/win7/imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60342433ae665fc1c9f2ae8cb12186f29b523043 commit 60342433ae665fc1c9f2ae8cb12186f29b523043 Author: corona10 <corona10@gmail.com> Date: Sat Oct 01 23:24:20 2016 Make target member of the TouchInit dictionary non-nullable BUG= 647693 , 651660 Review-Url: https://codereview.chromium.org/2377203004 Cr-Commit-Position: refs/heads/master@{#422334} [delete] https://crrev.com/502fceb9cf8e8c70ba2f90c5dac08cc62ef385d3/third_party/WebKit/LayoutTests/imported/wpt/touch-events/touch-touchevent-constructor-expected.txt [modify] https://crrev.com/60342433ae665fc1c9f2ae8cb12186f29b523043/third_party/WebKit/Source/core/dom/TouchInit.idl
Comment 1 by coron...@gmail.com
, Sep 30 2016