New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651654 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Address bar search hinting doesn't allow forward slash

Reported by daarisd...@gmail.com, Sep 30 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Steps to reproduce the problem:
1. visit a website with /foo/ in the url; http://www.example.com/foo/
2. type /foo
3. no search hinting will appear

What is the expected behavior?
http://www.example.com/foo/ should appear in the url

What went wrong?
Chrome does allow partial search, so typing "foo" will work, but for some reason it doesn't consider "/foo" to match with example.com/foo/ url.

Did this work before? N/A 

Chrome version: 53.0.2785.116  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0
 
Cc: rnimmagadda@chromium.org
Components: UI>Browser>Navigation
Labels: M-55 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to repro this issue on Windows 7, MAC (10.11.6) & Ubuntu Trusty (14.04) for Google Chrome Stable Version - 53.0.2785.143

This is a Non-Regression issue existing from M30 - # 30.0.1549.0
651654.mov
3.4 MB Download
Furthermore:

If http://www.example.com/foo/bar is visited

/foo doesn't return the url
/bar DOES return the url

So seems to only happen in the first part of the path of a URL.

Another example: after visiting this page, /chromium returns this issues URL, but /p/chromium does not.

Comment 3 by creis@chromium.org, Sep 30 2016

Components: -UI>Browser>Navigation UI>Browser>Omnibox
Owner: mpear...@chromium.org
->mpearson who understands the tokenizing of the HQP better here
Components: -UI
Labels: -OS-Linux -OS-Windows -Pri-2 -OS-Mac OS-All Pri-3
Status: Assigned (was: Untriaged)
Nice detective work on determining when things work and when they don't.

I think we're treating /foo as a match in the registry (.com, .co.uk, etc.) and giving it no credit.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ca732414effb6ee392b4e49a02892111783a2e3

commit 1ca732414effb6ee392b4e49a02892111783a2e3
Author: mpearson <mpearson@chromium.org>
Date: Wed Oct 19 18:51:52 2016

Omnibox: Improve HQP Scoring for Terms that Start with Punctuation

Properly calculate match locations for various inputs, e.g.,
"://ww" should count as a hostname match because that's where
the main word part starts.

BUG= 651654 

Review-Url: https://chromiumcodereview.appspot.com/2421373003
Cr-Commit-Position: refs/heads/master@{#426252}

[modify] https://crrev.com/1ca732414effb6ee392b4e49a02892111783a2e3/components/omnibox/browser/scored_history_match.cc
[modify] https://crrev.com/1ca732414effb6ee392b4e49a02892111783a2e3/components/omnibox/browser/scored_history_match_unittest.cc

Status: Fixed (was: Started)
Not sure if this is the place, or the time for it, or if this messes up this ticketing system but I use this daily so...

Thanks :)
You're welcome.

I'm sorry though that this change will roll out slowly.  It'll appear on the dev channel next week but will likely only hit stable sometime in early 2017.  (This bug doesn't meet the bar for seriousness that would allow me to patch it into things that would get to stable sooner.)

Can I get my thanks back then?

;)

Sign in to add a comment