Shelf item tooltips do not appear when auto-hidden shelf is exposed (regression) |
||||||
Issue descriptionVersion: 54.0.2809.0 OS: Chrome OS What steps will reproduce the problem? (1) Make shelf auto-hide (2) Expose it (bring a mouse pointer to the bottom of the screen) (3) Hover over a shelf item What is the expected output? Tooltip appears. What do you see instead? No tooltip. This is a regression after https://codereview.chromium.org/2176813002 (r407927). Tried at r407926 and the tooltips appear properly. msw@, can you please take a look if this is indeed a result of that change?
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87ee8b86123d1ecf3f9d458ccf92674d3e7b75fc commit 87ee8b86123d1ecf3f9d458ccf92674d3e7b75fc Author: msw <msw@chromium.org> Date: Fri Sep 30 19:47:58 2016 Show tooltips in SHELF_AUTO_HIDE ShelfVisibilityState. Tooltips should show when the auto-hidden shelf is exposed. Regressed in https://codereview.chromium.org/2176813002 BUG= 651645 TEST=Shelf shows tooltips in auto-hide state; see bug. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2383833003 Cr-Commit-Position: refs/heads/master@{#422190} [modify] https://crrev.com/87ee8b86123d1ecf3f9d458ccf92674d3e7b75fc/ash/common/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/87ee8b86123d1ecf3f9d458ccf92674d3e7b75fc/ash/common/shelf/shelf_tooltip_manager_unittest.cc
,
Sep 30 2016
Requesting merge to M-54 (branch 2840); this is a simple fix for a regression.
,
Oct 1 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1f39367d86d336f97ff7c0b54f6e98bf16569b2 commit c1f39367d86d336f97ff7c0b54f6e98bf16569b2 Author: Michael Wasserman <msw@chromium.org> Date: Mon Oct 03 18:06:55 2016 Show tooltips in SHELF_AUTO_HIDE ShelfVisibilityState. Tooltips should show when the auto-hidden shelf is exposed. Regressed in https://codereview.chromium.org/2176813002 BUG= 651645 TEST=Shelf shows tooltips in auto-hide state; see bug. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2383833003 Cr-Commit-Position: refs/heads/master@{#422190} (cherry picked from commit 87ee8b86123d1ecf3f9d458ccf92674d3e7b75fc) Review URL: https://codereview.chromium.org/2388893002 . Cr-Commit-Position: refs/branch-heads/2840@{#621} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/c1f39367d86d336f97ff7c0b54f6e98bf16569b2/ash/common/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/c1f39367d86d336f97ff7c0b54f6e98bf16569b2/ash/common/shelf/shelf_tooltip_manager_unittest.cc
,
Oct 3 2016
Fixed, please verify on the next M-54 beta, and on ToT/M-55.
,
Oct 13 2016
ChromeOS build 8743.65.0, 54.0.2840.59
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1f39367d86d336f97ff7c0b54f6e98bf16569b2 commit c1f39367d86d336f97ff7c0b54f6e98bf16569b2 Author: Michael Wasserman <msw@chromium.org> Date: Mon Oct 03 18:06:55 2016 Show tooltips in SHELF_AUTO_HIDE ShelfVisibilityState. Tooltips should show when the auto-hidden shelf is exposed. Regressed in https://codereview.chromium.org/2176813002 BUG= 651645 TEST=Shelf shows tooltips in auto-hide state; see bug. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2383833003 Cr-Commit-Position: refs/heads/master@{#422190} (cherry picked from commit 87ee8b86123d1ecf3f9d458ccf92674d3e7b75fc) Review URL: https://codereview.chromium.org/2388893002 . Cr-Commit-Position: refs/branch-heads/2840@{#621} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/c1f39367d86d336f97ff7c0b54f6e98bf16569b2/ash/common/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/c1f39367d86d336f97ff7c0b54f6e98bf16569b2/ash/common/shelf/shelf_tooltip_manager_unittest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by msw@chromium.org
, Sep 30 2016