New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651644 link

Starred by 1 user
Status: Fixed
Owner:
mlamouri@chromium.org
Closed: Jul 2017
Cc:
█ avayvod@chromium.org
mlamouri@chromium.org
steimel@chromium.org
█ dah...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature



Sign in to add a comment

Record metrics for visibility of media toolbar buttons

Project Member Reported by k...@chromium.org, Sep 30 2016 
We would like to understand the CTR for the various media toolbar buttons so we can better prioritize the toolbar buttons. Therefore, we would like to add either a histogram or user action that can record how often each toolbar button is visible, e.g. CC/closed caption/full screen.

Comment 1 by mlamouri@chromium.org, Sep 30 2016

Labels: M-56

Comment 2 by renganat...@chromium.org, Oct 7 2016

Status: Available (was: Untriaged)

Comment 3 by k...@chromium.org, Oct 11 2016

Blocking: -638807
Removing blocking label since this doesn't block the launch of the responsive media player.

Comment 4 by mlamouri@chromium.org, Dec 8 2016

Labels: -M-56 M-57

Comment 5 by mlamouri@chromium.org, Feb 18 2017

Labels: -Pri-3 -M-57 M-58 Pri-2

Comment 6 by mlamouri@chromium.org, Apr 24 2017

Cc: mlamouri@chromium.org
Labels: -M-58 M-60
Owner: steimel@chromium.org
Status: Assigned (was: Available)

Comment 7 by mlamouri@chromium.org, Apr 28 2017

Cc: avayvod@chromium.org

Comment 8 by mlamouri@chromium.org, Jul 11 2017

Cc: steimel@chromium.org
Labels: -Type-Bug -Pri-2 -M-60 M-61 Pri-1 Type-Feature
Owner: mlamouri@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeb364f107e1c979ede259f90d8f83fe89be9969

commit aeb364f107e1c979ede259f90d8f83fe89be9969
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Fri Jul 14 12:06:41 2017

Media Controls: record display and interaction will buttons and sliders for CTR.

Adding the necessary scaffolding to compute the CTR of media controls
elements with as much precision as possible. This is not computing CTR
using visibility to the user but hypothetical visibility on the page in
the sense that the element was displayed in the controls but maybe never
scrolled into view.

In order for an element to be marked as displayed, the element has to
have metadata downloaded or be set to not preload by the page or the
browser.

This CL also removes the CTR code for the download button and the cast
overlay button given that this code is more precise and more generic.

Bug:  651644 
Change-Id: I86c2bc4d1a19ab99a211082d8b3546b79ea71144
Reviewed-on: https://chromium-review.googlesource.com/567194
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Jennifer Apacible <apacible@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486741}
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDivElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDivElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementBase.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlFullscreenButtonElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElement.h
[add] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlInputElementTest.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlMuteButtonElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuButtonElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPlayButtonElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.cpp
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/third_party/WebKit/Source/modules/media_controls/elements/MediaControlVolumeSliderElement.h
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/aeb364f107e1c979ede259f90d8f83fe89be9969/tools/metrics/histograms/histograms.xml

Comment 10 by mlamouri@chromium.org, Jul 14 2017

Cc: dah...@chromium.org
Status: Fixed (was: Started)
►

Sign in to add a comment