New issue
Advanced search Search tips

Issue 651639 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
jam@chromium.org
rockot@google.com
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

mojo: Collapse exe:chrome and exe:content_browser into a single name

Project Member Reported by jamescook@chromium.org, Sep 29 2016 
Under mash we have cases where code in //ash needs to connect to an interface implemented in //chrome/browser.

When running ash out-of-process ("mash") we connect to "exe:chrome".

However, when running ash in-process ("classic ash") we have to connect to "exe:content_browser", because it's really just the browser process connecting to itself.

It would be great if there was a single name we could use all the time.

Is that feasible? How would I do it?

Comment 1 by sky@chromium.org, Sep 30 2016 

It's the mojo shell that handles knowing that exe:chrome corresponds to something on disk named chrome. If you are starting the shell internally you can alter that mapping. See https://chromium.googlesource.com/chromium/src/+/master/chrome/app/mash/mash_runner.cc#49 for examples of that. Unfortunately that requires a special NativeRunnerDelegate . So, we could make chrome --mash work correctly, but not the mojo_runner case. I'm not sure if manifests offer some way to accomplish this mapping.

An easy short term workaround is pass the name to connect to into ShellInitParams. mus can pass in exe:chrome.

Comment 2 by jamescook@chromium.org, Apr 19 2018

Components: Internals>Services>Ash
Labels: -Proj-Mustash-Mash

Comment 3 by roc...@chromium.org, Oct 17

Cc: -roc...@chromium.org rockot@google.com
►

Sign in to add a comment