New issue
Advanced search Search tips

Issue 651632 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 651293
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in TIFFFetchDirectory

Project Member Reported by ClusterFuzz, Sep 29 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5428787238141952

Fuzzer: libfuzzer_pdf_codec_tiff_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  TIFFFetchDirectory
  TIFFReadDirectory
  TIFFClientOpen
  
Recommended Security Severity: Medium


Minimized Testcase (0.16 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94co4EM3WIeEWlGdYiKPYjeScfljQgSXsydvFAfYzftp_dU-x2WSuZ1hnxFBKKoyrP4ytODkO_HmntrevXry6uzVuQx9vJVBdaUwF7L09YYwzoscnYyoJagtz1KT9oWlLQxwU1_qBy8yxVn6Z0AuT51b9jZug?testcase_id=5428787238141952

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 30 2016

Labels: M-54
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 30 2016

Labels: Pri-1

Comment 3 by kenrb@chromium.org, Sep 30 2016

Mergedinto: 651293
Status: Duplicate (was: Untriaged)

Comment 4 by aarya@google.com, Sep 30 2016

Status: Assigned (was: Duplicate)
Not a duplicate, incorrectly marked.

Comment 5 by kenrb@chromium.org, Sep 30 2016

Cc: tsepez@chromium.org och...@chromium.org
Owner: dsinclair@chromium.org

Comment 6 by kenrb@chromium.org, Sep 30 2016

Components: Internals>Plugins>PDF
Note, the TIFF plugin is used in XFA, so is not currently used in any release of Chromium as XFA is disabled.
Status: Started (was: Assigned)
https://codereview.chromium.org/2389993002/
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/76383db4906c9357292846ace77566b34eb47de9

commit 76383db4906c9357292846ace77566b34eb47de9
Author: dsinclair <dsinclair@chromium.org>
Date: Mon Oct 03 20:59:57 2016

Fix potentially uninitialized value.

Depending on what ReadOK does it's possible for |dircount16| to be used without
being initialized. The read code calls back into PDFium specific code which then
calls into the stream reading code.

Initialize the value to be sure it is set.

BUG= chromium:651632 

Review-Url: https://codereview.chromium.org/2389993002

[add] https://crrev.com/76383db4906c9357292846ace77566b34eb47de9/third_party/libtiff/0007-uninitialized-value.patch
[modify] https://crrev.com/76383db4906c9357292846ace77566b34eb47de9/third_party/libtiff/README.pdfium
[modify] https://crrev.com/76383db4906c9357292846ace77566b34eb47de9/third_party/libtiff/tif_dirread.c

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fa26ad94fd19078497d0e5626696b6f041b15b1

commit 0fa26ad94fd19078497d0e5626696b6f041b15b1
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Mon Oct 03 22:39:18 2016

Roll src/third_party/pdfium/ d61f95838..76383db49 (3 commits).

https://pdfium.googlesource.com/pdfium.git/+log/d61f958385be..76383db4906c

$ git log d61f95838..76383db49 --date=short --no-merges --format='%ad %ae %s'
2016-10-03 dsinclair Fix potentially uninitialized value.
2016-10-03 tsepez Rename CFX_WeakPtr::Clear() to DestroyObject()
2016-10-03 dsinclair Guard against double deletion of page views.

BUG= 651632 , 652103 

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2388133003
Cr-Commit-Position: refs/heads/master@{#422572}

[modify] https://crrev.com/0fa26ad94fd19078497d0e5626696b6f041b15b1/DEPS

Project Member

Comment 12 by sheriffbot@chromium.org, Oct 4 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 13 by ClusterFuzz, Oct 4 2016

ClusterFuzz has detected this issue as fixed in range 422546:422646.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5428787238141952

Fuzzer: libfuzzer_pdf_codec_tiff_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  TIFFFetchDirectory
  TIFFReadDirectory
  TIFFClientOpen
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_msan&range=421422:421468
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_msan&range=422546:422646

Minimized Testcase (0.16 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94co4EM3WIeEWlGdYiKPYjeScfljQgSXsydvFAfYzftp_dU-x2WSuZ1hnxFBKKoyrP4ytODkO_HmntrevXry6uzVuQx9vJVBdaUwF7L09YYwzoscnYyoJagtz1KT9oWlLQxwU1_qBy8yxVn6Z0AuT51b9jZug?testcase_id=5428787238141952

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: -M-54 M-55
Labels: Release-0-M55
Project Member

Comment 16 by sheriffbot@chromium.org, Jan 10 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment