Integer-overflow in vpx_highbd_idct4_c |
|||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=6710143586926592 Fuzzer: libfuzzer_media_vpx_video_decoder_fuzzer Job Type: libfuzzer_chrome_ubsan Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: vpx_highbd_idct4_c vpx_highbd_idct4x4_16_add_sse2 inverse_transform_block_intra Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=420478:420535 Minimized Testcase (0.34 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97ma3SDE6obsYvnohtO1ETobguk56pldRxNHVeGpRAJ9PWuWS7kpsjqo8_MUd-QOW1I8rjBQoRCJLpelJkz4i-2WPrD5LrJDAjmViJQHlePPr82IcpSln68xK2qlDFQC5y6_RCwFJmFTo7wcDTfABAtwkI3JA?testcase_id=6710143586926592 Issue manually filed by: mummareddy See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
,
Sep 29 2016
Tom is OOO Angie, this is appearing after your iht change was merged: https://bugs.chromium.org/p/webm/issues/detail?id=1286 Any idea if it is related?
,
Sep 30 2016
This could be a similar issue. vpx_highbd_idct4x4_16_add_sse2 will check if there is an overflow. If there is one, it will call c function. My previous fix doesn't contain this code flow that's why it happens. A similar fix can be done if above description is the case. I will try to fix it ASAP.
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/webm/libvpx/+/5b073c695ba70c87daa1ff843e57ff59f5e3034d commit 5b073c695ba70c87daa1ff843e57ff59f5e3034d Author: Angie Chiang <angiebird@google.com> Date: Fri Sep 30 23:53:20 2016 Move highbd txfm input range check from 2d iht transform to 1d idct/iadst This change will make the highbd txfm input range check more comprehensive The 25-bit highbd input range is composed by 12 signal input bits + 7 bits for 2D forward transform amplification + 5 bits for 1D inverse transform amplification + 1 bit for contingency in rounding and quantizing BUG=https://bugs.chromium.org/p/webm/issues/detail?id=1286 BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=651625 Change-Id: I04c0796edd7653f8d463fba5dc418132986131e7 [modify] https://crrev.com/5b073c695ba70c87daa1ff843e57ff59f5e3034d/vp9/common/vp9_idct.c [modify] https://crrev.com/5b073c695ba70c87daa1ff843e57ff59f5e3034d/vpx_dsp/inv_txfm.c
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7dd5d014381033352b45e84b158b317010520251 commit 7dd5d014381033352b45e84b158b317010520251 Author: johannkoenig <johannkoenig@google.com> Date: Thu Oct 06 03:26:40 2016 Roll src/third_party/libvpx/source/libvpx/ 50b9c467d..897870497 (8 commits). https://chromium.googlesource.com/webm/libvpx.git/+log/50b9c467da77..897870497024 $ git log 50b9c467d..897870497 --date=short --no-merges --format='%ad %ae %s' 2016-09-21 sarahparker Remove rate deviation metric from vp8 2016-10-03 johannkoenig Connect partial IDCT tests 2016-09-30 angiebird Move highbd txfm input range check from 2d iht transform to 1d idct/iadst 2016-10-03 kaustubh.raste Fix vpx_plane_add_noise_msa functionality bit-mismatch 2016-10-03 marpan Update to vpx_temporal_svc_encoder command line. 2016-04-13 gezalore Fix warning when building with GCC 5. 2016-10-01 jzern invalid_file_test: quiet unused const warning 2016-09-30 jzern cosmetics,*_neon.c: rm redundant return from void fns BUG= 651625 Review-Url: https://codereview.chromium.org/2395863002 Cr-Commit-Position: refs/heads/master@{#423420} [modify] https://crrev.com/7dd5d014381033352b45e84b158b317010520251/DEPS [modify] https://crrev.com/7dd5d014381033352b45e84b158b317010520251/third_party/libvpx/README.chromium [modify] https://crrev.com/7dd5d014381033352b45e84b158b317010520251/third_party/libvpx/source/config/vpx_version.h
,
Oct 7 2016
ClusterFuzz has detected this issue as fixed in range 423416:423453. Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6710143586926592 Fuzzer: libfuzzer_media_vpx_video_decoder_fuzzer Job Type: libfuzzer_chrome_ubsan Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: vpx_highbd_idct4_c vpx_highbd_idct4x4_16_add_sse2 inverse_transform_block_intra Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=420478:420535 Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=423416:423453 Minimized Testcase (0.34 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97ma3SDE6obsYvnohtO1ETobguk56pldRxNHVeGpRAJ9PWuWS7kpsjqo8_MUd-QOW1I8rjBQoRCJLpelJkz4i-2WPrD5LrJDAjmViJQHlePPr82IcpSln68xK2qlDFQC5y6_RCwFJmFTo7wcDTfABAtwkI3JA?testcase_id=6710143586926592 See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Oct 7 2016
ClusterFuzz testcase is verified as fixed, closing issue. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Oct 18 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7dd5d014381033352b45e84b158b317010520251 commit 7dd5d014381033352b45e84b158b317010520251 Author: johannkoenig <johannkoenig@google.com> Date: Thu Oct 06 03:26:40 2016 Roll src/third_party/libvpx/source/libvpx/ 50b9c467d..897870497 (8 commits). https://chromium.googlesource.com/webm/libvpx.git/+log/50b9c467da77..897870497024 $ git log 50b9c467d..897870497 --date=short --no-merges --format='%ad %ae %s' 2016-09-21 sarahparker Remove rate deviation metric from vp8 2016-10-03 johannkoenig Connect partial IDCT tests 2016-09-30 angiebird Move highbd txfm input range check from 2d iht transform to 1d idct/iadst 2016-10-03 kaustubh.raste Fix vpx_plane_add_noise_msa functionality bit-mismatch 2016-10-03 marpan Update to vpx_temporal_svc_encoder command line. 2016-04-13 gezalore Fix warning when building with GCC 5. 2016-10-01 jzern invalid_file_test: quiet unused const warning 2016-09-30 jzern cosmetics,*_neon.c: rm redundant return from void fns BUG= 651625 Review-Url: https://codereview.chromium.org/2395863002 Cr-Commit-Position: refs/heads/master@{#423420} [modify] https://crrev.com/7dd5d014381033352b45e84b158b317010520251/DEPS [modify] https://crrev.com/7dd5d014381033352b45e84b158b317010520251/third_party/libvpx/README.chromium [modify] https://crrev.com/7dd5d014381033352b45e84b158b317010520251/third_party/libvpx/source/config/vpx_version.h
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 22 2016
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mummare...@chromium.org
, Sep 29 2016Components: Tools>Test>FindIt>WrongResult
Labels: M-55 Te-Logged
Owner: tomfinegan@chromium.org
Status: Assigned (was: Untriaged)