MD Settings polish: scrollbar visibility affects card positions |
|||
Issue descriptionA common problem on the web, losing or gaining a scrollbar changes the width of the page. This makes centered content jump a small but noticeable distance. In MD Settings, this can be seen: A) Navigating from a main page with a scrollbar to the About page and back B) Navigating from a subpage to a main page, if one has a scrollbar and the other doesn't, some of the time (Somewhat masked by issue 634582 ) We could do some additional javascripty magic, some of which we already have in main_page_behavior.js/settings_main.js, to make the jump less noticeable.
,
Sep 30 2016
o_O
So we should remove stuff that adjusts the cards based on expected scrollbar visibility now, right?
BTW, this seems to create or expose a new bug:
1. resize window to sub-500px width, place on left side of monitor
2. open chrome://md-settings (make sure horiz and vert scrollbars show up)
3. grab the horizontal scrollbar with the mouse
4. drag it to the right
expected: scrolling stops at the edge
actual: you can scroll the page infinitely
> document.querySelector('* /deep/ #mainContainer').scrollLeft
2224.999966844917
> document.querySelector('* /deep/ #mainContainer').scrollWidth
550
Having trouble getting an isolated repro though.
,
Oct 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53c0cd015ae9b8d7cbf77a44aa8fb42f6ef568ec commit 53c0cd015ae9b8d7cbf77a44aa8fb42f6ef568ec Author: michaelpg <michaelpg@chromium.org> Date: Sat Oct 01 02:13:30 2016 MD Settings: Skip unseen collapse animation Don't play the collapse animation when hiding a page, because: 1. The animation isn't visible, so it's extra work for nothing 2. Messing with the container affects the new page Although another CL[1] beat me to it, this would've also fixed the issue we had navigating from a Settings sub-page to the About page, which used to jump 7.5px horizontally after a timeout due to us manipulating the scrollbar for the animation. [1] https://codereview.chromium.org/2379933003/ BUG= 651616 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2378933004 Cr-Commit-Position: refs/heads/master@{#422285} [modify] https://crrev.com/53c0cd015ae9b8d7cbf77a44aa8fb42f6ef568ec/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/53c0cd015ae9b8d7cbf77a44aa8fb42f6ef568ec/chrome/browser/resources/settings/settings_page/settings_section.js
,
Oct 3 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dbeam@chromium.org
, Sep 29 2016Status: Fixed (was: Untriaged)