New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651596 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

noopener feature parsing doesn't follow the spec

Reported by bzbar...@mit.edu, Sep 29 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:52.0) Gecko/20100101 Firefox/52.0

Example URL:

Steps to reproduce the problem:
1. var w = window.open("", "", "noopener=1");
2. alert(w);

What is the expected behavior?
Alerts "[object Window]", per spec.

What went wrong?
Alerts undefined.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? N/A 

Chrome version: 55.0.2873.4 (Official Build) dev (64-bit)  Channel: n/a
OS Version: OS X 10.10
Flash Version: Shockwave Flash 23.0 r0
 
Cc: rnimmagadda@chromium.org
Labels: M-55 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to repro this issue on Windows 7, MAC (10.11.6) & Ubuntu Trusty (14.04) for Google Chrome Stable Version - 53.0.2785.143

This is a Non-Regression issue existing from M30 - # 30.0.1549.0
651596.mov
16.8 MB Download

Comment 2 by mkwst@chromium.org, Sep 30 2016

Yeah. You're right. We're using the generic parsing code here...

I wonder if we should redefine it to match https://drafts.csswg.org/cssom-view/#the-features-argument-to-the-open()-method?

Comment 3 by bzbar...@mit.edu, Sep 30 2016

Heh.  I had to go out of my way in Gecko to implement what the spec says, fwiw...  If that's not what you meant, that's slightly annoying.  :(

The rules at https://drafts.csswg.org/cssom-view/#the-features-argument-to-the-open()-method don't seem to match either the Gecko or the Blink implementation of normal feature parsing (which also don't match each other, fwiw).  That's because they only spec it for the width/height/left/top feature names, which are int-valued, not bool-valued....  This one is clearly bool-valued, kinda (noopener=0 is treated as "true" in Blink, which is not how other bool-valued things work).
Components: -Blink Blink>Bindings

Comment 5 by bzbar...@mit.edu, Oct 20 2016

Actually, there is another difference between what the spec says and what Blink does, and a somewhat more serious one.  Consider this:

 var w = window.open("", "", "NOOPENER");
 alert(w);

per spec this should alert "[object Window]", because the spec says that the specific token that triggers noopener behavior is "noopener".  But Blink seems to be doing some sort of case-insensitive something....
Components: -Blink>Bindings Blink>HTML
Not bindings-related. This is related to how we implement
https://html.spec.whatwg.org/#apis-for-creating-and-navigating-browsing-contexts-by-name

Comment 7 by tkent@chromium.org, Apr 13 2017

Labels: -M-55 Hotlist-Interop
Status: Available (was: Untriaged)
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by tkent@chromium.org, Apr 23 2018

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)

Sign in to add a comment