[Slippy] External display audio is not working after suspend/resume. |
||||||||||||||||||
Issue description
Version:8743.44.0
OS: ChromeOS
What steps will reproduce the problem?
(1) Sign in to the device.
(2) Suspend resume the device.
Close lid and open lid
or
"powerd_dbus_suspend" and press any key.
(3) Connect external monitor with audio support.
What is the expected output?
Audio should come from external display
What do you see instead?
Audio is missing.
UI settings are displaying HDMI audio output.
Please use labels and text to provide additional information.
,
Sep 29 2016
,
Sep 29 2016
Able to reproduce this issue on Falco device.
,
Sep 29 2016
Can we check on a Falco on the prior beta version to see if this is already happening on beta channel (as this is not our first R54)? That should help to give us a bisection point.
,
Sep 30 2016
Able to reproduce this issue on previous beta build M54-8743.35.0
,
Sep 30 2016
,
Sep 30 2016
,
Oct 3 2016
,
Oct 4 2016
,
Oct 4 2016
I'm still doing bisect to find the build went wrong. Findings so far: R54-8570.0.0 fail R54-8554.0.0 ok
,
Oct 5 2016
R54-8554.0.0 was the last good build. The problem is due to CL https://chromium-review.googlesource.com/#/c/358281/ Tried revert the CL and the problem gone. I'll work with cychiang@ for a proper fix. Note that the above CL is cherry-picked to R53 so R53 is also affected I believe.
,
Oct 5 2016
After discussing with cychiang@, we'll revert CL https://chromium-review.googlesource.com/#/c/358281 and create another fix for issue 624819 .
,
Oct 5 2016
The revert CL needs to merge to 54 and 53.
,
Oct 5 2016
Update some summary in case we forget: 1. The max retry was increased for https://code.google.com/p/chrome-os-partner/issues/detail?id=54657 to detect HDMI audio on gpio jack. 2. The report-right-away was added for https://bugs.chromium.org/p/chromium/issues/detail?id=624819 to avoid the issue that the increased timeout causes HDMI audio node to be enumerated after 10 seconds because big (which uses hctl jack does not have ELD info) 3. The report-right-away causes slippy to fail because if CRAS open device too fast after jack is reported, it will succeed to open and play samples to device, but no sound. This seems to be issue in driver. To fix these issues, we will do 1. Revert CL 358281 on R53, R54, ToT. 2. Use different retry for hctl jack (10) and gpio jack (25). 3. Ask intel to help on driver issue.
,
Oct 5 2016
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/c2ae60ca522e7917f7a3e456601a5163e65cbe8b commit c2ae60ca522e7917f7a3e456601a5163e65cbe8b Author: Chinyue Chen <chinyue@chromium.org> Date: Wed Oct 05 08:22:25 2016 Revert "CRAS: alsa_jack: report jack status right away for hctl jack" This reverts commit e8a04ef732f97405d91783ddfd3d64ca50ca16b1. The commit to report jack early does not work well on peppy after suspend/resume. BUG= chromium:651594 TEST=Test on peppy, play music, suspend/resume, plug external display and verify audio is working. Change-Id: I71d817cb2f7fc6e2581f534f4953b33ed635d2ab Reviewed-on: https://chromium-review.googlesource.com/393626 Commit-Ready: Chinyue Chen <chinyue@chromium.org> Tested-by: Chinyue Chen <chinyue@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/c2ae60ca522e7917f7a3e456601a5163e65cbe8b/cras/src/server/cras_alsa_jack.c [modify] https://crrev.com/c2ae60ca522e7917f7a3e456601a5163e65cbe8b/cras/src/tests/alsa_jack_unittest.cc
,
Oct 5 2016
Able to reproduce this issue on M53 build 8530.96.0
,
Oct 5 2016
The narrow case for this issue comes from the fact it start reproducing only from the suspend-while-playback moment. If you just suspend-resume without playback it does not reproduce, unless you did suspend-while-playback before that.
,
Oct 6 2016
If this case this so narrow can we go with stable?
,
Oct 6 2016
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/79bed72ae4fdf421023da47979f9f82296d74d9e commit 79bed72ae4fdf421023da47979f9f82296d74d9e Author: Chinyue Chen <chinyue@chromium.org> Date: Wed Oct 05 08:22:25 2016 Revert "CRAS: alsa_jack: report jack status right away for hctl jack" This reverts commit e8a04ef732f97405d91783ddfd3d64ca50ca16b1. The commit to report jack early does not work well on peppy after suspend/resume. BUG= chromium:651594 TEST=Test on peppy, play music, suspend/resume, plug external display and verify audio is working. Change-Id: I71d817cb2f7fc6e2581f534f4953b33ed635d2ab Reviewed-on: https://chromium-review.googlesource.com/393626 Commit-Ready: Chinyue Chen <chinyue@chromium.org> Tested-by: Chinyue Chen <chinyue@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> (cherry picked from commit c2ae60ca522e7917f7a3e456601a5163e65cbe8b) Reviewed-on: https://chromium-review.googlesource.com/394214 Reviewed-by: Josafat Garcia <josafat@chromium.org> Commit-Queue: Josafat Garcia <josafat@chromium.org> Tested-by: Josafat Garcia <josafat@chromium.org> [modify] https://crrev.com/79bed72ae4fdf421023da47979f9f82296d74d9e/cras/src/server/cras_alsa_jack.c [modify] https://crrev.com/79bed72ae4fdf421023da47979f9f82296d74d9e/cras/src/tests/alsa_jack_unittest.cc
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/79bed72ae4fdf421023da47979f9f82296d74d9e commit 79bed72ae4fdf421023da47979f9f82296d74d9e Author: Chinyue Chen <chinyue@chromium.org> Date: Wed Oct 05 08:22:25 2016 Revert "CRAS: alsa_jack: report jack status right away for hctl jack" This reverts commit e8a04ef732f97405d91783ddfd3d64ca50ca16b1. The commit to report jack early does not work well on peppy after suspend/resume. BUG= chromium:651594 TEST=Test on peppy, play music, suspend/resume, plug external display and verify audio is working. Change-Id: I71d817cb2f7fc6e2581f534f4953b33ed635d2ab Reviewed-on: https://chromium-review.googlesource.com/393626 Commit-Ready: Chinyue Chen <chinyue@chromium.org> Tested-by: Chinyue Chen <chinyue@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> (cherry picked from commit c2ae60ca522e7917f7a3e456601a5163e65cbe8b) Reviewed-on: https://chromium-review.googlesource.com/394214 Reviewed-by: Josafat Garcia <josafat@chromium.org> Commit-Queue: Josafat Garcia <josafat@chromium.org> Tested-by: Josafat Garcia <josafat@chromium.org> [modify] https://crrev.com/79bed72ae4fdf421023da47979f9f82296d74d9e/cras/src/server/cras_alsa_jack.c [modify] https://crrev.com/79bed72ae4fdf421023da47979f9f82296d74d9e/cras/src/tests/alsa_jack_unittest.cc
,
Oct 6 2016
[Automated comment] Reverts referenced in bugdroid comments, after merge request, needs manual review.
,
Oct 6 2016
Re c#19: c#17 confirms this is already on M53 stable.
,
Oct 6 2016
Verified on M54 build 8743.57.0 HDMI audio is working fine after suspend/resume.
,
Oct 9 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 11 2016
,
Oct 11 2016
,
Oct 12 2016
josafat@ The revert CL is not in M53 yet, do we still need to do that?
,
Oct 19 2016
Verified on build 8743.69.0 |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by son...@google.com
, Sep 29 2016