New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651592 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 595826



Sign in to add a comment

Add web-platform-tests for ViewportAPI

Project Member Reported by ymalik@chromium.org, Sep 29 2016

Issue description

This will with standardization of the Viewport API.
https://github.com/WICG/ViewportAPI
 

Comment 1 by ymalik@chromium.org, Nov 14 2016

Cc: -bokan@chromium.org ymalik@chromium.org
Owner: bokan@chromium.org
Components: Blink>Scroll

Comment 3 by bokan@chromium.org, May 18 2017

Labels: OS-All
Status: Started (was: Assigned)

Comment 4 by bokan@chromium.org, Jun 19 2017

Pasting here since I forgot we had this tracking bug:

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/618cba5a11e3b1a65c4968b1f85ef6745fb266ca

commit 618cba5a11e3b1a65c4968b1f85ef6745fb266ca
Author: David Bokan <bokan@chromium.org>
Date: Tue Jun 13 14:38:31 2017

Reland 'Add web platform tests for ViewportAPI.'

This was reverted in Iae9c03e0ee0f625e4e95ccf2f81d1b14d6b64c90 due to
the upstream WPT repo failing the lint check.

This patch fixes the issue which was that two of the tests were using
the Chromium-relative testharness.js path. 

TBR=dtapuska@chromium.org

Bug:  635031 
Change-Id: I5e1277125cabf414a75d8d869f78b8efc9bb3684
Reviewed-on: https://chromium-review.googlesource.com/532593
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479014}
[modify] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/OWNERS
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-dimensions-custom-scrollbars-manual.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-dimensions-scrollbars-manual.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-offset-manual.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-page-manual.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-read-size-causes-layout.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-read-size-in-iframe-causes-layout.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-resize-event-manual.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-scale-iframe-manual.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-scale-manual.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-scroll-event-manual.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-scrollbars-cause-resize.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-type.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-unscaled-scale-iframe.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-unscaled-scale.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-unscaled-scroll-iframe.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-unscaled-scroll.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-unscaled-size-iframe.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-unscaled-size.html
[add] https://crrev.com/618cba5a11e3b1a65c4968b1f85ef6745fb266ca/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport_support.js

Comment 5 by bokan@chromium.org, Jun 19 2017

Status: Fixed (was: Started)
The patch above added an initial suite that should cover most of the API. I've been adding test with bug fixes there as well so I think we can close this out.

Sign in to add a comment