ChooserContentView class name is too generic for //chrome/browser/ui/views/ directory. Need to change its name to be more specific.
Since the class is used by WebUSB and WebBluetooth, how about changing the class name to be: DeviceChooserContentView? Thanks!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/182968f60df837a71d95688a1d152bbd2e1a63d9 commit 182968f60df837a71d95688a1d152bbd2e1a63d9 Author: juncai <juncai@chromium.org> Date: Wed Jan 04 02:24:03 2017 Change ChooserContentView[Cocoa] class name to be DeviceChooserContentView[Cocoa] ChooserContentView[Cocoa] class name is too generic for //chrome/browser/ui/views/ and //chrome/browser/ui/cocoa directories. So change them to DeviceChooserContentView[Cocoa] to be more specific. BUG= 651568 Review-Url: https://codereview.chromium.org/2595083002 Cr-Commit-Position: refs/heads/master@{#441295} [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.h [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/bluetooth/chrome_extension_bluetooth_chooser.h [rename] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.h [rename] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm [rename] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/views/device_chooser_content_view.cc [rename] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/views/device_chooser_content_view.h [rename] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/views/device_chooser_content_view_unittest.cc [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/views/extensions/chooser_dialog_view.cc [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/views/extensions/chooser_dialog_view.h [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/browser/ui/website_settings/chooser_bubble_delegate.h [modify] https://crrev.com/182968f60df837a71d95688a1d152bbd2e1a63d9/chrome/test/BUILD.gn
Comment 1 by juncai@chromium.org
, Oct 3 2016