New issue
Advanced search Search tips

Issue 651557 link

Starred by 1 user
Status: Fixed
Owner:
steve...@chromium.org
Closed: Jun 2018
Cc:
msw@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mustash: Add per-files DEPS in //chrome/browser/ui/ash

Project Member Reported by jamescook@chromium.org, Sep 29 2016 
Under mash the chrome browser process cannot directly access objects in //ash. (For example, there is no ash::Shell or ash::WmShell.)  Code in //c/b/ui/ash will need to be scrubbed of direct ash dependencies. They can continue to depend on //ash/shared.

Enforce this with per-file DEPS. This will give us a TODO list of files we need to fix.

Comment 1 by msw@chromium.org, Oct 4 2016 

I did a quick check of non-public src/ash/* includes in chrome:
 966 //chrome
 951 //chrome/browser
 551 //chrome/browser/ui
 346 //chrome/browser/ui/ash

There are simply too many to make per-file DEPS whitelisting worthwhile at this point.
We should check back periodically as we migrate some offenders to proper mojo interaction.

Comment 2 by jamescook@chromium.org, May 15 2017

Cc: msw@chromium.org sky@chromium.org
Owner: jamescook@chromium.org
I'll take another look at this. Hopefully it's less than 900 includes now.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/934abaf581d475fdec8bde43616b5c5c8f046b87

commit 934abaf581d475fdec8bde43616b5c5c8f046b87
Author: James Cook <jamescook@chromium.org>
Date: Tue Sep 19 22:21:58 2017

cros: Tighten //ash DEPS restrictions in //chrome/browser/ui

For go/mustash code in chrome/brower cannot call directly into ash.

Push the +ash DEPS allowance down into subdirectories that haven't
been converted yet.

Tag a few includes used only in classic ash as "mash-ok".

Remove some unused includes. Convert some USE_ASH to OS_CHROMES to
allow some nogncheck tags to be removed.

Bug:  651557 , 678705
Test: tools/checkdeps.py, gn check, compiles
Change-Id: I1d324c3df319a8099029b926f35b7571ea4d7077
Reviewed-on: https://chromium-review.googlesource.com/673163
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502970}
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/ash/README.md
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/ash/shell.h
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/DEPS
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/app_list/arc/DEPS
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/apps/DEPS
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/ash/DEPS
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/aura/accessibility/DEPS
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/browser.cc
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/browser_commands_chromeos.cc
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/extensions/extension_install_ui_default.cc
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/startup/startup_browser_creator.cc
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/test/DEPS
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/toolbar/DEPS
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/views/DEPS
[modify] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/webui/DEPS
[add] https://crrev.com/934abaf581d475fdec8bde43616b5c5c8f046b87/chrome/browser/ui/window_sizer/DEPS

Comment 4 by jamescook@chromium.org, Apr 19 2018

Components: Internals>Services>Ash
Labels: -Proj-Mustash-Mash

Comment 5 by jamescook@chromium.org, Jun 5 2018

Owner: steve...@chromium.org
Status: Fixed (was: Assigned)
Steven did this, hooray!
►

Sign in to add a comment