New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651556 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

MD History: Ripple appears on items when clicking in margins

Reported by woxxom@gmail.com, Sep 29 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2873.0 Safari/537.36

Steps to reproduce the problem:
Go to History page (Ctrl-H or chrome://history)

PASS 1

Click on empty space and non-clickable spots to the left or right of a) checkbox b) "More actions" three-dot button on various vertical positions of the page.

PASS 2

Click any "More actions" three-dot button, then proceed to pass 1.

What is the expected behavior?
Nothing should happen or appear.
Those areas don't provide any interactivity.

What went wrong?
A "touch spot" indicator appears in a place that's nowhere near the actual click point (when clicking on the opposite side of the content column), moreover the clicked areas don't provide any interactivity and it's meaningless for a desktop app with non-touch input device/display.

Did this work before? Yes before MD

Chrome version: 55.0.2873.0  Channel: dev
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0

Also, when clicking the "more actions" three-dot button there should not be any delay (currently there's a small pause to show the "touch" animation). The menu should be shown immediately, without any distracting game-UI-like animations.
 
Cc: tsergeant@chromium.org calamity@chromium.org
Components: -UI UI>Browser>History
Labels: Proj-MaterialDesign-WebUI
Status: Available (was: Unconfirmed)
Summary: MD History: Ripple appears on items when clicking in margins (was: MD History: erratic behavior of "touch spot" indicator)
Thanks for the feedback.

calamity@: One possible way to fix this is to apply the margins to the entire iron-list at once, rather than making each history-item responsible for its own margins.
Cc: -tsergeant@chromium.org
Owner: tsergeant@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af77c9922af8486fc555b268a0eaeeb8d6055c57

commit af77c9922af8486fc555b268a0eaeeb8d6055c57
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Sep 30 06:28:48 2016

MD History: Move the card sizing CSS to apply to the iron-list

This fixes an issue where it was possible to click on the margins of
the list to select items. These margins are now part of the list itself,
and individual items only occupy the exact horizontal space they need.
This change should have no visual impact on the layout of the list.

BUG= 651556 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2378903004
Cr-Commit-Position: refs/heads/master@{#422043}

[modify] https://crrev.com/af77c9922af8486fc555b268a0eaeeb8d6055c57/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/af77c9922af8486fc555b268a0eaeeb8d6055c57/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/af77c9922af8486fc555b268a0eaeeb8d6055c57/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/af77c9922af8486fc555b268a0eaeeb8d6055c57/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/af77c9922af8486fc555b268a0eaeeb8d6055c57/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/af77c9922af8486fc555b268a0eaeeb8d6055c57/chrome/browser/resources/md_history/lazy_load.vulcanized.html

Status: Fixed (was: Started)
Cc: nyerramilli@chromium.org ranjitkan@chromium.org
 Issue 649243  has been merged into this issue.

Sign in to add a comment