New issue
Advanced search Search tips

Issue 651519 link

Starred by 1 user
Status: Fixed
Owner:
ekaramad@chromium.org
Closed: Nov 2016
Cc:
creis@chromium.org
erikc...@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Word look-up does not work for OOPIF

Project Member Reported by ekaramad@chromium.org, Sep 29 2016 
Version: 55.0.2873.4 (Official Build) canary (64-bit)
OS: Mac OSX
What steps will reproduce the problem?
(1) Make sore --isolate-extensions or --site-per-process are on.
(2) Open an OOPIF or some extension (e.g., hangout extension).
(3) Right click some word and click on "Look up"

What is the expected output?
The dictionary pop-up for the word appears.

What do you see instead?
The dictionary popup will be empty or show some invalid word in the main frame.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f7daa9733a4d5d3c06359b9f92c3bde20c7dd5d

commit 3f7daa9733a4d5d3c06359b9f92c3bde20c7dd5d
Author: ekaramad <ekaramad@chromium.org>
Date: Tue Oct 18 20:14:37 2016

Fix dictionary look-up for highlighted text in Mac.

Currently, TextInputClientMac only taks to the main frames RenderWidgetHost in order to
obtian the string from specific range. This CL fixes this issue by routing the request
to the focused RenderWidgetHost.

BUG= 651519 

Review-Url: https://codereview.chromium.org/2382003002
Cr-Commit-Position: refs/heads/master@{#426030}

[modify] https://crrev.com/3f7daa9733a4d5d3c06359b9f92c3bde20c7dd5d/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
[modify] https://crrev.com/3f7daa9733a4d5d3c06359b9f92c3bde20c7dd5d/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/3f7daa9733a4d5d3c06359b9f92c3bde20c7dd5d/content/public/test/text_input_test_utils.h
[add] https://crrev.com/3f7daa9733a4d5d3c06359b9f92c3bde20c7dd5d/content/public/test/text_input_test_utils_mac.mm
[modify] https://crrev.com/3f7daa9733a4d5d3c06359b9f92c3bde20c7dd5d/content/test/BUILD.gn

Comment 2 by ekaramad@chromium.org, Nov 22 2016 

Marking this bug as fixed since it is no longer reproducible after this patch.

Comment 3 by ekaramad@chromium.org, Nov 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment