New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651513 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 652914



Sign in to add a comment

MD Settings: Migrate from paper-dropdown-menu-light to native select.

Project Member Reported by dpa...@chromium.org, Sep 29 2016

Issue description

A decision has been made to use native select for dropdown menus, instead of paper-dropdown-menu-light. This will address several dropdown related issues all at once.
 

Comment 1 by dpa...@chromium.org, Sep 29 2016

Status: Started (was: Assigned)

Comment 3 by dbeam@chromium.org, Sep 30 2016

Cc: nyerramilli@chromium.org dpa...@chromium.org ranjitkan@chromium.org brajkumar@chromium.org
 Issue 651717  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 5 2016

Blockedon: 652914
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53946c9e8a721709fbf419da6f944a6d40475067

commit 53946c9e8a721709fbf419da6f944a6d40475067
Author: dpapad <dpapad@chromium.org>
Date: Wed Oct 05 23:59:10 2016

MD Settings: Migrate site settings media-picker to native select.

BUG= 651513 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2394963002
Cr-Commit-Position: refs/heads/master@{#423345}

[modify] https://crrev.com/53946c9e8a721709fbf419da6f944a6d40475067/chrome/browser/resources/settings/site_settings/media_picker.html
[modify] https://crrev.com/53946c9e8a721709fbf419da6f944a6d40475067/chrome/browser/resources/settings/site_settings/media_picker.js

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c564dca165c2e50ac104455ac3e2216b81ffe33a

commit c564dca165c2e50ac104455ac3e2216b81ffe33a
Author: dpapad <dpapad@chromium.org>
Date: Thu Oct 06 02:23:56 2016

MD Settings: Migrating site_data_details_dialog to native select.

BUG= 651513 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2395853002
Cr-Commit-Position: refs/heads/master@{#423400}

[modify] https://crrev.com/c564dca165c2e50ac104455ac3e2216b81ffe33a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.html
[modify] https://crrev.com/c564dca165c2e50ac104455ac3e2216b81ffe33a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

Status: Fixed (was: Started)
All non-ChromeOS UI has been migrated. Filed separate bug for ChromeOS https://bugs.chromium.org/p/chromium/issues/detail?id=653689.

Comment 14 by ajha@chromium.org, Oct 7 2016

Cc: steve...@chromium.org
 Issue 651368  has been merged into this issue.
For reference, the (sorry, internal) discussion was on this thread:

https://groups.google.com/a/google.com/forum/#!topic/chrome-settings/RtTs0RbPTwg

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53946c9e8a721709fbf419da6f944a6d40475067

commit 53946c9e8a721709fbf419da6f944a6d40475067
Author: dpapad <dpapad@chromium.org>
Date: Wed Oct 05 23:59:10 2016

MD Settings: Migrate site settings media-picker to native select.

BUG= 651513 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2394963002
Cr-Commit-Position: refs/heads/master@{#423345}

[modify] https://crrev.com/53946c9e8a721709fbf419da6f944a6d40475067/chrome/browser/resources/settings/site_settings/media_picker.html
[modify] https://crrev.com/53946c9e8a721709fbf419da6f944a6d40475067/chrome/browser/resources/settings/site_settings/media_picker.js

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c564dca165c2e50ac104455ac3e2216b81ffe33a

commit c564dca165c2e50ac104455ac3e2216b81ffe33a
Author: dpapad <dpapad@chromium.org>
Date: Thu Oct 06 02:23:56 2016

MD Settings: Migrating site_data_details_dialog to native select.

BUG= 651513 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2395853002
Cr-Commit-Position: refs/heads/master@{#423400}

[modify] https://crrev.com/c564dca165c2e50ac104455ac3e2216b81ffe33a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.html
[modify] https://crrev.com/c564dca165c2e50ac104455ac3e2216b81ffe33a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

Comment 19 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment