Issue 651511 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	wangxianzhu@chromium.org
Closed:	Oct 2016
Cc:	pdr@chromium.org f...@opera.com fmalita@chromium.org chrishtr@chromium.org vmp...@chromium.org
Components:	Blink>Paint Blink>SVG
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug

Blocking:
issue 646176

Handle svg stroke hairline padding in GeometryMapper/PaintPropertyTree

Project Member Reported by wangxianzhu@chromium.org, Sep 29 2016

Issue description

We apply svg stroke hairline padding in SVGLayoutSupport::transformPaintInvalidationRect(), but we don't have counterpart representation of the operation in paint property tree, so GeometryMapper don't know how to apply it when mapping a rect.

This is like  bug 648769  (about pixel-snapping for scale transform) and  bug 648274  (paint property/mapping of multicol contents): GeometryMapper doesn't get enough information from the paint property tree to handle the these extra geometry effects.

Comment 1 by wangxianzhu@chromium.org, Oct 11 2016

Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a

commit e0679d9453c26e2c2c1de1d3bfefadc7f83a364a
Author: chrishtr <chrishtr@chromium.org>
Date: Mon Oct 24 19:48:04 2016

Introduce Layout*::adjustVisualRectForRasterEffects and use it for SVG hairlines.

BUG= 651511 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
NOTRY=true (added after it passed on all CQ bots except android which failed because of Java heap error)

Review-Url: https://codereview.chromium.org/2444593002
Cr-Commit-Position: refs/heads/master@{#427125}

[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/absolute-sized-document-no-scrollbars-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/deep-dynamic-updates-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/hairline-stroke-squarecap-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-creation-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-repaint-rect-on-path-with-stroke-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-bounce-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-container-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-polygon-changes-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-polygon-removal-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-style-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-transform-addition-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-transform-changes-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-child-changes-css-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-child-changes-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-strokeWidth-changes-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-viewBox-changes-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/paintorder-filtered-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/path-pathlength-change-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-document-scrollbars-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/repaint-paintorder-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/repaint-stroke-width-changes-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/paint/invalidation/svg/stroke-opacity-update-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/hit-test-with-br-expected.png
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/js-late-clipPath-creation-expected.png
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/tabgroup-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/use-detach-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/use-setAttribute-crash-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-document-scrollbars-expected.png
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/relative-sized-document-scrollbars-text-zoom-expected.png
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/window-expected.txt
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp
[modify] https://crrev.com/e0679d9453c26e2c2c1de1d3bfefadc7f83a364a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0

commit 6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Oct 24 22:12:23 2016

Auto-rebaseline for r427125

https://chromium.googlesource.com/chromium/src/+/e0679d945

BUG= 651511 
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/2448683002 .

Cr-Commit-Position: refs/heads/master@{#427169}

[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/paint/invalidation/svg/use-setAttribute-crash-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/as-image/image-preserveAspectRatio-all-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/carto.net/combobox-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/carto.net/scrollbar-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/carto.net/selectionlist-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/custom/use-forward-refs-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/filters/feImage-preserveAspectRatio-all-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/filters/subRegion-one-effect-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/transforms/text-with-pattern-with-svg-transform-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[add] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/android/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/as-image/img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/batik/filters/feTile-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/smallFonts-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPath-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPathSpaces-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/verticalText-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/verticalTextOnPath-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/carto.net/scrollbar-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/custom/path-textPath-simulation-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/text-with-pattern-with-svg-transform-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/tabgroup-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/use-detach-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/window-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/batik/filters/feTile-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/smallFonts-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textOnPath-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textOnPathSpaces-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/verticalText-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/verticalTextOnPath-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/carto.net/combobox-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/carto.net/scrollbar-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/carto.net/selectionlist-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/custom/path-textPath-simulation-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/tabgroup-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/use-detach-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/as-image/img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/batik/filters/feTile-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/smallFonts-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textOnPath-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textOnPathSpaces-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/verticalText-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/verticalTextOnPath-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/carto.net/combobox-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/carto.net/scrollbar-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/carto.net/selectionlist-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/custom/path-textPath-simulation-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/svg/as-image/image-preserveAspectRatio-all-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/svg/custom/use-forward-refs-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/svg/filters/feImage-preserveAspectRatio-all-expected.txt
[modify] https://crrev.com/6fa2f2103f91a5a4036ff35fc9608e0a2e00e7a0/third_party/WebKit/LayoutTests/svg/filters/subRegion-one-effect-expected.txt

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76

commit aa1bdf407523a1ce8429e62f1cf2063aa29f8e76
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Oct 28 23:34:01 2016

[SPInvalidation] Call LayoutObject::adjustVisualRectForRasterEffects from PaintInvalidator

This fixes SVG hairline padding issue of SPInvalidation.

Also rebaselined SVG tests we do more accurate pixel snapping for SVGRoot
instead of enclosingIntRect() on SVGRoot during rect mapping.

BUG= 651511 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2455703003
Cr-Commit-Position: refs/heads/master@{#428546}

[modify] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=SlimmingPaintInvalidation
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/absolute-sized-document-no-scrollbars-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/deep-dynamic-updates-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-marker-creation-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-bounce-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-container-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-polygon-changes-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-polygon-removal-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-transform-addition-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-transform-changes-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/paintorder-filtered-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/repaint-paintorder-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/stroke-opacity-update-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/tabgroup-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/use-detach-expected.txt
[add] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/window-expected.txt
[modify] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-transform-addition-expected.txt
[modify] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-transform-changes-expected.txt
[modify] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
[modify] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h
[modify] https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Comment 5 by wangxianzhu@chromium.org, Oct 29 2016

Status: Fixed (was: Assigned)

►

Issue 651511 link

Issue metadata

Handle svg stroke hairline padding in GeometryMapper/PaintPropertyTree

Issue description

Comment 1 by wangxianzhu@chromium.org, Oct 11 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Oct 24 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Oct 24 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Oct 28 2016

Comment 4 Deleted

Comment 5 by wangxianzhu@chromium.org, Oct 29 2016

Comment 5 Deleted

Sign in to add a comment