performance.getEntriesByType() should be case-sensitive |
|||
Issue descriptionVersion: 53.0.2785.116 (64-bit) OS: OSX What steps will reproduce the problem? (1) Run tests: https://github.com/w3c/web-platform-tests/commit/f287d5333e1233086a1b1d803915e4402ccb0f28 What is the expected output? getEntriesByType should be case-sensitive, same as getEntriesByName. Related discussion and compat data in: https://github.com/w3c/performance-timeline/issues/57#issuecomment-250537676
,
Oct 3 2016
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c0ff2498f7fbead1b5de0b70d22d4546aecbdfa commit 9c0ff2498f7fbead1b5de0b70d22d4546aecbdfa Author: dsinclair <dsinclair@chromium.org> Date: Tue Oct 04 01:09:14 2016 Make PerformanceEntry::toEntryTypeEnum case sensitive. The performance timing spec has been clarified[1] to make getEntriesByType case sensitive. This CL updates Blink to this new requirement. [1] https://github.com/w3c/performance-timeline/issues/57 BUG= 651507 Review-Url: https://codereview.chromium.org/2390733003 Cr-Commit-Position: refs/heads/master@{#422650} [modify] https://crrev.com/9c0ff2498f7fbead1b5de0b70d22d4546aecbdfa/third_party/WebKit/Source/core/timing/PerformanceEntry.cpp
,
Oct 4 2016
The fix has landed but not the test. Currently the test for the getEntriesByName does upper/lower case on the host name. When running the layout tests the host name is 127.0.0.1, so the test fails to execute successfully. (Running it locally and accessing through chrome does work correctly). I wasn't sure if the test could easily be changed to upper/lower case the path as opposed to the hostname so I didn't make the change. igrigorik@, can you update the test so it works with 127.0.0.1? If not, we'll need to look into making the layout tests use localhost instead of 127.0.0.1.
,
Oct 4 2016
> I wasn't sure if the test could easily be changed to upper/lower case the path as opposed to the hostname so I didn't make the change. Yes, path is case sensitive.
,
Oct 4 2016
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e47ceb37e280a3c2e04a66eb48d41251b6ae56e2 commit e47ceb37e280a3c2e04a66eb48d41251b6ae56e2 Author: dsinclair <dsinclair@chromium.org> Date: Tue Oct 04 19:12:21 2016 Add test for getEntriesByType and getEntriesByName. This Cl adds the test case for the case sensitivity of getEntriesByType and getEntriesByName. BUG= chromium:651507 Review-Url: https://codereview.chromium.org/2393633002 Cr-Commit-Position: refs/heads/master@{#422880} [add] https://crrev.com/e47ceb37e280a3c2e04a66eb48d41251b6ae56e2/third_party/WebKit/LayoutTests/http/tests/misc/get-entries-case-sensitivities.html |
|||
►
Sign in to add a comment |
|||
Comment 1 by esprehn@chromium.org
, Sep 30 2016Status: Assigned (was: Available)