Update number of HW decoder resets in RTCVideoEncoder before SW fallback |
|||||
Issue descriptionEarlier on, I added dynamic error tracking for the special issue explained on issue 594161 . We tried to reset HW decoder to handle H264 errors since SW fallback wasn't available. Since SW H264 is available now, this issue is no longer applicable. We should have less tolerance for error and fall back to SW quicker, so that the delay is minimal.
,
Sep 30 2016
,
Sep 30 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 30 2016
Could you please confirm whether this change is baked/verified in Canary and safe to merge? If yes, please merge to M54 (2840 Branch) ASAP.
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c74f8d451f38287bb1558e6b6ab88356c1843e0b commit c74f8d451f38287bb1558e6b6ab88356c1843e0b Author: emircan <emircan@chromium.org> Date: Fri Sep 30 23:03:06 2016 Update threshold for RTCVideoEncoder SW fallback Earlier on, I added dynamic error tracking for the special issue explained on crbug.com/594161 . We tried to reset HW decoder to handle H264 errors since SW fallback wasn't available. Since SW H264 is available now, this issue is no longer applicable. We should have less tolerance for error and fall back to SW. BUG= 651489 , webrtc:6377 TEST=Tested AppRTC loopback H264 decode on Mac. Review-Url: https://codereview.chromium.org/2375153003 Cr-Commit-Position: refs/heads/master@{#421847} (cherry picked from commit ed96795836993e079ff0de7cae4ef242894d4057) NOTRY=true NOPRESUBMIT=true TBR=wuchengli@chromium.org Review-Url: https://codereview.chromium.org/2383923002 Cr-Commit-Position: refs/branch-heads/2840@{#611} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/c74f8d451f38287bb1558e6b6ab88356c1843e0b/content/renderer/media/gpu/rtc_video_decoder.cc
,
Oct 1 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c74f8d451f38287bb1558e6b6ab88356c1843e0b commit c74f8d451f38287bb1558e6b6ab88356c1843e0b Author: emircan <emircan@chromium.org> Date: Fri Sep 30 23:03:06 2016 Update threshold for RTCVideoEncoder SW fallback Earlier on, I added dynamic error tracking for the special issue explained on crbug.com/594161 . We tried to reset HW decoder to handle H264 errors since SW fallback wasn't available. Since SW H264 is available now, this issue is no longer applicable. We should have less tolerance for error and fall back to SW. BUG= 651489 , webrtc:6377 TEST=Tested AppRTC loopback H264 decode on Mac. Review-Url: https://codereview.chromium.org/2375153003 Cr-Commit-Position: refs/heads/master@{#421847} (cherry picked from commit ed96795836993e079ff0de7cae4ef242894d4057) NOTRY=true NOPRESUBMIT=true TBR=wuchengli@chromium.org Review-Url: https://codereview.chromium.org/2383923002 Cr-Commit-Position: refs/branch-heads/2840@{#611} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/c74f8d451f38287bb1558e6b6ab88356c1843e0b/content/renderer/media/gpu/rtc_video_decoder.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 29 2016