New issue
Advanced search Search tips

Issue 651449 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Maximized window's non-client area becomes visible after attaching/detaching additional monitor

Reported by atimo...@yandex-team.ru, Sep 29 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0

Steps to reproduce the problem:
1. Open browser window in maximized mode
2. Attach additional monitor (or detach already attached monitor)

What is the expected behavior?
Window stays in maximized mode and only it's client area is visible on screen (as before attaching additional monitor).

Window bounds before attaching monitor and after attaching monitor is same.

What went wrong?
Window stays in maximized mode, but it's bounds is wrong and isn't correspond to bounds before attaching additional monitor. This leads to window's non-client area becomes visible (see wrong-maximized.png), but it isn't work as normal non-client area (you can't resize window by dragging it, however cursor changes on hover).

I collect (using Spy++) window properties before and after attaching monitor: see normal-maximized-properties.png and wrong-maximized-properties.png

It looks like a window manager bug and i think we should apply some workaround to fix window position in this case.

Did this work before? No 

Chrome version: 55.0.2875.0 (64 bit) canary  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0
 
wrong-maximized.png
133 KB View Download
normal-maximized-properties.png
24.8 KB View Download
wrong-maximized-properties.png
24.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bb7f81927671c8616a89ad235d797159724cf09

commit 6bb7f81927671c8616a89ad235d797159724cf09
Author: atimoxin <atimoxin@yandex-team.ru>
Date: Mon Oct 10 09:39:46 2016

Restore maximized window position after detaching display.

Sometimes Windows incorrectly changes bounds of maximized windows after
attaching or detaching additional displays. In this case user can see
non-client area of the window (that should be hidden in normal case).

This workaround code restores window position if problem occurs.

BUG= 651449 

Review-Url: https://codereview.chromium.org/2379063003
Cr-Commit-Position: refs/heads/master@{#424123}

[modify] https://crrev.com/6bb7f81927671c8616a89ad235d797159724cf09/ui/views/win/hwnd_message_handler.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4e3503b4006f36939543c91a45c1c9feb9f1433

commit f4e3503b4006f36939543c91a45c1c9feb9f1433
Author: sky <sky@chromium.org>
Date: Mon Nov 07 19:06:09 2016

Revert of Restore maximized window position after detaching display. (patchset #2 id:20001 of https://codereview.chromium.org/2379063003/ )

Reason for revert:
This resulted in a shortcut to move between monitors not working. See 656001.

Original issue's description:
> Restore maximized window position after detaching display.
>
> Sometimes Windows incorrectly changes bounds of maximized windows after
> attaching or detaching additional displays. In this case user can see
> non-client area of the window (that should be hidden in normal case).
>
> This workaround code restores window position if problem occurs.
>
> BUG= 651449 
>
> Committed: https://crrev.com/6bb7f81927671c8616a89ad235d797159724cf09
> Cr-Commit-Position: refs/heads/master@{#424123}

TBR=ananta@chromium.org,atimoxin@yandex-team.ru
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 651449 

Review-Url: https://codereview.chromium.org/2484643003
Cr-Commit-Position: refs/heads/master@{#430336}

[modify] https://crrev.com/f4e3503b4006f36939543c91a45c1c9feb9f1433/ui/views/win/hwnd_message_handler.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/306338a1ac90527e74f9604cd5b202d1cdf2cb63

commit 306338a1ac90527e74f9604cd5b202d1cdf2cb63
Author: atimoxin <atimoxin@yandex-team.ru>
Date: Tue Nov 15 10:02:57 2016

Restore maximized window position after detaching display.

Sometimes Windows incorrectly changes bounds of maximized windows after
attaching or detaching additional displays. In this case user can see
non-client area of the window (that should be hidden in normal case).

This workaround code restores window position if problem occurs and also
fixes problem with broken shortcuts for changing monitor (Win+Shift+Left
or Win+Shift+Right) for maximized and fullscreen mode, caused by
incorrect same monitor detection logic in OnWindowPosChanging() (see
 crbug.com/656001 ).

BUG= 651449 , 656001 

Review-Url: https://codereview.chromium.org/2488993002
Cr-Commit-Position: refs/heads/master@{#432156}

[modify] https://crrev.com/306338a1ac90527e74f9604cd5b202d1cdf2cb63/ui/views/win/hwnd_message_handler.cc

Project Member

Comment 4 by sheriffbot@chromium.org, Nov 15 2017

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment