New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651445 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Telemetry benchmark disabling mechanism is broken

Project Member Reported by nedngu...@google.com, Sep 29 2016

Issue description

From Juan:

"$ tools/perf/run_benchmark smoothness.tough_pinch_zoom_cases --browser
android-chrome

causes the benchmark to run, even if it is disabled for all in https://chromium.googlesource.com/chromium/src/+/master/tools/perf/benchmarks/smoothness.py#285"


Kari: since you last touch disabling logic, can you look into this?
 
Cc: aiolos@chromium.org
Owner: eyaich@chromium.org
Actually this is a bug that has existed for a very long time. Emily has a fix.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/990b6e2221f393d7ee2e3e0ea98427ac4613f8c5

commit 990b6e2221f393d7ee2e3e0ea98427ac4613f8c5
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Sep 29 20:50:04 2016

Roll src/third_party/catapult/ b4b1df17d..52bbc5d5f (6 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b4b1df17dd98..52bbc5d5f1fd

$ git log b4b1df17d..52bbc5d5f --date=short --no-merges --format='%ad %ae %s'
2016-09-29 alexandermont Output empty after_load:power histogram if no loading events.
2016-09-29 jbudorick [devil] Handle symlinks in PushChangedFiles.
2016-09-29 jbudorick [devil] Only initialize logging once.
2016-09-29 skyostil adb_profile_chrome: Fix a command line verification bug
2016-09-29 eyaich Fixing bug for page test results calling FormatDisabled
2016-09-29 eyaich Updating story runner to check decorator disabled state

BUG= 651445 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2379573005
Cr-Commit-Position: refs/heads/master@{#421928}

[modify] https://crrev.com/990b6e2221f393d7ee2e3e0ea98427ac4613f8c5/DEPS

Project Member

Comment 3 by sheriffbot@chromium.org, Sep 30 2016

Labels: Hotlist-Google
Status: Fixed (was: Assigned)

Sign in to add a comment