New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651431 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 638807



Sign in to add a comment

Media controls pop up menu should hide when clicking/tapping somewhere

Project Member Reported by mlamouri@chromium.org, Sep 29 2016

Issue description

At the moment, we keep it visible until the user select something from the menu. We should hide it more aggressively.
 
There is a way to add event listener to the Window object.

* If the user click on media controls, the controls will receive the click event first, and the Window receives it afterwards.
* If the user click on elsewhere, the Window will receive a click event.

However, this solution does not work across iframes.
Do you mean that the iframe will not hide the menu if you click in the top frame? Can you fix this if you handle the click event on the top of the frame tree?
Hmm, how could we do that?
The security issue related to this should be moderate, but when OOPIFs are enabled, it might be harder to listen to events from the top-level frame in a different process.
AFAIK they are enabling OOPIFs on M55 by default already.
For OOPIF, we can just go to the top of the local frame tree.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2569ec9714c71a31f0135f55913a5e40c493e161

commit 2569ec9714c71a31f0135f55913a5e40c493e161
Author: zqzhang <zqzhang@chromium.org>
Date: Tue Oct 04 11:20:27 2016

Hide overflow menu/closed caption list when clicking outside the list

BUG= 651431 

Review-Url: https://codereview.chromium.org/2382233002
Cr-Commit-Position: refs/heads/master@{#422752}

[modify] https://crrev.com/2569ec9714c71a31f0135f55913a5e40c493e161/third_party/WebKit/LayoutTests/media/media-controls.js
[add] https://crrev.com/2569ec9714c71a31f0135f55913a5e40c493e161/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-closed-captions-list-hide-on-click-outside.html
[add] https://crrev.com/2569ec9714c71a31f0135f55913a5e40c493e161/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-outside.html
[modify] https://crrev.com/2569ec9714c71a31f0135f55913a5e40c493e161/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/2569ec9714c71a31f0135f55913a5e40c493e161/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp
[modify] https://crrev.com/2569ec9714c71a31f0135f55913a5e40c493e161/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h
[modify] https://crrev.com/2569ec9714c71a31f0135f55913a5e40c493e161/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/2569ec9714c71a31f0135f55913a5e40c493e161/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/2569ec9714c71a31f0135f55913a5e40c493e161/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[add] https://crrev.com/2569ec9714c71a31f0135f55913a5e40c493e161/third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.cpp
[add] https://crrev.com/2569ec9714c71a31f0135f55913a5e40c493e161/third_party/WebKit/Source/core/html/shadow/MediaControlsWindowEventListener.h

Status: Fixed (was: Assigned)

Sign in to add a comment