Issue 651428 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	mlamouri@chromium.org
Closed:	Oct 2016
Cc:	█ rachelis@chromium.org █ k...@chromium.org
Components:	Blink>Media>Controls
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug
M-55

Blocking:
issue 638807

Don't show cast icon overlay if there is an overflow menu

Project Member Reported by mlamouri@chromium.org, Sep 29 2016

Issue description

In other words, we should no longer show it if we use default controls.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/198b03fa63070f44131733e799ab8e5494bfd687

commit 198b03fa63070f44131733e799ab8e5494bfd687
Author: mlamouri <mlamouri@chromium.org>
Date: Sat Oct 01 14:15:22 2016

Don't use cast overlay when using default controls.

It's now in the overflow menu.

BUG= 651428 

Review-Url: https://codereview.chromium.org/2378933005
Cr-Commit-Position: refs/heads/master@{#422315}

[modify] https://crrev.com/198b03fa63070f44131733e799ab8e5494bfd687/third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html
[modify] https://crrev.com/198b03fa63070f44131733e799ab8e5494bfd687/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Comment 2 by mlamouri@chromium.org, Oct 1 2016

Status: Fixed (was: Started)

►

Issue 651428 link

Issue metadata

Don't show cast icon overlay if there is an overflow menu

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 1 2016

Comment 1 Deleted

Comment 2 by mlamouri@chromium.org, Oct 1 2016

Comment 2 Deleted

Sign in to add a comment