Issue metadata
Sign in to add a comment
|
4.4% regression in webrtc_perf_tests at 14367:14368 |
||||||||||||||||||||
Issue descriptionSee graph below.
,
Sep 29 2016
Can you please have a look whether https://codereview.webrtc.org/2355503002/ is the cause for this change and verify if it is expected.
,
Sep 29 2016
Taking a look at it. This test heavily tests an "unloaded" NetEq path (i.e. no time is spent decoding, just passing silent PCM frames through NetEq) so even small changes can cause changes to that performance graph. It's previously been the case that making DecoderDatabase::IsComfortNoise less efficient causes perf regressions, just because it's hit several times for each packet called. It's quite possible that this change does make IsComfortNoise (and similar checkers like IsRed and IsDtmf) slightly slower.
,
Sep 30 2016
I've created a CL at https://codereview.webrtc.org/2383723002/ that reduces the time to check whether a payload type is CN, RED or DTMF by mapping that before-hand. I'm still leaving it a bit open for now. It might be better addressed once we're done with the current remodeling.
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/9f38c218ee0282042e5bc31d3d3a1b1f53e4be16 commit 9f38c218ee0282042e5bc31d3d3a1b1f53e4be16 Author: ossu <ossu@webrtc.org> Date: Tue Oct 04 12:23:32 2016 Cache the subtype of each DecoderInfo to make the Is* checks quicker. Addresses a regression in the NetEq performance test. # Added NOTRY due to android_arm64_rel being swamped. NOTRY=True BUG= chromium:651426 Review-Url: https://codereview.webrtc.org/2383723002 Cr-Commit-Position: refs/heads/master@{#14495} [modify] https://crrev.com/9f38c218ee0282042e5bc31d3d3a1b1f53e4be16/webrtc/modules/audio_coding/neteq/decoder_database.cc [modify] https://crrev.com/9f38c218ee0282042e5bc31d3d3a1b1f53e4be16/webrtc/modules/audio_coding/neteq/decoder_database.h
,
Oct 5 2016
Looking at the graph since 14495 landed, it looks like we're now back to the same baseline as before. Setting this as fixed.
,
Oct 6 2016
,
Oct 19 2016
The CL in #5 landed in M55, so updating the milestone accordingly. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by asapersson@chromium.org
, Sep 29 2016