New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651426 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.4% regression in webrtc_perf_tests at 14367:14368

Project Member Reported by asapersson@chromium.org, Sep 29 2016

Issue description

See graph below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=651426

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgpa6YoQkM


Bot(s) for this bug's original alert(s):

webrtc-mac-large-tests
Labels: -M-53 M-54
Owner: ossu@chromium.org
Can you please have a look whether https://codereview.webrtc.org/2355503002/ 
is the cause for this change and verify if it is expected. 

Comment 3 by ossu@chromium.org, Sep 29 2016

Taking a look at it. This test heavily tests an "unloaded" NetEq path (i.e. no time is spent decoding, just passing silent PCM frames through NetEq) so even small changes can cause changes to that performance graph. It's previously been the case that making DecoderDatabase::IsComfortNoise less efficient causes perf regressions, just because it's hit several times for each packet called. It's quite possible that this change does make IsComfortNoise (and similar checkers like IsRed and IsDtmf) slightly slower.

Comment 4 by ossu@chromium.org, Sep 30 2016

I've created a CL at https://codereview.webrtc.org/2383723002/ that reduces the time to check whether a payload type is CN, RED or DTMF by mapping that before-hand. I'm still leaving it a bit open for now. It might be better addressed once we're done with the current remodeling.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/9f38c218ee0282042e5bc31d3d3a1b1f53e4be16

commit 9f38c218ee0282042e5bc31d3d3a1b1f53e4be16
Author: ossu <ossu@webrtc.org>
Date: Tue Oct 04 12:23:32 2016

Cache the subtype of each DecoderInfo to make the Is* checks quicker.

Addresses a regression in the NetEq performance test.

# Added NOTRY due to android_arm64_rel being swamped.
NOTRY=True
BUG= chromium:651426 

Review-Url: https://codereview.webrtc.org/2383723002
Cr-Commit-Position: refs/heads/master@{#14495}

[modify] https://crrev.com/9f38c218ee0282042e5bc31d3d3a1b1f53e4be16/webrtc/modules/audio_coding/neteq/decoder_database.cc
[modify] https://crrev.com/9f38c218ee0282042e5bc31d3d3a1b1f53e4be16/webrtc/modules/audio_coding/neteq/decoder_database.h

Comment 6 by ossu@chromium.org, Oct 5 2016

Status: Fixed (was: Assigned)
Looking at the graph since 14495 landed, it looks like we're now back to the same baseline as before. Setting this as fixed.
Cc: danilchap@chromium.org ossu@chromium.org
 Issue 653136  has been merged into this issue.
Labels: -M-54 M-55
The CL in #5 landed in M55, so updating the milestone accordingly.

Sign in to add a comment