New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651425 link

Starred by 3 users
Status: Assigned
Owner:
igorcov@chromium.org
Cc:
mnissler@chromium.org
█ dkalin@chromium.org
█ binzhao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Refactoring: Pull machine_id and machine_model out of DevicePolicyClient.

Project Member Reported by tnagel@chromium.org, Sep 29 2016 
https://codereview.chromium.org/2371213002/#msg13

Mattias:
"Since device policy is the only case where machine id and machine model are
supposed to be configured, it seems a bit backwards to use CloudPolicyClient as
the vehicle to carry them around now.

Maybe a cleaner approach would be to just remove them from the constructor of
CloudPolicyClient and pass them to CloudPolicyClient::Register() as parameters?
I think that would clear up the data flow. While you're doing this, you probably
also want to get rid of the submit_machine_id_ thing (this was put in to recover
devices in the field from an earlier bug, but is no longer needed AFAIK)."

Comment 1 by tnagel@chromium.org, Sep 29 2016

Cc: binzhao@chromium.org
Bin, valid_serial_number_missing was introduced to PolicyData end of 2011.  (Apparently it was used to backfill serial numbers that were not transmitted during registration.)  Is it still in active use or can it be deprecated?

Note to self: This would also allow to delete the logic in login_manager/DevicePolicyService which causes the serial number to be exposed in the first place.

Comment 2 by tnagel@chromium.org, Oct 12 2016

Cc: dkalin@chromium.org
Dennis, do you know whether valid_serial_number_missing is still in active use?

Comment 3 by tnagel@chromium.org, Feb 28 2017

Components: -Enterprise

Comment 4 by tnagel@chromium.org, Jul 26 2017

Owner: igorcov@chromium.org
►

Sign in to add a comment