Update media controls pop up menu style |
|||||
Issue descriptionIt should be a bit lower, has round corner and a box shadow.
,
Oct 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62fa917d17ee2358ab4c9c747318eafa897400e7 commit 62fa917d17ee2358ab4c9c747318eafa897400e7 Author: mlamouri <mlamouri@chromium.org> Date: Sat Oct 01 15:33:05 2016 Update style of media controls popup. This is: - changing the position of the popup. - adding round corner. - adding a shadow. It applies to both the overflow and CC menu. BUG= 651417 Review-Url: https://codereview.chromium.org/2376633003 Cr-Commit-Position: refs/heads/master@{#422319} [modify] https://crrev.com/62fa917d17ee2358ab4c9c747318eafa897400e7/third_party/WebKit/Source/core/css/mediaControlsNew.css
,
Oct 1 2016
,
Oct 1 2016
Closing this but there might be some polish required. The CL that has landed should be closer to the spec but the details might not be respected. Though at that point it should be about changing the value of a colour or the intensity of the shadow, probably no major changes that can't be sherry-picked.
,
Oct 3 2016
Just for posterity, specs from bettes@ if you need them: - corner radius = 2dp - shadow is "--shadow-elevation-8dp" on this page https://github.com/PolymerElements/paper-styles/blob/master/shadow.html (or visual version here: https://elements.polymer-project.org/elements/paper-styles?view=demo:demo/index.html&active=paper-styles)
,
Oct 5 2016
Thanks Mounir! I've attached a screenshot of how this currently looks. Polish details I see: - 2dp corners (this is bigger) - shadow adjustments (see above comment) - we should add the material touch animation on tap It sounds like you're testing out these adjustments now.
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05be21172a2fde5ddf35f36d1932d8f3f94f6695 commit 05be21172a2fde5ddf35f36d1932d8f3f94f6695 Author: mlamouri <mlamouri@chromium.org> Date: Wed Oct 05 16:49:35 2016 Polish overflow menu style. Changes the border-radius and box-shadow style. BUG= 651417 R=foolip@chromium.org Review-Url: https://codereview.chromium.org/2393133003 Cr-Commit-Position: refs/heads/master@{#423187} [modify] https://crrev.com/05be21172a2fde5ddf35f36d1932d8f3f94f6695/third_party/WebKit/Source/core/css/mediaControlsNew.css
,
Oct 5 2016
"- we should add the material touch animation on tap" We currently don't use the material touch animation for the controls. We should probably file this as a future improvement.
,
Oct 5 2016
Hey mounir@ - rachelis@ and I were talking a bit about the shadow. It's not a deal-breaker but it seems a bit tighter than the current omnibox shadow. rachelis@ tells me you had to take the polymer script and translate to CSS. What did you end up on? I could fiddle with it to get it where it feels better. Or if you have ideas feel free to fiddle too! I'd try doubling the size of what you have now, which is the totally ambiguous designer feedback that the mass populace of users won't really care about, but a detail we feel obligated to sweat to ensure our job security. Attaching a comparison image for reference.
,
Oct 6 2016
I'm going to apply your suggestion and send a screenshot. A few comments/clarifications though: - the media controls are implemented in Blink and use CSS for the styling (contrary to the menu you show that is probably implemented in Java) - this feature is desktop/mobile and at the moment we use the same style (maybe we shouldn't?) - the shadow seems consistent with the omnibox icon shadow on desktop - I'm afraid that having something bigger will make the overflow menu over power the video -- but we will see :)
,
Oct 6 2016
I made the border radius smaller and the box-shadow bigger.
It changed from:
border-radius: 2px;
box-shadow: 0 8px 10px 1px rgba(0, 0, 0, 0.14),
0 3px 14px 2px rgba(0, 0, 0, 0.12),
0 5px 5px -3px rgba(0, 0, 0, 0.4);
to:
border-radius: 1px;
box-shadow: 0 8px 20px 1px rgba(0, 0, 0, 0.14),
0 3px 28px 2px rgba(0, 0, 0, 0.12),
0 5px 10px -3px rgba(0, 0, 0, 0.4);
,
Oct 6 2016
Looks good to me - thanks! rachelis@ - will let you have final say though.
,
Oct 6 2016
Looks great! Thanks!
,
Oct 7 2016
Rachel, do you want me to land this change?
,
Oct 7 2016
Yes, please do.
,
Oct 10 2016
It has landed on trunk. It should be merged in Chrome Beta.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05be21172a2fde5ddf35f36d1932d8f3f94f6695 commit 05be21172a2fde5ddf35f36d1932d8f3f94f6695 Author: mlamouri <mlamouri@chromium.org> Date: Wed Oct 05 16:49:35 2016 Polish overflow menu style. Changes the border-radius and box-shadow style. BUG= 651417 R=foolip@chromium.org Review-Url: https://codereview.chromium.org/2393133003 Cr-Commit-Position: refs/heads/master@{#423187} [modify] https://crrev.com/05be21172a2fde5ddf35f36d1932d8f3f94f6695/third_party/WebKit/Source/core/css/mediaControlsNew.css
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rolfe@chromium.org
, Sep 30 2016