Evaluate and if possible replace the FakeSyncServer with the LoopbackServer.
The LoopbackServer impl is based on the FakeServer impl and can technically do at least as much as it. The part that is missing is a way to inspect and modify and verify the server state which is needed for tests but not for production code.
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/092f21a0129935b175abf418e957e3b644bc23d3
commit 092f21a0129935b175abf418e957e3b644bc23d3
Author: pastarmovj <pastarmovj@chromium.org>
Date: Wed May 31 09:52:11 2017
[sync] Pull the Sieve implementation from FakeServer to LoopbackServer.
This is a clone of https://codereview.chromium.org/2564663003 in
preparation for replacing the FakeServer impl with the LoopbackServer.
It should also improve the loopack server main purpose.
Original description of the clonned CL:
"Fake server now updates each model type's progress markers independently.
Previously the fake server used to update all of the progress markers
to the highest single version of an entity being returned in a
GetUpdates response. This caused odd behaviors when clients asked for
different sets of model types. This in turn resulted in tests failing
when they never agreed on some progress marker's version that wasn't
actually being actively updated.
This change separates all model types version/progress markers in the
fake server code. This should help clients that are being enabled
mid-test to get match progress markers when priority and non-priority
types are requested across separate GetUpdates messages.
Also removed some special case logic around filtering deleted items. It
is unclear what purpose that logic was serving."
BUG= 651415
TEST=components_unittests, browser_tests
Review-Url: https://codereview.chromium.org/2910993002
Cr-Commit-Position: refs/heads/master@{#475859}
[modify] https://crrev.com/092f21a0129935b175abf418e957e3b644bc23d3/components/sync/engine_impl/loopback_server/loopback_server.cc
Comment 1 by pastarmovj@chromium.org
, Dec 13 2016