New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651409 link

Starred by 1 user
Status: Fixed
Owner:
pastarmovj@chromium.org
Closed: Dec 2016
Cc:
zea@chromium.org
█ blumberg@chromium.org
pav...@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 650258
Blocking:
issue 646653



Sign in to add a comment

Make sync startup possible for not signed in profiles when using the local sync server

Project Member Reported by pastarmovj@chromium.org, Sep 29 2016 
When sync is running in local mode signing in is not a requirement for sync to start. 

This change requires changes throughout the sync stack due to various checks for the signed-in state throughout the code. Those should be made dependent on the chosen sync backend.

Comment 1 by pastarmovj@chromium.org, Nov 10 2016

Labels: M-56
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/645df3089e27103dbe55998c0c3692236d281e53

commit 645df3089e27103dbe55998c0c3692236d281e53
Author: pastarmovj <pastarmovj@chromium.org>
Date: Wed Dec 21 12:45:21 2016

[Sync] Allow sync start without sign-in if the local sync backend is on.

Makes all signed-in checks conditional on the local_sync_backend_enabled
flag. Great care is taken for this change to have no side-effects on sync
running in non-local mode.

There are two major changes in this CL:
  1. Move the logic checking the local sync flags from ProfileSyncService
     to ProfileSyncServiceFactory::BuildServiceInstanceFor.
  2. Add checks and conditionally do checks if sign-in has happened only
     if the local sync backend flag is not set. Back up with tests that
     this works as expected.

BUG= 651409 
TEST=components_unittests

Review-Url: https://codereview.chromium.org/2494873003
Cr-Commit-Position: refs/heads/master@{#440075}

[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/chrome/browser/history/web_history_service_factory.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/chrome/browser/prefs/chrome_command_line_pref_store.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/chrome/browser/ui/sync/sync_promo_ui.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/browsing_data/core/history_notice_utils_unittest.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/precache/content/precache_manager.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/suggestions/suggestions_service_impl.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/BUILD.gn
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/base/sync_prefs.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/driver/fake_sync_service.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/driver/fake_sync_service.h
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/driver/sync_service.h
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/driver/sync_service_base.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/engine/engine_components_factory.h
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/engine/engine_components_factory_impl.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/engine/engine_components_factory_impl.h
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/engine/test_engine_components_factory.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/engine/test_engine_components_factory.h
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/engine_impl/sync_manager_impl.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/engine_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/engine_impl/sync_scheduler_impl.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/engine_impl/sync_scheduler_impl.h
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/engine_impl/sync_scheduler_impl_unittest.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/engine_impl/syncer_unittest.cc
[modify] https://crrev.com/645df3089e27103dbe55998c0c3692236d281e53/components/sync/test/engine/mock_connection_manager.h

Comment 3 by pastarmovj@chromium.org, Dec 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment