New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651386 link

Starred by 1 user
Status: WontFix
Owner:
fmalita@chromium.org
Closed: Sep 2016
Cc:
vmp...@chromium.org
nyerramilli@chromium.org
█ ranjitkan@chromium.org
reed@google.com
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Apps icon is not seen properly in emulated mode.

Reported by lpa...@etouch.net, Sep 29 2016 
Chrome Version: 55.0.2875.0 (Official Build) 065f3e402db7b3bb85f648586b8d63769c24edde-refs/heads/master@{#421703} 32/64-bit
OS:  Windows (7,8,10), Linux (Ubuntu 14.04 LTS), Mac (10.10.5,10.11.4)

Steps:
1. Launch chrome, open a new tab page.
2. Right click and select 'Inspect' and dock the devtools window to right.
3. Toggle to device mode and observe the 'Apps' icon in the tab page.

Actual: 'Google apps' icon is not seen properly in emulated mode.

Expected: 'Google apps' icon should seen properly in emulated mode.

This is Regression issue broken in M-53, below is the Narrow bisect info:

Good build: 53.0.2746.0
Bad build: 53.0.2748.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/72e829d44ebea9010a95409aecbcf2dd92aa52cb..e79f1dd40fc3a6591b1a30aa911eaf1fbb339e49?pretty=fuller&n=100

Suspecting: r395492 ?

Please re-assign if your change is not the cause of this issue.

Comment 1 by fmalita@chromium.org, Sep 29 2016

Labels: Needs-Feedback
Thanks for bisecting.  Do you have a screenshot with the issue?  I'm not sure what I'm looking for, AFAICT the apps icon looks good here (see attached).
emulated.png
243 KB View Download

Comment 2 by lpa...@etouch.net, Sep 30 2016

Labels: -Needs-Feedback
With response to comment #1:
Attached screenshot.

Note: Same issue is observed on print preview as well. Attached screenshot of the same.
Screenshot.png
243 KB View Download
Screenshot_PP.png
81.8 KB View Download

Comment 3 by fmalita@chromium.org, Sep 30 2016

Cc: chrishtr@chromium.org vmp...@chromium.org reed@google.com
Status: WontFix (was: Assigned)
Thanks for the report.

That's a very low scale, and the issue is not so much about correctness but image scaling quality.

There are indeed some scaling differences introduced in r395492, and it so happens that for this particular scale (device width == 400) the old result is more uniform.  But:

1) the new approach is more efficient, and yields higher-contrast results; if that icon contained any text glyphs, the new result would be significantly more readable.

2) for other/slightly different scales, the new results actually look better -- so this is not a general regression. See attached for the same comparison when the width is resized from 400 to 442 (new results on top).

3) since r395492, the general downscale approach in Chromium has also changed to favor contrast over uniformity; so even if we were to revert, the results would not go back to what they were.

Based on the above, I'm going to mark this WontFix.
width-442.png
14.6 KB View Download
►

Sign in to add a comment