Currently, VisibleSelection's constructor updates layout by itself, messing up the rendering pipeline. We should remove the layout update call and let the callers ensure clean layout instead.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfe6f8d59b4ed940fd55f453e629c663e62d8755 commit cfe6f8d59b4ed940fd55f453e629c663e62d8755 Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Sep 30 01:55:13 2016 Make non-null VisibleSelections creatable only by createVisibleSelection[Deprecated] This patch is a preparation for enforcing the creation of VisibleSelections in clean layout, by hiding the constructors (other than default, copy and assignment) of VisibleSelection as private and introducing new functions createVisibleSelection[Deprecated] for creating new VisibleSelections. createVisibleSelectionDeprecated can be called with dirty layout, and performs synchronous layout update by itself. All call sites of the constructors hidden by this patch are switched to it, except for that in AXLayoutObject. createVisibleSelection must be called with clean layout. The above-mentioned call site in AXLayoutObject is switched to call createVisibleSelection since it is known to have ensured clean layout. In future patches, all call sites of createVisibleSelectionDeprecated will be made to ensure clean layout and then switch to createVisibleSelection. BUG= 651373 Review-Url: https://codereview.chromium.org/2374183004 Cr-Commit-Position: refs/heads/master@{#422011} [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/DOMSelection.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/EditingUtilities.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/Editor.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/GranularityStrategy.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/PendingSelection.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/SelectionController.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/SelectionModifier.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/VisibleSelection.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/VisibleSelection.h [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/input/EventHandlerTest.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/page/DragController.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/page/FocusController.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/cfe6f8d59b4ed940fd55f453e629c663e62d8755/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b84e284987d122603226db600a398a9cbe235f62 commit b84e284987d122603226db600a398a9cbe235f62 Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Sep 30 06:58:38 2016 Prune CreateVisibleSelectionDeprecated from unit test files This patch also adds DCHECKs to createVisibleSelection to prevent callers from passing null base and non-null extent, which does not make sense. BUG= 651373 Review-Url: https://codereview.chromium.org/2375383005 Cr-Commit-Position: refs/heads/master@{#422049} [modify] https://crrev.com/b84e284987d122603226db600a398a9cbe235f62/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp [modify] https://crrev.com/b84e284987d122603226db600a398a9cbe235f62/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp [modify] https://crrev.com/b84e284987d122603226db600a398a9cbe235f62/third_party/WebKit/Source/core/editing/SelectionAdjusterTest.cpp [modify] https://crrev.com/b84e284987d122603226db600a398a9cbe235f62/third_party/WebKit/Source/core/editing/VisibleSelection.cpp [modify] https://crrev.com/b84e284987d122603226db600a398a9cbe235f62/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp [modify] https://crrev.com/b84e284987d122603226db600a398a9cbe235f62/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp [modify] https://crrev.com/b84e284987d122603226db600a398a9cbe235f62/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp [modify] https://crrev.com/b84e284987d122603226db600a398a9cbe235f62/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp [modify] https://crrev.com/b84e284987d122603226db600a398a9cbe235f62/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b2c09f630fcaf571c3d022cb5b26effbde3de1f commit 2b2c09f630fcaf571c3d022cb5b26effbde3de1f Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Sep 30 07:07:00 2016 Prune CreateVisibleSelectionDeprecated from web BUG= 651373 Review-Url: https://codereview.chromium.org/2385623002 Cr-Commit-Position: refs/heads/master@{#422051} [modify] https://crrev.com/2b2c09f630fcaf571c3d022cb5b26effbde3de1f/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/2b2c09f630fcaf571c3d022cb5b26effbde3de1f/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/2b2c09f630fcaf571c3d022cb5b26effbde3de1f/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/2b2c09f630fcaf571c3d022cb5b26effbde3de1f/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7771b00740741a22c321c23340c40900f47f26d1 commit 7771b00740741a22c321c23340c40900f47f26d1 Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Sep 30 07:42:58 2016 Prune CreateVisibleSelectionDeprecated from SpellChecker BUG= 651373 Review-Url: https://codereview.chromium.org/2381233003 Cr-Commit-Position: refs/heads/master@{#422055} [modify] https://crrev.com/7771b00740741a22c321c23340c40900f47f26d1/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9096880ed9d0f74477feb6de0413fc613a9c52f commit c9096880ed9d0f74477feb6de0413fc613a9c52f Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Sep 30 07:44:48 2016 Prune CreateVisibleSelectionDeprecated from SelectionModifier BUG= 651373 Review-Url: https://codereview.chromium.org/2384633003 Cr-Commit-Position: refs/heads/master@{#422057} [modify] https://crrev.com/c9096880ed9d0f74477feb6de0413fc613a9c52f/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a83990e41918b82190490fd2be243144a9426ea6 commit a83990e41918b82190490fd2be243144a9426ea6 Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Sep 30 08:35:36 2016 Prune CreateVisibleSelectionDeprecated from PendingSelection BUG= 651373 , 603684 Review-Url: https://codereview.chromium.org/2382993002 Cr-Commit-Position: refs/heads/master@{#422066} [modify] https://crrev.com/a83990e41918b82190490fd2be243144a9426ea6/third_party/WebKit/Source/core/editing/PendingSelection.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/008a854391318e289c35c43eeb9b78e1896c30f7 commit 008a854391318e289c35c43eeb9b78e1896c30f7 Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Sep 30 10:58:58 2016 Revert of Prune CreateVisibleSelectionDeprecated from SpellChecker (patchset #1 id:1 of https://codereview.chromium.org/2381233003/ ) Reason for revert: Causing a lot of editing layout tests to fail by hitting the DCHECK in createVisibleSelection. Original issue's description: > Prune CreateVisibleSelectionDeprecated from SpellChecker > > BUG= 651373 > > Committed: https://crrev.com/7771b00740741a22c321c23340c40900f47f26d1 > Cr-Commit-Position: refs/heads/master@{#422055} TBR=yosin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 651373 Review-Url: https://codereview.chromium.org/2383733002 Cr-Commit-Position: refs/heads/master@{#422079} [modify] https://crrev.com/008a854391318e289c35c43eeb9b78e1896c30f7/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7731ccff648c8feb3ede2b8668a25dc0d3a7acfc commit 7731ccff648c8feb3ede2b8668a25dc0d3a7acfc Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 03 04:23:10 2016 Temporarily remove a DCHECK from createVisibleSelection This patch removes DCHECK(base.isNotNull() || extent.isNull()) from createVisibleSelection because it doesn't hold for all callers. It will be added back after we have ensured that. BUG= 651373 Review-Url: https://codereview.chromium.org/2387963003 Cr-Commit-Position: refs/heads/master@{#422371} [modify] https://crrev.com/7731ccff648c8feb3ede2b8668a25dc0d3a7acfc/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80bbe6ca56f9fd85cc87d96cc04c7d4eee84a3d2 commit 80bbe6ca56f9fd85cc87d96cc04c7d4eee84a3d2 Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 03 05:49:16 2016 Prune createVisibleSelectionDeprecated from Editor This patch also contains a drive-by removal of a redundant layout update in |executeFindString()| in EditorCommands.cpp, because the caller of this function, Editor::Command::execute, already ensures clean layout. BUG= 651373 Review-Url: https://codereview.chromium.org/2387993002 Cr-Commit-Position: refs/heads/master@{#422374} [modify] https://crrev.com/80bbe6ca56f9fd85cc87d96cc04c7d4eee84a3d2/third_party/WebKit/Source/core/editing/Editor.cpp [modify] https://crrev.com/80bbe6ca56f9fd85cc87d96cc04c7d4eee84a3d2/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c333ca777eda0f33726c8e30f1a24600f63f70df commit c333ca777eda0f33726c8e30f1a24600f63f70df Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 03 06:14:34 2016 Prune CreateVisibleSelectionDeprecated from DOMSelection BUG= 651373 Review-Url: https://codereview.chromium.org/2384103002 Cr-Commit-Position: refs/heads/master@{#422376} [modify] https://crrev.com/c333ca777eda0f33726c8e30f1a24600f63f70df/third_party/WebKit/Source/core/editing/DOMSelection.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/930e0247b7f381345cfe71a0f5c4e19c7c0486b2 commit 930e0247b7f381345cfe71a0f5c4e19c7c0486b2 Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 03 06:47:35 2016 Prune createVisibleSelectionDeprecated from GranularityStrategy BUG= 651373 Review-Url: https://codereview.chromium.org/2388003002 Cr-Commit-Position: refs/heads/master@{#422379} [modify] https://crrev.com/930e0247b7f381345cfe71a0f5c4e19c7c0486b2/third_party/WebKit/Source/core/editing/GranularityStrategy.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1301c7b47926fa0d435c2f396a6aeba2a4d179c1 commit 1301c7b47926fa0d435c2f396a6aeba2a4d179c1 Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 03 06:55:09 2016 Prune createVisibleSelectionDeprecated from SelectionAdjuster BUG= 651373 Review-Url: https://codereview.chromium.org/2389653002 Cr-Commit-Position: refs/heads/master@{#422380} [modify] https://crrev.com/1301c7b47926fa0d435c2f396a6aeba2a4d179c1/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/1301c7b47926fa0d435c2f396a6aeba2a4d179c1/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6315b606245d979e4a0948bb490b2eee6b9ec41f commit 6315b606245d979e4a0948bb490b2eee6b9ec41f Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 03 07:02:04 2016 Prune createVisibleSelectionDeprecated from EditingUtilities BUG= 651373 Review-Url: https://codereview.chromium.org/2392473002 Cr-Commit-Position: refs/heads/master@{#422381} [modify] https://crrev.com/6315b606245d979e4a0948bb490b2eee6b9ec41f/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/666af71049d1b77a81ba9c15da70da466fdc6abd commit 666af71049d1b77a81ba9c15da70da466fdc6abd Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 03 08:18:04 2016 Prune createVisibleSelectionDeprecated from svg SVGTextContentElement::selectSubString calls VisiblePosition::firstPositionInNode, which updates layout and thus ensures clean layout for the later call of createVisibleSelectionDeprecated. Hence, this patch safely prunes this call of createVisibleSelectionDeprecated. BUG= 651373 Review-Url: https://codereview.chromium.org/2392483002 Cr-Commit-Position: refs/heads/master@{#422389} [modify] https://crrev.com/666af71049d1b77a81ba9c15da70da466fdc6abd/third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e9150e3600af4fdc3a0675e223f1e26772234ed commit 5e9150e3600af4fdc3a0675e223f1e26772234ed Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 03 08:49:54 2016 Prune createVisibleSelectionDeprecated from FocusController BUG= 651373 Review-Url: https://codereview.chromium.org/2389673002 Cr-Commit-Position: refs/heads/master@{#422392} [modify] https://crrev.com/5e9150e3600af4fdc3a0675e223f1e26772234ed/third_party/WebKit/Source/core/page/FocusController.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e0721d971f7bfeca41873d76e8fe0959ec6b3f1 commit 6e0721d971f7bfeca41873d76e8fe0959ec6b3f1 Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 03 09:04:08 2016 Reland of Prune CreateVisibleSelectionDeprecated from SpellChecker (patchset #1 id:1 of https://codereview.chromium.org/2383733002/ ) Reason for revert: The DCHECK is removed, so this patch can be relanded. Original issue's description: > Revert of Prune CreateVisibleSelectionDeprecated from SpellChecker (patchset #1 id:1 of https://codereview.chromium.org/2381233003/ ) > > Reason for revert: > Causing a lot of editing layout tests to fail by hitting the DCHECK in createVisibleSelection. > > Original issue's description: > > Prune CreateVisibleSelectionDeprecated from SpellChecker > > > > BUG= 651373 > > > > Committed: https://crrev.com/7771b00740741a22c321c23340c40900f47f26d1 > > Cr-Commit-Position: refs/heads/master@{#422055} > > TBR=yosin@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 651373 > > Committed: https://crrev.com/008a854391318e289c35c43eeb9b78e1896c30f7 > Cr-Commit-Position: refs/heads/master@{#422079} TBR=yosin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 651373 Review-Url: https://codereview.chromium.org/2390573002 Cr-Commit-Position: refs/heads/master@{#422394} [modify] https://crrev.com/6e0721d971f7bfeca41873d76e8fe0959ec6b3f1/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0895689a9cf3613ea07cd1a05ce4c6d32d6d411c commit 0895689a9cf3613ea07cd1a05ce4c6d32d6d411c Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 03 09:32:07 2016 Make DragCaretController store PositionWithAffinity instead of VisiblePosition DragCaretController is an on-stack object that stores a VisiblePosition and may inspect properties of the VisiblePosition even after it is invalidated. This patch fixes it by making DragCaretController store a PositionWithAffinity instead. This patch is a preparation of pruning createVisibleSelectionDeprecated from DragController: https://codereview.chromium.org/2386083002 BUG=648949, 651373 Review-Url: https://codereview.chromium.org/2388703002 Cr-Commit-Position: refs/heads/master@{#422395} [modify] https://crrev.com/0895689a9cf3613ea07cd1a05ce4c6d32d6d411c/third_party/WebKit/Source/core/editing/DragCaretController.cpp [modify] https://crrev.com/0895689a9cf3613ea07cd1a05ce4c6d32d6d411c/third_party/WebKit/Source/core/editing/DragCaretController.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4568b4cad0a4e6456bc606a6e813cff95951fd63 commit 4568b4cad0a4e6456bc606a6e813cff95951fd63 Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 03 12:25:36 2016 Prune createVisibleSelectionDeprecated from SelectionController BUG= 651373 Review-Url: https://codereview.chromium.org/2391493002 Cr-Commit-Position: refs/heads/master@{#422404} [modify] https://crrev.com/4568b4cad0a4e6456bc606a6e813cff95951fd63/third_party/WebKit/Source/core/editing/SelectionController.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1d59d936e6de0bdf43fc8fac4b191e2c152354d commit d1d59d936e6de0bdf43fc8fac4b191e2c152354d Author: xiaochengh <xiaochengh@chromium.org> Date: Tue Oct 04 02:00:21 2016 Prune createVisibleSelectionDeprecated from FrameSelection BUG= 651373 Review-Url: https://codereview.chromium.org/2386073003 Cr-Commit-Position: refs/heads/master@{#422667} [modify] https://crrev.com/d1d59d936e6de0bdf43fc8fac4b191e2c152354d/third_party/WebKit/Source/core/editing/DOMSelection.cpp [modify] https://crrev.com/d1d59d936e6de0bdf43fc8fac4b191e2c152354d/third_party/WebKit/Source/core/editing/FrameSelection.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/189778ba4d34566e1a237c4c21262a46c698f14c commit 189778ba4d34566e1a237c4c21262a46c698f14c Author: xiaochengh <xiaochengh@chromium.org> Date: Tue Oct 04 11:43:52 2016 Revert of Prune createVisibleSelectionDeprecated from SelectionAdjuster (patchset #1 id:1 of https://codereview.chromium.org/2389653002/ ) Reason for revert: Suspected of causing crbug.com/652301 Original issue's description: > Prune createVisibleSelectionDeprecated from SelectionAdjuster > > BUG= 651373 > > Committed: https://crrev.com/1301c7b47926fa0d435c2f396a6aeba2a4d179c1 > Cr-Commit-Position: refs/heads/master@{#422380} TBR=yosin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 651373 Review-Url: https://codereview.chromium.org/2391973002 Cr-Commit-Position: refs/heads/master@{#422756} [modify] https://crrev.com/189778ba4d34566e1a237c4c21262a46c698f14c/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/189778ba4d34566e1a237c4c21262a46c698f14c/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e348b48e7e058f44d359263b750bb5412ab932a commit 4e348b48e7e058f44d359263b750bb5412ab932a Author: xiaochengh <xiaochengh@chromium.org> Date: Wed Oct 05 01:22:57 2016 Prune createVisibleSelectionDeprecated from DragController This patch prunes createVisibleSelectionDeprecated from DragController by either having an explicit layout update before each call site, or confirming that the layout is already clean. Note: Layout is clean at the call site in |dispatchTextInputEventFor()| because it's called directly after a hit test, which is performed in |elementUnderMouse()|. BUG= 651373 Review-Url: https://codereview.chromium.org/2386083002 Cr-Commit-Position: refs/heads/master@{#423036} [modify] https://crrev.com/4e348b48e7e058f44d359263b750bb5412ab932a/third_party/WebKit/Source/core/page/DragController.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7562d689d633f658704e81899e5a86a4a6375b8d commit 7562d689d633f658704e81899e5a86a4a6375b8d Author: xiaochengh <xiaochengh@chromium.org> Date: Wed Oct 05 07:37:51 2016 Prune createVisibleSelectionDeprecated from FocusController BUG= 651373 Review-Url: https://codereview.chromium.org/2399443002 Cr-Commit-Position: refs/heads/master@{#423100} [modify] https://crrev.com/7562d689d633f658704e81899e5a86a4a6375b8d/third_party/WebKit/Source/core/page/FocusController.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f842237fbe23e8b17085725c49e2829f9927fc3 commit 1f842237fbe23e8b17085725c49e2829f9927fc3 Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Oct 06 02:12:03 2016 Prune createVisibleSelectionDeprecated from CreateLinkCommand BUG= 651373 Review-Url: https://codereview.chromium.org/2391723006 Cr-Commit-Position: refs/heads/master@{#423394} [modify] https://crrev.com/1f842237fbe23e8b17085725c49e2829f9927fc3/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f68abcbb358214261742479653a6ef534b7837b0 commit f68abcbb358214261742479653a6ef534b7837b0 Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Oct 06 02:13:55 2016 Prune deprecated editing functions from ApplyBlockElementCommand and its subclasses This patch prunes the following deprecated functions from ApplyBlockElementCommand and its subclasses by ensuring clean layout and valid arguments at each call site: - createVisiblePositionDeprecated - createVisibleSelectionDeprecated - VisibleSelection::visible{Start,End}Deprecated - nextPositionOfDeprecated - paragraph related deprecated functions BUG= 647219 , 651373 Review-Url: https://codereview.chromium.org/2393133002 Cr-Commit-Position: refs/heads/master@{#423395} [modify] https://crrev.com/f68abcbb358214261742479653a6ef534b7837b0/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp [modify] https://crrev.com/f68abcbb358214261742479653a6ef534b7837b0/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp [modify] https://crrev.com/f68abcbb358214261742479653a6ef534b7837b0/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8766a6a54ee2092471d862112da82e958a18aa9d commit 8766a6a54ee2092471d862112da82e958a18aa9d Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Oct 06 04:43:00 2016 Prune createVisibleSelectionDeprecated from Element BUG= 651373 Review-Url: https://codereview.chromium.org/2399753002 Cr-Commit-Position: refs/heads/master@{#423432} [modify] https://crrev.com/8766a6a54ee2092471d862112da82e958a18aa9d/third_party/WebKit/Source/core/dom/Element.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c974b72c00883f18763d11369b8a97696824e3f4 commit c974b72c00883f18763d11369b8a97696824e3f4 Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Oct 06 05:16:36 2016 Prune a new call site of createVisibleSelectionDeprecated from DragController This patch prunes a new call site of createVisibleSelectionDeprecated, which was introduced by r422915 and hence not catched by r423036, from DragController. BUG= 651373 Review-Url: https://codereview.chromium.org/2398923002 Cr-Commit-Position: refs/heads/master@{#423438} [modify] https://crrev.com/c974b72c00883f18763d11369b8a97696824e3f4/third_party/WebKit/Source/core/page/DragController.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33e97547aa6173ea92f3d7241434f06d73e94e75 commit 33e97547aa6173ea92f3d7241434f06d73e94e75 Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Oct 06 05:21:17 2016 Prune deprecated functions from ApplyStyleCommand This patch prunes the following deprecated functions from ApplyStyleCommand by ensuring clean layout and valid input parameters: - createVisiblePositionDeprecated - createVisibleSelectionDeprecated - startOfParagraphDeprecated - endOfParagraphDeprecated BUG= 647219 , 651373 Review-Url: https://codereview.chromium.org/2391193004 Cr-Commit-Position: refs/heads/master@{#423440} [modify] https://crrev.com/33e97547aa6173ea92f3d7241434f06d73e94e75/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b7a781809b93b15853be8f91db67f5c2584e0ad commit 4b7a781809b93b15853be8f91db67f5c2584e0ad Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Oct 06 07:10:25 2016 Prune createVisibleSelectionDeprecated from SelectionAdjuster BUG= 651373 Review-Url: https://codereview.chromium.org/2395053002 Cr-Commit-Position: refs/heads/master@{#423465} [modify] https://crrev.com/4b7a781809b93b15853be8f91db67f5c2584e0ad/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8546160b3124094034c53aafef3da4d349a6bef9 commit 8546160b3124094034c53aafef3da4d349a6bef9 Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Oct 06 09:42:00 2016 Prune createVisibleSelectionDeprecated from CreateLinkCommand A previous patch (crrev.com/2391723006) ensured clean layout but forgot to rename the function call from createVisibleSelectionDeprecated to createVisibleSelection. This patch does the renaming. BUG= 651373 Review-Url: https://codereview.chromium.org/2397873004 Cr-Commit-Position: refs/heads/master@{#423491} [modify] https://crrev.com/8546160b3124094034c53aafef3da4d349a6bef9/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be74a4d63bc93ec1b099a2b975a4321c96ac19a1 commit be74a4d63bc93ec1b099a2b975a4321c96ac19a1 Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Oct 06 15:03:27 2016 Prune deprecated functions from DeleteSelectionCommand BUG= 647219 , 651373 Review-Url: https://codereview.chromium.org/2399793002 Cr-Commit-Position: refs/heads/master@{#423533} [modify] https://crrev.com/be74a4d63bc93ec1b099a2b975a4321c96ac19a1/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00789267c5d338a9d2151c950fbd8bf9f47ba92b commit 00789267c5d338a9d2151c950fbd8bf9f47ba92b Author: xiaochengh <xiaochengh@chromium.org> Date: Thu Oct 06 15:04:14 2016 Prune deprecated functions from BreakBlockquoteCommand BUG= 647219 , 651373 Review-Url: https://codereview.chromium.org/2399773002 Cr-Commit-Position: refs/heads/master@{#423534} [modify] https://crrev.com/00789267c5d338a9d2151c950fbd8bf9f47ba92b/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf43a0661cc568c57f073904d76b989b363b23ea commit cf43a0661cc568c57f073904d76b989b363b23ea Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Oct 07 05:36:48 2016 Prune deprecated functions from TypingCommand BUG=648949, 651373 Review-Url: https://codereview.chromium.org/2393353004 Cr-Commit-Position: refs/heads/master@{#423801} [modify] https://crrev.com/cf43a0661cc568c57f073904d76b989b363b23ea/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1947c7fd01731ba28e72137e99d9cf78c7ab0b6 commit d1947c7fd01731ba28e72137e99d9cf78c7ab0b6 Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Oct 07 09:19:23 2016 Prune deprecated functions from InsertListCommand BUG= 647219 ,648949, 651373 Review-Url: https://codereview.chromium.org/2400053003 Cr-Commit-Position: refs/heads/master@{#423822} [modify] https://crrev.com/d1947c7fd01731ba28e72137e99d9cf78c7ab0b6/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/530e41279924e07a77a1164a6e1cf20e28cd63c3 commit 530e41279924e07a77a1164a6e1cf20e28cd63c3 Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Oct 07 09:29:45 2016 Prune deprecated functions from InsertLinebreakCommand BUG= 647219 , 651373 Review-Url: https://codereview.chromium.org/2397243004 Cr-Commit-Position: refs/heads/master@{#423823} [modify] https://crrev.com/530e41279924e07a77a1164a6e1cf20e28cd63c3/third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/908c1a145ab363b72a7053d5de31bde47939dc81 commit 908c1a145ab363b72a7053d5de31bde47939dc81 Author: xiaochengh <xiaochengh@chromium.org> Date: Fri Oct 07 10:06:55 2016 Prune deprecated functions from ReplaceSelectionCommand BUG= 647219 , 651373 Review-Url: https://codereview.chromium.org/2395393002 Cr-Commit-Position: refs/heads/master@{#423830} [modify] https://crrev.com/908c1a145ab363b72a7053d5de31bde47939dc81/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f2142d653eeabe6a8c67f36a3c913868577c26d commit 4f2142d653eeabe6a8c67f36a3c913868577c26d Author: xiaochengh <xiaochengh@chromium.org> Date: Tue Oct 11 08:28:37 2016 Prune deprecated functions from InsertListCommand BUG= 647219 , 651373 Review-Url: https://codereview.chromium.org/2406143002 Cr-Commit-Position: refs/heads/master@{#424391} [modify] https://crrev.com/4f2142d653eeabe6a8c67f36a3c913868577c26d/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/498e9e19dffeb563c02167e40da7a4424eaba02e commit 498e9e19dffeb563c02167e40da7a4424eaba02e Author: xiaochengh <xiaochengh@chromium.org> Date: Tue Oct 11 08:32:06 2016 Prune deprecated functions from InsertTextCommand BUG= 647219 ,648949, 651373 Review-Url: https://codereview.chromium.org/2404183002 Cr-Commit-Position: refs/heads/master@{#424392} [modify] https://crrev.com/498e9e19dffeb563c02167e40da7a4424eaba02e/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41252e6258555c44a7ac50c202de3379f7620f75 commit 41252e6258555c44a7ac50c202de3379f7620f75 Author: xiaochengh <xiaochengh@chromium.org> Date: Tue Oct 11 09:15:32 2016 Prune all but one deprecated functions from InsertParagraphSeparatorCommand BUG= 647219 , 651373 Review-Url: https://codereview.chromium.org/2411593002 Cr-Commit-Position: refs/heads/master@{#424394} [modify] https://crrev.com/41252e6258555c44a7ac50c202de3379f7620f75/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc8c3088a0fb49c131d9a6e472d8020946f1a161 commit cc8c3088a0fb49c131d9a6e472d8020946f1a161 Author: xiaochengh <xiaochengh@chromium.org> Date: Wed Oct 12 02:16:30 2016 Prune most of the deprecated functions from CompositeEditCommand BUG= 647219 , 651373 Review-Url: https://codereview.chromium.org/2410813002 Cr-Commit-Position: refs/heads/master@{#424648} [modify] https://crrev.com/cc8c3088a0fb49c131d9a6e472d8020946f1a161/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c50cabb44a4c3f050f0d1bb260960b62e1f266ea commit c50cabb44a4c3f050f0d1bb260960b62e1f266ea Author: xiaochengh <xiaochengh@chromium.org> Date: Wed Oct 12 13:41:10 2016 Prune createVisibleSelectionDeprecated from EditCommand::setEndingSelection This patch prunes createVisibleSelectionDeprecated from the above function as all callers have ensured clean layout and valid VisiblePosition as input. BUG= 651373 Review-Url: https://codereview.chromium.org/2412043002 Cr-Commit-Position: refs/heads/master@{#424730} [modify] https://crrev.com/c50cabb44a4c3f050f0d1bb260960b62e1f266ea/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7a2dfb0e4118e118fdbd2bd566aa3fa77a7d665 commit c7a2dfb0e4118e118fdbd2bd566aa3fa77a7d665 Author: xiaochengh <xiaochengh@chromium.org> Date: Wed Oct 12 14:03:10 2016 Prune deprecated functions from VisibleSelection and VisibleUnits This patch prunes all deprecated functions from VisibleSelection and VisibleUnits because they have no callers any more. The following functions are removed: - VisibleSelection::visible{Start,End}Deprecated - createVisibleSelectionDeprecated (all overloads) - paragraph-related deprecated functions (in VisibleUnits) - {previous,next}PositionOf (in VisibleUnits) BUG= 647219 ,648949, 651373 Review-Url: https://codereview.chromium.org/2411303002 Cr-Commit-Position: refs/heads/master@{#424732} [modify] https://crrev.com/c7a2dfb0e4118e118fdbd2bd566aa3fa77a7d665/third_party/WebKit/Source/core/editing/VisibleSelection.cpp [modify] https://crrev.com/c7a2dfb0e4118e118fdbd2bd566aa3fa77a7d665/third_party/WebKit/Source/core/editing/VisibleSelection.h [modify] https://crrev.com/c7a2dfb0e4118e118fdbd2bd566aa3fa77a7d665/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [modify] https://crrev.com/c7a2dfb0e4118e118fdbd2bd566aa3fa77a7d665/third_party/WebKit/Source/core/editing/VisibleUnits.h
All call sites of createVisibleSelection have been pruned. Closing the issue.
Whoops, there is still VisibleSelectionTemplate::selectionFromContentsOfNode...
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/401a4537d2469ceeb8a347f0b47d50f216fc2a03 commit 401a4537d2469ceeb8a347f0b47d50f216fc2a03 Author: xiaochengh <xiaochengh@chromium.org> Date: Mon Oct 17 10:13:15 2016 Ensure clean layout for VisibleSelection::selectionFromContentsOfNode BUG= 651373 Review-Url: https://codereview.chromium.org/2425543003 Cr-Commit-Position: refs/heads/master@{#425646} [modify] https://crrev.com/401a4537d2469ceeb8a347f0b47d50f216fc2a03/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/401a4537d2469ceeb8a347f0b47d50f216fc2a03/third_party/WebKit/Source/core/editing/VisibleSelection.cpp [modify] https://crrev.com/401a4537d2469ceeb8a347f0b47d50f216fc2a03/third_party/WebKit/Source/core/editing/VisibleSelection.h [modify] https://crrev.com/401a4537d2469ceeb8a347f0b47d50f216fc2a03/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp [modify] https://crrev.com/401a4537d2469ceeb8a347f0b47d50f216fc2a03/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp [modify] https://crrev.com/401a4537d2469ceeb8a347f0b47d50f216fc2a03/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
[Automated comment] removing mislabelled merge-merged-2840
Comment 1 by bugdroid1@chromium.org
, Sep 30 2016