Regression: [MD History] Arrow key navigation doesn't work for 'Tabs from other devices' section.
Reported by
dchau...@etouch.net,
Sep 29 2016
|
|||
Issue descriptionChrome Version: 55.0.2875.0 (Official Build) 065f3e402db7b3bb85f648586b8d63769c24edde-refs/heads/master@{#421703} 32/64-bit. OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS). What steps will reproduce the problem? 1. Launch chrome and sign in to chrome with such accounts in which browsing history from other devices are synced. 2. Navigate to chrome://history page and go to 'Tabs from other devices' section. 3. Keep focus on 'Action' icon using 'Tab' key, press down arrow key from keyboard and observe. On pressing down arrow key, Focus doesn't move through action icon (Unnecessary page scroll down). On pressing down arrow key, Focus should move through action icon. Note: This issue is also seen for collapse/Expand list icon and URL also. This is a regression issue, broken in M-55 series, below is manual regression range. Good build: 55.0.2867.0 Bad build: 55.0.2868.0 Unable to sign in to chromium build, hence unable to narrow down it. hence providing change log URL. Change Log URL: https://chromium.googlesource.com/chromium/src/+log/55.0.2867.0..55.0.2868.0?pretty=fuller&n=10000 Suspecting: r419956 Kindly review the attached screen-cast for reference.
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9266bd31e78d69ba0edac40a1e5cce70d3740bde commit 9266bd31e78d69ba0edac40a1e5cce70d3740bde Author: calamity <calamity@chromium.org> Date: Wed Oct 05 06:29:38 2016 [MD History] Make synced devices keyboard navigation consistent. This CL makes the synced devices use the same keyboard navigation scheme as the history list. BUG= 651352 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2394433002 Cr-Commit-Position: refs/heads/master@{#423090} [modify] https://crrev.com/9266bd31e78d69ba0edac40a1e5cce70d3740bde/chrome/browser/resources/md_history/compiled_resources2.gyp [modify] https://crrev.com/9266bd31e78d69ba0edac40a1e5cce70d3740bde/chrome/browser/resources/md_history/lazy_load.crisper.js [modify] https://crrev.com/9266bd31e78d69ba0edac40a1e5cce70d3740bde/chrome/browser/resources/md_history/lazy_load.vulcanized.html [modify] https://crrev.com/9266bd31e78d69ba0edac40a1e5cce70d3740bde/chrome/browser/resources/md_history/synced_device_card.html [modify] https://crrev.com/9266bd31e78d69ba0edac40a1e5cce70d3740bde/chrome/browser/resources/md_history/synced_device_card.js [modify] https://crrev.com/9266bd31e78d69ba0edac40a1e5cce70d3740bde/chrome/browser/resources/md_history/synced_device_manager.html [modify] https://crrev.com/9266bd31e78d69ba0edac40a1e5cce70d3740bde/chrome/browser/resources/md_history/synced_device_manager.js [modify] https://crrev.com/9266bd31e78d69ba0edac40a1e5cce70d3740bde/chrome/test/data/webui/md_history/history_synced_tabs_test.js
,
Oct 6 2016
Verified the issue on windows 10, Ubuntu 14.04 and Mac 10.11.6 using chrome dev version #55.0.2882.0 as per the comment #0 Observed that the fix is working as expected. Attaching screencast for reference Hence, adding the verified labels.
,
Oct 7 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tsergeant@chromium.org
, Oct 4 2016