New issue
Advanced search Search tips

Issue 651350 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 419413
issue 449682



Sign in to add a comment

bluetooth: mac: Reject requestDevice promise if Mac version is <= 10.9

Project Member Reported by fbeaufort@chromium.org, Sep 29 2016 
MacOS 10.9 doesn’t support Web Bluetooth. However Bluetooth chooser still shows up...

Can we simply reject the requestDevice promise if the platform is not supported so that developers don’t fight for hours and wonder why they can’t see nearby devices?

Comment 1 by ortuno@chromium.org, Sep 29 2016 

I think this comes back to classic support again. Classic is supported on <= 10.9 so we show the chooser.

Comment 2 by fbeaufort@chromium.org, Sep 29 2016

Summary: bluetooth: mac: Reject requestDevice promise if Mac version is <= 10.9 (was: bluetooth: Reject requestDevice promise if Mac version is <= 10.9 )

Comment 3 by jyasskin@chromium.org, Sep 29 2016

Blocking: 419413

Comment 4 by hyungwoo...@navercorp.com, Oct 2 2016 

Can I take this issue?
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30846487078f8a61467d1b39b12e41cfe3bed524

commit 30846487078f8a61467d1b39b12e41cfe3bed524
Author: beaufort.francois <beaufort.francois@gmail.com>
Date: Wed Oct 05 14:35:35 2016

bluetooth: mac: Reject requestDevice promise if Mac version is <= 10.9

BUG= 651350 

Review-Url: https://codereview.chromium.org/2384463002
Cr-Commit-Position: refs/heads/master@{#423155}

[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/content/browser/bluetooth/bluetooth_metrics.h
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/device/bluetooth/bluetooth_adapter_factory.cc
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/device/bluetooth/bluetooth_adapter_factory.h
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/device/bluetooth/bluetooth_adapter_factory_wrapper.cc
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/device/bluetooth/bluetooth_adapter_factory_wrapper.h
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/tools/metrics/histograms/histograms.xml

Comment 7 by fbeaufort@chromium.org, Oct 10 2016

Status: Fixed (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30846487078f8a61467d1b39b12e41cfe3bed524

commit 30846487078f8a61467d1b39b12e41cfe3bed524
Author: beaufort.francois <beaufort.francois@gmail.com>
Date: Wed Oct 05 14:35:35 2016

bluetooth: mac: Reject requestDevice promise if Mac version is <= 10.9

BUG= 651350 

Review-Url: https://codereview.chromium.org/2384463002
Cr-Commit-Position: refs/heads/master@{#423155}

[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/content/browser/bluetooth/bluetooth_metrics.h
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/device/bluetooth/bluetooth_adapter_factory.cc
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/device/bluetooth/bluetooth_adapter_factory.h
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/device/bluetooth/bluetooth_adapter_factory_wrapper.cc
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/device/bluetooth/bluetooth_adapter_factory_wrapper.h
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
[modify] https://crrev.com/30846487078f8a61467d1b39b12e41cfe3bed524/tools/metrics/histograms/histograms.xml

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment