New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651302 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Sep 13
Cc:
█ mgiuca@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Mac: Going fullscreen creates the fullscreen bubble 3 times (the first two are immediately destroyed)

Project Member Reported by tapted@chromium.org, Sep 29 2016 
Chrome Version       : 55.0.2868.3
OS Version: OS X 10.11.6

Steps: Go to http://permisison.site, click "fullscreen" and trace.

The common parts of the stacks are:

FullscreenController::ToggleFullscreenModeInternal(FullscreenController::FullscreenInternalOption) + 145
FullscreenController::EnterFullscreenModeForTab(content::WebContents*, GURL const&) + 561
Browser::EnterFullscreenModeForTab(content::WebContents*, GURL const&) + 79
content::WebContentsImpl::EnterFullscreenMode(GURL const&) + 169
content::RenderFrameHostImpl::OnToggleFullscreen(bool) + 1094
void base::DispatchToMethodImpl<content::RenderFrameHostImpl*, void (content::RenderFrameHostImpl::*)(bool), std::__1::tuple<bool> const&, 0ul>(content::RenderFrameHostImpl* const&, void (content::RenderFrameHostImpl::*)(bool), std::__1::tuple<bool> const&&&, base::IndexSequence<0ul>) + 158
void base::DispatchToMethod<content::RenderFrameHostImpl*, void (content::RenderFrameHostImpl::*)(bool), std::__1::tuple<bool> const&>(content::RenderFrameHostImpl* const&, void (content::RenderFrameHostImpl::*)(bool), std::__1::tuple<bool> const&&&) + 73
void IPC::DispatchToMethod<content::RenderFrameHostImpl, void (content::RenderFrameHostImpl::*)(bool), void, std::__1::tuple<bool> >(content::RenderFrameHostImpl*, void (content::RenderFrameHostImpl::*)(bool), void*, std::__1::tuple<bool> const&) + 93
bool IPC::MessageT<FrameHostMsg_ToggleFullscreen_Meta, std::__1::tuple<bool>, void>::Dispatch<content::RenderFrameHostImpl, content::RenderFrameHostImpl, void, void (content::RenderFrameHostImpl::*)(bool)>(IPC::Message const*, content::RenderFrameHostImpl*, content::RenderFrameHostImpl*, void*, void (content::RenderFrameHostImpl::*)(bool)) + 475
content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) + 9367



Then the first stack is

ExclusiveAccessBubbleViews::ExclusiveAccessBubbleViews(ExclusiveAccessBubbleViewsContext*, GURL const&, ExclusiveAccessBubbleType) + 43
ExclusiveAccessController::Show() + 336
-[BrowserWindowController(Private) showFullscreenExitBubbleIfNecessary] + 249
-[BrowserWindowController(Private) windowDidEnterFullScreen:] + 1270
-[BrowserWindowController(Private) enterImmersiveFullscreen] + 1344
-[BrowserWindowController(Fullscreen) enterWebContentFullscreen] + 174
ExclusiveAccessController::EnterFullscreen(GURL const&, ExclusiveAccessBubbleType) + 233
FullscreenController::EnterFullscreenModeInternal(FullscreenController::FullscreenInternalOption) + 387
FullscreenController::ToggleFullscreenModeInternal(FullscreenController::FullscreenInternalOption) + 145

Second stack is

ExclusiveAccessBubbleViews::ExclusiveAccessBubbleViews(ExclusiveAccessBubbleViewsContext*, GURL const&, ExclusiveAccessBubbleType) + 43
ExclusiveAccessController::Show() + 336
-[BrowserWindowController(Private) showFullscreenExitBubbleIfNecessary] + 249
-[BrowserWindowController(Fullscreen) updateFullscreenExitBubble] + 70
-[BrowserWindowController(Fullscreen) enterWebContentFullscreen] + 255
ExclusiveAccessController::EnterFullscreen(GURL const&, ExclusiveAccessBubbleType) + 233
FullscreenController::EnterFullscreenModeInternal(FullscreenController::FullscreenInternalOption) + 387
FullscreenController::ToggleFullscreenModeInternal(FullscreenController::FullscreenInternalOption) + 145

Third stack is

ExclusiveAccessBubbleViews::ExclusiveAccessBubbleViews(ExclusiveAccessBubbleViewsContext*, GURL const&, ExclusiveAccessBubbleType) + 43
ExclusiveAccessController::Show() + 336
-[BrowserWindowController(Private) showFullscreenExitBubbleIfNecessary] + 249
-[BrowserWindowController(Fullscreen) updateFullscreenExitBubble] + 70
ExclusiveAccessController::UpdateExclusiveAccessExitBubbleContent(GURL const&, ExclusiveAccessBubbleType) + 188
ExclusiveAccessManager::UpdateExclusiveAccessExitBubbleContent() + 119
FullscreenController::EnterFullscreenModeInternal(FullscreenController::FullscreenInternalOption) + 410
FullscreenController::ToggleFullscreenModeInternal(FullscreenController::FullscreenInternalOption) + 145


This is breaking in the ExclusiveAccessBubbleViews constructor. Each time it creates a new widget, sets bounds, sets animations, etc. Then destroys any existing widget.

Comment 1 by tapted@chromium.org, Sep 29 2016

Description: Show this description
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 29 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by tapted@chromium.org, Oct 3 2017

Labels: Hotlist-Polish
Status: Available (was: Untriaged)

Comment 4 by scheib@chromium.org, Jan 9 2018

Cc: -scheib@chromium.org

Comment 5 by robliao@chromium.org, Sep 13

Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
►

Sign in to add a comment