New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651290 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Make gfx::GpuMemoryBufferHandle a move-only type

Project Member Reported by sadrul@chromium.org, Sep 29 2016

Issue description

gfx::GpuMemoryBufferHandle owns gfx::NativePixmapHandle, which, in ozone, holds a list of base::FileDescriptor objects. Serializing base::FileDescriptor for mojo is a little bit tricky, since the serialization code runs twice; and it is necessary to ensure (by way of having a SetUpContext for the struct-traits) that the serialization happens just once.

It may be possible to have NativePixmapHandle use ScopedFD instead to retain ownership of the fds. But then, it would be necessary to make NativePixmapHandle, GpuMemoryBufferHandle etc. be move-only types.
 
How does mojo handle this in the case of base::SharedMemoryHandle?

Comment 2 by enne@chromium.org, Jan 25 2017

Components: -Internals>Graphics Internals>GPU
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by piman@chromium.org, Feb 26 2018

Components: -Internals>GPU Internals>GPU>Internals
Labels: -Type-Bug -Hotlist-Recharge-Cold Type-Task
Status: Available (was: Untriaged)
Are we still considering this?
Labels: -Proj-Mustash-Mus-GPU
Cleaning up old Proj-Mustash labels.

Sign in to add a comment