New issue
Advanced search Search tips

Issue 651289 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"CheckWebApkCompatibility/AddToHomescreenDataFetcherTestCommon.ManifestShortNameClobbersWebApplicationName/0" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 29 2016

Issue description

"CheckWebApkCompatibility/AddToHomescreenDataFetcherTestCommon.ManifestShortNameClobbersWebApplicationName/0" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNydgsSBUZsYWtlImtDaGVja1dlYkFwa0NvbXBhdGliaWxpdHkvQWRkVG9Ib21lc2NyZWVuRGF0YUZldGNoZXJUZXN0Q29tbW9uLk1hbmlmZXN0U2hvcnROYW1lQ2xvYmJlcnNXZWJBcHBsaWNhdGlvbk5hbWUvMAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 Deleted

This test was added recently, so created a revert : https://codereview.chromium.org/2385843002/
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a320b1c806c52f388c68ebe69864d2f211d688f8

commit a320b1c806c52f388c68ebe69864d2f211d688f8
Author: jaydasika <jaydasika@chromium.org>
Date: Fri Sep 30 19:08:20 2016

Revert of Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages (patchset #2 id:40001 of https://codereview.chromium.org/2362813003/ )

Reason for revert:
"CheckWebApkCompatibility/AddToHomescreenDataFetcherTestCommon.ManifestShortNameClobbersWebApplicationName/0" is flaky on android_n5x_swarming_rel

Original issue's description:
> Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages
>
> This CL:
> - Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
>   is ignored for WebAPK compatible pages.
> - Adds tests checking that WebApplicationInfo is ignored
>
> BUG= 638468 
>
> Committed: https://crrev.com/0749dfd34ea2aba53f29bb83c0d19d2ea825b6f9
> Cr-Commit-Position: refs/heads/master@{#421531}

TBR=hanxi@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 638468 ,  651289 

Review-Url: https://codereview.chromium.org/2385843002
Cr-Commit-Position: refs/heads/master@{#422170}

[modify] https://crrev.com/a320b1c806c52f388c68ebe69864d2f211d688f8/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/a320b1c806c52f388c68ebe69864d2f211d688f8/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a320b1c806c52f388c68ebe69864d2f211d688f8

commit a320b1c806c52f388c68ebe69864d2f211d688f8
Author: jaydasika <jaydasika@chromium.org>
Date: Fri Sep 30 19:08:20 2016

Revert of Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages (patchset #2 id:40001 of https://codereview.chromium.org/2362813003/ )

Reason for revert:
"CheckWebApkCompatibility/AddToHomescreenDataFetcherTestCommon.ManifestShortNameClobbersWebApplicationName/0" is flaky on android_n5x_swarming_rel

Original issue's description:
> Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages
>
> This CL:
> - Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
>   is ignored for WebAPK compatible pages.
> - Adds tests checking that WebApplicationInfo is ignored
>
> BUG= 638468 
>
> Committed: https://crrev.com/0749dfd34ea2aba53f29bb83c0d19d2ea825b6f9
> Cr-Commit-Position: refs/heads/master@{#421531}

TBR=hanxi@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 638468 ,  651289 

Review-Url: https://codereview.chromium.org/2385843002
Cr-Commit-Position: refs/heads/master@{#422170}

[modify] https://crrev.com/a320b1c806c52f388c68ebe69864d2f211d688f8/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/a320b1c806c52f388c68ebe69864d2f211d688f8/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a320b1c806c52f388c68ebe69864d2f211d688f8

commit a320b1c806c52f388c68ebe69864d2f211d688f8
Author: jaydasika <jaydasika@chromium.org>
Date: Fri Sep 30 19:08:20 2016

Revert of Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages (patchset #2 id:40001 of https://codereview.chromium.org/2362813003/ )

Reason for revert:
"CheckWebApkCompatibility/AddToHomescreenDataFetcherTestCommon.ManifestShortNameClobbersWebApplicationName/0" is flaky on android_n5x_swarming_rel

Original issue's description:
> Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPK compatible pages
>
> This CL:
> - Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
>   is ignored for WebAPK compatible pages.
> - Adds tests checking that WebApplicationInfo is ignored
>
> BUG= 638468 
>
> Committed: https://crrev.com/0749dfd34ea2aba53f29bb83c0d19d2ea825b6f9
> Cr-Commit-Position: refs/heads/master@{#421531}

TBR=hanxi@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 638468 ,  651289 

Review-Url: https://codereview.chromium.org/2385843002
Cr-Commit-Position: refs/heads/master@{#422170}

[modify] https://crrev.com/a320b1c806c52f388c68ebe69864d2f211d688f8/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/a320b1c806c52f388c68ebe69864d2f211d688f8/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

Components: Mobile>WebAPKs
This seems to have to do with

@@@STEP_LOG_LINE@CheckWebApkCompatibility_AddToHomescreenDataFetcherTestCommon.ManifestNoNameNoShortName_1@[ RUN      ] CheckWebApkCompatibility/AddToHomescreenDataFetcherTestCommon.ManifestNoNameNoShortName/1@@@
@@@STEP_LOG_LINE@CheckWebApkCompatibility_AddToHomescreenDataFetcherTestCommon.ManifestNoNameNoShortName_1@[FATAL:mojo_shell_connection_impl.cc(86)] Check failed: posted.@@@

My initial thought is that it has to do with another test which has a bad interaction with this test (I can't reproduce the failure locally yet)

Comment 7 by horo@chromium.org, Oct 4 2016

 Issue 651422  has been merged into this issue.

Comment 8 by horo@chromium.org, Oct 4 2016

 Issue 651819  has been merged into this issue.

Comment 9 by horo@chromium.org, Oct 5 2016

Labels: -Sheriff-Chromium
Status: Fixed (was: Available)
Owner: pkotw...@chromium.org
Status: Assigned (was: Fixed)
Blocking: 629181
Blocking: -629181
Labels: OS-Android
I'm not sure why I marked this as blocking. Unmarking, holler if it should be.
Status: Fixed (was: Assigned)
Test was relanded as part of https://codereview.chromium.org/2387613003 Marking this bug as fixed

Sign in to add a comment