New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651282 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 10
Cc:
█ mbrunson@chromium.org
█ ortuno@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on: View detail
issue 658814
issue 663394
issue 666561
issue 691484
issue 663470
issue 663830
issue 667970
issue 682856
issue 686623
issue 686642
issue 704549
issue 707530
Blocking:
issue 419413
issue 519010



Sign in to add a comment

Create Bluetooth Internals page

Project Member Reported by mbrunson@chromium.org, Sep 29 2016 
Add a diagnostic tool as a chrome://bluetooth-internals page to enable Chrome and Web developers to understand Bluetooth related status of the system.

We'd like to build a page that displays all known Bluetooth state, as well as a log of recent events (e.g. recently received radio messages, connection / disconnection evets, scanning enabled, etc).

Design Document:
https://docs.google.com/document/d/1wa96bCrB2Iw7tTI-fWsKmhLB7_ffF12frGIjRvhaj9E
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d636b382748085cbdc8bac78cab86f4a9f094b8

commit 3d636b382748085cbdc8bac78cab86f4a9f094b8
Author: beaufort.francois <beaufort.francois@gmail.com>
Date: Fri Sep 30 07:50:24 2016

bluetooth: Add chrome://bluetooth-internals to chrome://chrome-urls

BUG= 651282 

Review-Url: https://codereview.chromium.org/2379883003
Cr-Commit-Position: refs/heads/master@{#422060}

[modify] https://crrev.com/3d636b382748085cbdc8bac78cab86f4a9f094b8/chrome/common/url_constants.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e619ab633a89f1c845f5fdd7584344a5914b30a9

commit e619ab633a89f1c845f5fdd7584344a5914b30a9
Author: mbrunson <mbrunson@chromium.org>
Date: Mon Oct 03 22:34:10 2016

bluetooth: Add device list retrieval for chrome://bluetooth-internals

Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page.
Adds mojom files for Bluetooth service definition and internals page handler.
Adds basic Bluetooth device retrieval using starter Bluetooth service
implementation for logging on web front end.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG= 651282 

Review-Url: https://codereview.chromium.org/2357383002
Cr-Commit-Position: refs/heads/master@{#422570}

[modify] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/chrome/browser/BUILD.gn
[modify] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/chrome/browser/browser_resources.grd
[modify] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/device/bluetooth/BUILD.gn
[add] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/device/bluetooth/adapter.cc
[add] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/device/bluetooth/adapter.h
[modify] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/device/bluetooth/public/interfaces/BUILD.gn
[add] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/device/bluetooth/public/interfaces/adapter.mojom
[modify] https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9/third_party/WebKit/public/BUILD.gn
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/378f20e5539db10e70f129ea9edf25acb22144ff

commit 378f20e5539db10e70f129ea9edf25acb22144ff
Author: horo <horo@chromium.org>
Date: Mon Oct 03 23:40:01 2016

Revert of bluetooth: Add device list retrieval for chrome://bluetooth-internals (patchset #16 id:280001 of https://codereview.chromium.org/2357383002/ )

Reason for revert:
generate_build_files failing on chromium.chrome/Google Chrome Win

BUG= 652494 

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:27:7: Dependency not allowed.
      static_library(current_name) {
      ^-----------------------------
The item //chrome/browser/ui:ui_0
can not depend on //device/bluetooth/public/interfaces:experimental_interfaces
because it is not in //device/bluetooth/public/interfaces:experimental_interfaces's visibility list: [
  //device/bluetooth:mojo
  //chrome/browser:browser
  //chrome/browser/ui:ui
]

GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

Original issue's description:
> bluetooth: Add device list retrieval for chrome://bluetooth-internals
>
> Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page.
> Adds mojom files for Bluetooth service definition and internals page handler.
> Adds basic Bluetooth device retrieval using starter Bluetooth service
> implementation for logging on web front end.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> BUG= 651282 
>
> Committed: https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9
> Cr-Commit-Position: refs/heads/master@{#422570}

TBR=dpapad@chromium.org,dcheng@chromium.org,ortuno@chromium.org,scheib@chromium.org,mbrunson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 651282 

Review-Url: https://codereview.chromium.org/2389053002
Cr-Commit-Position: refs/heads/master@{#422601}

[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/BUILD.gn
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/browser_resources.grd
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/device/bluetooth/BUILD.gn
[delete] https://crrev.com/84d65719f2ba3204b4c233a4ab0c4a2afdd8db51/device/bluetooth/adapter.cc
[delete] https://crrev.com/84d65719f2ba3204b4c233a4ab0c4a2afdd8db51/device/bluetooth/adapter.h
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/device/bluetooth/public/interfaces/BUILD.gn
[delete] https://crrev.com/84d65719f2ba3204b4c233a4ab0c4a2afdd8db51/device/bluetooth/public/interfaces/adapter.mojom
[modify] https://crrev.com/378f20e5539db10e70f129ea9edf25acb22144ff/third_party/WebKit/public/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70d50e7a3e3289bfce518ae91a85759b40469642

commit 70d50e7a3e3289bfce518ae91a85759b40469642
Author: mbrunson <mbrunson@chromium.org>
Date: Tue Oct 04 17:52:06 2016

bluetooth: Add device list retrieval for chrome://bluetooth-internals

Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page.
Adds mojom files for Bluetooth service definition and internals page handler.
Adds basic Bluetooth device retrieval using starter Bluetooth service
implementation for logging on web front end.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG= 651282 

Committed: https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9
Review-Url: https://codereview.chromium.org/2357383002
Cr-Original-Commit-Position: refs/heads/master@{#422570}
Cr-Commit-Position: refs/heads/master@{#422855}

[modify] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/chrome/browser/BUILD.gn
[modify] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/chrome/browser/browser_resources.grd
[modify] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/device/bluetooth/BUILD.gn
[add] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/device/bluetooth/adapter.cc
[add] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/device/bluetooth/adapter.h
[modify] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/device/bluetooth/public/interfaces/BUILD.gn
[add] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/device/bluetooth/public/interfaces/adapter.mojom
[modify] https://crrev.com/70d50e7a3e3289bfce518ae91a85759b40469642/third_party/WebKit/public/BUILD.gn
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bd80fe58ce9c15bfd896cb902727e1066edbc2c

commit 8bd80fe58ce9c15bfd896cb902727e1066edbc2c
Author: mbrunson <mbrunson@chromium.org>
Date: Thu Oct 06 23:23:04 2016

bluetooth: Standardize Bluetooth adapter access in Adapter service.

Every implemented function of the Adapter Mojo service requires a
reference to the system's Bluetooth adapter. Since any function could be called
at any time in the service, the adapter must be available from the creation of
the Adapter service. To satisfy this requirement, a factory pattern has been
implemented to create instances of the Adapter service with the required
reference to a Bluetooth adapter.
BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2379573006
Cr-Commit-Position: refs/heads/master@{#423730}

[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/BUILD.gn
[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/adapter.cc
[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/adapter.h
[add] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/adapter_factory.cc
[add] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/adapter_factory.h
[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/public/interfaces/adapter.mojom
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68edb718679b840bcac21d56febc5b76e338fe65

commit 68edb718679b840bcac21d56febc5b76e338fe65
Author: mbrunson <mbrunson@chromium.org>
Date: Fri Oct 07 19:42:13 2016

bluetooth: Add AdapterInfo in Bluetooth adapter service.

Adds getter for basic information about the state of the
system's Bluetooth adapter including:
  + Address
  + Name
  + Initialization state
  + Presence
  + Power state
  + Discovering state
  + Discoverable state

This information is logged in the browser console once it's
retrieved in JS.

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2388533003
Cr-Commit-Position: refs/heads/master@{#423936}

[modify] https://crrev.com/68edb718679b840bcac21d56febc5b76e338fe65/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/68edb718679b840bcac21d56febc5b76e338fe65/device/bluetooth/adapter.cc
[modify] https://crrev.com/68edb718679b840bcac21d56febc5b76e338fe65/device/bluetooth/adapter.h
[modify] https://crrev.com/68edb718679b840bcac21d56febc5b76e338fe65/device/bluetooth/public/interfaces/adapter.mojom
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22ff37419618d39c8ff220108a935d3d8762a4f5

commit 22ff37419618d39c8ff220108a935d3d8762a4f5
Author: mbrunson <mbrunson@chromium.org>
Date: Thu Oct 13 18:04:33 2016

bluetooth: Add Device service for chrome://bluetooth-internals.

Moves DeviceInfo struct to device.mojom and creates interface for Device.
Adds starter code for Device implementation for the Bluetooth Mojo service.
Adds GetDevice to the Adapter service to create Device interfaces.
Adds console logging for DeviceInfo on chrome://bluetooth-internals page.

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2401193002
Cr-Commit-Position: refs/heads/master@{#425085}

[modify] https://crrev.com/22ff37419618d39c8ff220108a935d3d8762a4f5/chrome/browser/browser_resources.grd
[modify] https://crrev.com/22ff37419618d39c8ff220108a935d3d8762a4f5/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/22ff37419618d39c8ff220108a935d3d8762a4f5/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/22ff37419618d39c8ff220108a935d3d8762a4f5/device/bluetooth/BUILD.gn
[modify] https://crrev.com/22ff37419618d39c8ff220108a935d3d8762a4f5/device/bluetooth/adapter.cc
[modify] https://crrev.com/22ff37419618d39c8ff220108a935d3d8762a4f5/device/bluetooth/adapter.h
[add] https://crrev.com/22ff37419618d39c8ff220108a935d3d8762a4f5/device/bluetooth/device.cc
[add] https://crrev.com/22ff37419618d39c8ff220108a935d3d8762a4f5/device/bluetooth/device.h
[modify] https://crrev.com/22ff37419618d39c8ff220108a935d3d8762a4f5/device/bluetooth/public/interfaces/BUILD.gn
[modify] https://crrev.com/22ff37419618d39c8ff220108a935d3d8762a4f5/device/bluetooth/public/interfaces/adapter.mojom
[add] https://crrev.com/22ff37419618d39c8ff220108a935d3d8762a4f5/device/bluetooth/public/interfaces/device.mojom

Comment 8 by scheib@chromium.org, Oct 15 2016

Blocking: 419413

Comment 9 by jyasskin@chromium.org, Oct 17 2016

Blocking: 519010

Comment 10 by mbrunson@chromium.org, Oct 24 2016

Blockedon: 658814
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb0336053e2673a5714326520bcde9269ca0f823

commit eb0336053e2673a5714326520bcde9269ca0f823
Author: mbrunson <mbrunson@chromium.org>
Date: Tue Oct 25 03:14:49 2016

bluetooth: Add device list UI for chrome://bluetooth-internals.

Adds mobile responsive device list to bluetooth internals page.
Lists device name, address, and latest RSSI.
Refreshes when devices are discovered, removed, or advertising packets are received.

Screenshots
Desktop: https://goo.gl/photos/bot7JsdTuf8P2A328
Mobile: https://goo.gl/photos/G9bb9s4ih5KT3PJw8

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2418343002
Cr-Commit-Position: refs/heads/master@{#427261}

[modify] https://crrev.com/eb0336053e2673a5714326520bcde9269ca0f823/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css
[modify] https://crrev.com/eb0336053e2673a5714326520bcde9269ca0f823/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/eb0336053e2673a5714326520bcde9269ca0f823/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bd80fe58ce9c15bfd896cb902727e1066edbc2c

commit 8bd80fe58ce9c15bfd896cb902727e1066edbc2c
Author: mbrunson <mbrunson@chromium.org>
Date: Thu Oct 06 23:23:04 2016

bluetooth: Standardize Bluetooth adapter access in Adapter service.

Every implemented function of the Adapter Mojo service requires a
reference to the system's Bluetooth adapter. Since any function could be called
at any time in the service, the adapter must be available from the creation of
the Adapter service. To satisfy this requirement, a factory pattern has been
implemented to create instances of the Adapter service with the required
reference to a Bluetooth adapter.
BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2379573006
Cr-Commit-Position: refs/heads/master@{#423730}

[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/BUILD.gn
[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/adapter.cc
[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/adapter.h
[add] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/adapter_factory.cc
[add] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/adapter_factory.h
[modify] https://crrev.com/8bd80fe58ce9c15bfd896cb902727e1066edbc2c/device/bluetooth/public/interfaces/adapter.mojom

Comment 14 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5d3edafbb53f7af22875e0c274d75bc1d84b430

commit d5d3edafbb53f7af22875e0c274d75bc1d84b430
Author: mbrunson <mbrunson@chromium.org>
Date: Tue Nov 08 01:15:23 2016

bluetooth: Componentize device list in chrome://bluetooth-internals.

Separates device list HTML management code from device handling code.
Adds DeviceTable for management of device table UI.
Adds observable DeviceCollection for dynamic updates of DeviceTable.
Adds AdapterBroker to handle adapter events and simplifier Adapter
  service communication.

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2446823002
Cr-Commit-Position: refs/heads/master@{#430458}

[modify] https://crrev.com/d5d3edafbb53f7af22875e0c274d75bc1d84b430/chrome/browser/browser_resources.grd
[add] https://crrev.com/d5d3edafbb53f7af22875e0c274d75bc1d84b430/chrome/browser/resources/bluetooth_internals/adapter_broker.js
[modify] https://crrev.com/d5d3edafbb53f7af22875e0c274d75bc1d84b430/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/d5d3edafbb53f7af22875e0c274d75bc1d84b430/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[add] https://crrev.com/d5d3edafbb53f7af22875e0c274d75bc1d84b430/chrome/browser/resources/bluetooth_internals/device_collection.js
[add] https://crrev.com/d5d3edafbb53f7af22875e0c274d75bc1d84b430/chrome/browser/resources/bluetooth_internals/device_table.js
[add] https://crrev.com/d5d3edafbb53f7af22875e0c274d75bc1d84b430/chrome/browser/resources/bluetooth_internals/interfaces.js
[modify] https://crrev.com/d5d3edafbb53f7af22875e0c274d75bc1d84b430/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc

Comment 16 by mbrunson@chromium.org, Nov 8 2016

Blockedon: 663394

Comment 17 by mbrunson@chromium.org, Nov 8 2016

Blockedon: 663470

Comment 18 by mbrunson@chromium.org, Nov 9 2016

Blockedon: 663830
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d16c52cc047907ba252ef8ea0d09dcec78e1a377

commit d16c52cc047907ba252ef8ea0d09dcec78e1a377
Author: mbrunson <mbrunson@chromium.org>
Date: Fri Nov 11 23:17:00 2016

bluetooth: Componentize device list fixes

Fixes for componentization of device list introduced in issue:
https://codereview.chromium.org/2446823002/

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2488093003
Cr-Commit-Position: refs/heads/master@{#431681}

[modify] https://crrev.com/d16c52cc047907ba252ef8ea0d09dcec78e1a377/chrome/browser/resources/bluetooth_internals/adapter_broker.js
[modify] https://crrev.com/d16c52cc047907ba252ef8ea0d09dcec78e1a377/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/d16c52cc047907ba252ef8ea0d09dcec78e1a377/chrome/browser/resources/bluetooth_internals/device_table.js
[modify] https://crrev.com/d16c52cc047907ba252ef8ea0d09dcec78e1a377/chrome/browser/resources/bluetooth_internals/interfaces.js
[modify] https://crrev.com/d16c52cc047907ba252ef8ea0d09dcec78e1a377/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[add] https://crrev.com/d16c52cc047907ba252ef8ea0d09dcec78e1a377/ui/webui/resources/html/cr/ui/array_data_model.html
[modify] https://crrev.com/d16c52cc047907ba252ef8ea0d09dcec78e1a377/ui/webui/resources/webui_resources.grd

Comment 20 by scheib@chromium.org, Nov 17 2016

Description: Show this description

Comment 21 by mbrunson@chromium.org, Nov 18 2016

Blockedon: 666561
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32391c11bdd0921e21331620fedf513b89a6a48d

commit 32391c11bdd0921e21331620fedf513b89a6a48d
Author: mbrunson <mbrunson@chromium.org>
Date: Fri Nov 18 23:42:15 2016

bluetooth: Add Device connection logic and accompanying user interface.

Changes Device interface to require a BluetoothGattConnection and Device
  interface request.
Binds lifetime of Device to lifetime of BluetoothGattConnection and message
  pipe.
Changes GetDevice function to ConnectToDevice.
Adds ConnectError codes for device connections.
Adds GetServices function to Device to list discovered services.
Adds associated user interface components for connecting to a listed device.

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2448713002
Cr-Commit-Position: refs/heads/master@{#433332}

[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/chrome/browser/browser_resources.grd
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/chrome/browser/resources/bluetooth_internals/adapter_broker.js
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/chrome/browser/resources/bluetooth_internals/device_collection.js
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/chrome/browser/resources/bluetooth_internals/device_table.js
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/BUILD.gn
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/bluetooth/BUILD.gn
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/bluetooth/adapter.cc
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/bluetooth/adapter.h
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/bluetooth/device.cc
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/bluetooth/device.h
[add] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/bluetooth/device_unittest.cc
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/bluetooth/public/interfaces/BUILD.gn
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/bluetooth/public/interfaces/OWNERS
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/bluetooth/public/interfaces/adapter.mojom
[add] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/bluetooth/public/interfaces/connect_result_type_converter.h
[modify] https://crrev.com/32391c11bdd0921e21331620fedf513b89a6a48d/device/bluetooth/public/interfaces/device.mojom
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a392852b8e9c6856f99fbcfcd8515246eca7cbb

commit 4a392852b8e9c6856f99fbcfcd8515246eca7cbb
Author: mbrunson <mbrunson@chromium.org>
Date: Sat Nov 19 01:08:29 2016

bluetooth: Basic browser tests for chrome://bluetooth-internals.

UI tests of device management chrome://bluetooth-internals page
  including device creation, device changes, and device removal.

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2428773005
Cr-Commit-Position: refs/heads/master@{#433365}

[modify] https://crrev.com/4a392852b8e9c6856f99fbcfcd8515246eca7cbb/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/4a392852b8e9c6856f99fbcfcd8515246eca7cbb/chrome/browser/resources/bluetooth_internals/interfaces.js
[modify] https://crrev.com/4a392852b8e9c6856f99fbcfcd8515246eca7cbb/chrome/test/BUILD.gn
[add] https://crrev.com/4a392852b8e9c6856f99fbcfcd8515246eca7cbb/chrome/test/data/webui/bluetooth_internals_browsertest.js

Comment 24 by mbrunson@chromium.org, Dec 7 2016

Blockedon: 667970
Project Member

Comment 25 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e

commit d316a0b2e72525b938de1bdc9d74ef5b6c3df00e
Author: mbrunson <mbrunson@chromium.org>
Date: Fri Dec 09 04:02:37 2016

bluetooth: Add sidebar and page manager for chrome://bluetooth-internals.

Adds Sidebar control to chrome://bluetooth-internals.
Adds PageManager to manage view switching.
Adds DevicesPage wrapper around DeviceTable for paging.
Changes style to user-facing WebUI standard.

Screenshots: https://goo.gl/photos/EKWMtQ2DBfF3m9WC8

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2538653002
Cr-Commit-Position: refs/heads/master@{#437459}

[modify] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/chrome/browser/browser_resources.grd
[modify] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css
[modify] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/chrome/browser/resources/bluetooth_internals/device_table.js
[add] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/chrome/browser/resources/bluetooth_internals/devices_page.js
[add] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/chrome/browser/resources/bluetooth_internals/sidebar.js
[modify] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[add] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/ui/webui/resources/html/cr/ui/page_manager/page.html
[add] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/ui/webui/resources/html/cr/ui/page_manager/page_manager.html
[add] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/ui/webui/resources/images/menu.svg
[modify] https://crrev.com/d316a0b2e72525b938de1bdc9d74ef5b6c3df00e/ui/webui/resources/webui_resources.grd
Project Member

Comment 26 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7af445f71d1af6b6be39a5f59c1def3ac113b3d0

commit 7af445f71d1af6b6be39a5f59c1def3ac113b3d0
Author: mbrunson <mbrunson@chromium.org>
Date: Fri Dec 09 20:24:20 2016

bluetooth: Replace buttons in device table with action links.

When a large number of rows are present in the device table, scrolling
performance drops considerably. This is due to the table recalculating its size
due to button elements being in each row of the table.

Replaces buttons in device table with action links to speed up rendering of the
device table.

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2558493004
Cr-Commit-Position: refs/heads/master@{#437620}

[modify] https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/7af445f71d1af6b6be39a5f59c1def3ac113b3d0/chrome/browser/resources/bluetooth_internals/device_table.js

Comment 27 by mbrunson@chromium.org, Dec 9 2016

Status: Started (was: Assigned)
Project Member

Comment 28 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fd69ebdedf3d71f082fbbb8ac0ef9fbabea9052

commit 6fd69ebdedf3d71f082fbbb8ac0ef9fbabea9052
Author: mbrunson <mbrunson@chromium.org>
Date: Wed Dec 14 04:17:59 2016

bluetooth: Add tests for Sidebar in bluetooth internals browser test suite.

Adds two tests for sidebar setup and open/close functionality.

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2563113002
Cr-Commit-Position: refs/heads/master@{#438428}

[modify] https://crrev.com/6fd69ebdedf3d71f082fbbb8ac0ef9fbabea9052/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/6fd69ebdedf3d71f082fbbb8ac0ef9fbabea9052/chrome/test/data/webui/bluetooth_internals_browsertest.js
Project Member

Comment 29 by bugdroid1@chromium.org, Jan 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa7637300e305fc861b257729e88da3cde2feaf1

commit fa7637300e305fc861b257729e88da3cde2feaf1
Author: mbrunson <mbrunson@chromium.org>
Date: Sat Jan 07 00:52:58 2017

bluetooth: Update internals page browser test fixture.

With the change in the Mojo binding system, the existing test fixture is overly
complex. A layer of indirection can be removed now that Mojo connections can be
created with arbitrary JavaScript classes.

This patch removes the TestAdapter class from bluetooth internals browser test
and directly binds the TestAdapterProxy directly to an Adapter interface.

BUG= 651282 

Review-Url: https://codereview.chromium.org/2620583002
Cr-Commit-Position: refs/heads/master@{#442116}

[modify] https://crrev.com/fa7637300e305fc861b257729e88da3cde2feaf1/chrome/test/data/webui/bluetooth_internals_browsertest.js
Project Member

Comment 30 by bugdroid1@chromium.org, Jan 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6

commit b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6
Author: mbrunson <mbrunson@chromium.org>
Date: Sat Jan 07 02:56:42 2017

bluetooth: Add basic scanning to chrome://bluetooth-internals.

Adds DiscoverySession to Adapter Mojo service to handle starting a new BluetoothDiscoverySession.
Adds Adapter::StartDiscoverySession to create a new DiscoverySession.
Adds Scan button to chrome://bluetooth-internals to activate scanning.

GIF: https://goo.gl/photos/9B14sgpGNiRqeoxk6

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2564113003
Cr-Commit-Position: refs/heads/master@{#442141}

[modify] https://crrev.com/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6/chrome/browser/resources/bluetooth_internals/adapter_broker.js
[modify] https://crrev.com/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css
[modify] https://crrev.com/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6/chrome/browser/resources/bluetooth_internals/devices_page.js
[modify] https://crrev.com/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6/device/bluetooth/BUILD.gn
[modify] https://crrev.com/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6/device/bluetooth/adapter.cc
[modify] https://crrev.com/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6/device/bluetooth/adapter.h
[add] https://crrev.com/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6/device/bluetooth/discovery_session.cc
[add] https://crrev.com/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6/device/bluetooth/discovery_session.h
[modify] https://crrev.com/b0f0a102a61ef7682e4aac5d5587e36ac6f6b3d6/device/bluetooth/public/interfaces/adapter.mojom
Project Member

Comment 31 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac

commit e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac
Author: mbrunson <mbrunson@chromium.org>
Date: Thu Jan 12 00:00:45 2017

bluetooth: Add adapter page to internals page.

Adds BluetoothAdapter::Observer callbacks to Adapter implementation
for tracking changes in Adapter state including:
  AdapterDiscoverableChanged
  AdapterPoweredChanged
  AdapterPresentChanged

Adds adapter page to display details about the current state of the adapter.
Adds ObjectFieldSet interface component for displaying properties of a JavaScript object.

Screenshot: https://goo.gl/photos/dCbsULiydMbiAtiJ9

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2567983007
Cr-Commit-Position: refs/heads/master@{#443065}

[modify] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/chrome/browser/browser_resources.grd
[modify] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/chrome/browser/resources/bluetooth_internals/adapter_broker.js
[add] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/chrome/browser/resources/bluetooth_internals/adapter_page.js
[modify] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css
[modify] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[add] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/chrome/browser/resources/bluetooth_internals/object_fieldset.js
[modify] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/chrome/test/data/webui/bluetooth_internals_browsertest.js
[modify] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/device/bluetooth/adapter.cc
[modify] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/device/bluetooth/adapter.h
[modify] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/device/bluetooth/discovery_session.h
[modify] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/device/bluetooth/public/interfaces/adapter.mojom
[add] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/ui/webui/resources/images/cancel_red.svg
[add] https://crrev.com/e8e6d1fccf2d905f5313dde6f8a06706b19dc6ac/ui/webui/resources/images/check_circle_green.svg
Project Member

Comment 32 by bugdroid1@chromium.org, Jan 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feda9ca742d2220f0da0d81e17f51a4917375405

commit feda9ca742d2220f0da0d81e17f51a4917375405
Author: mbrunson <mbrunson@chromium.org>
Date: Fri Jan 13 02:15:20 2017

bluetooth: Add device details page with basic properties to internals page.

Adds DeviceDetailsPage to internals page so users can view all the properties
of the DeviceInfo object. No display of service properties is included in this
patch.

Splits action link in Devices table into two separate links: "Inspect"
and "Forget".
Adds functions to add and remove items from the sidebar.
Adds test infrastructure for Device proxy-based tests.
Adds test for DeviceDetailsPage.
Adds unregister function to PageManager.

GIFs: https://goo.gl/photos/zLiv86gyYmQhRn9w8

BUG= 651282 , 663470 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2576603002
Cr-Commit-Position: refs/heads/master@{#443465}

[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/browser_resources.grd
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/device_collection.js
[add] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/device_details_page.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/device_table.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/devices_page.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/resources/bluetooth_internals/sidebar.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/chrome/test/data/webui/bluetooth_internals_browsertest.js
[modify] https://crrev.com/feda9ca742d2220f0da0d81e17f51a4917375405/ui/webui/resources/js/cr/ui/page_manager/page_manager.js
Project Member

Comment 33 by bugdroid1@chromium.org, Jan 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae05be6e566364f83f864fcf8a941d04b4cd768c

commit ae05be6e566364f83f864fcf8a941d04b4cd768c
Author: mbrunson <mbrunson@chromium.org>
Date: Sat Jan 14 03:58:54 2017

bluetooth: Add service list to DeviceDetailsPage in internals page.

Adds service list to DeviceDetailsPage and creates the structure for displaying
hierachical data using collapsible panels.
Adds id property to ServiceInfo for display in service list.
Adds expandable list control for collapsible tree view of service list items.

GIF: https://goo.gl/photos/rqnDxZYmx1TDnBJ26

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2617923002
Cr-Commit-Position: refs/heads/master@{#443782}

[modify] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/chrome/browser/browser_resources.grd
[modify] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css
[modify] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/chrome/browser/resources/bluetooth_internals/device_details_page.js
[add] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/chrome/browser/resources/bluetooth_internals/expandable_list.js
[add] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/chrome/browser/resources/bluetooth_internals/service_list.js
[modify] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/device/bluetooth/device.cc
[modify] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/device/bluetooth/public/interfaces/device.mojom
[add] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/ui/webui/resources/html/cr/ui/list.html
[add] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/ui/webui/resources/html/cr/ui/list_item.html
[add] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/ui/webui/resources/html/cr/ui/list_selection_controller.html
[add] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/ui/webui/resources/html/cr/ui/list_selection_model.html
[modify] https://crrev.com/ae05be6e566364f83f864fcf8a941d04b4cd768c/ui/webui/resources/webui_resources.grd

Comment 34 by scheib@chromium.org, Jan 19 2017

Blockedon: 682856
Project Member

Comment 35 by bugdroid1@chromium.org, Jan 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721

commit 7da9cd89d4d18e171323ff7d0d2a93ede0c1d721
Author: mbrunson <mbrunson@chromium.org>
Date: Fri Jan 20 00:42:10 2017

bluetooth: Add characteristic list to DeviceDetailsPage in internals page.

Adds characteristic list to DeviceDetailsPage under service list items.
Sets up event handling pattern from hierachical controls.

Screenshots: https://goo.gl/photos/iqPrF6uWxV4nysHw9

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2622393002
Cr-Commit-Position: refs/heads/master@{#444890}

[modify] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/chrome/browser/browser_resources.grd
[modify] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[add] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/chrome/browser/resources/bluetooth_internals/characteristic_list.js
[add] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/chrome/browser/resources/bluetooth_internals/device_broker.js
[modify] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/chrome/browser/resources/bluetooth_internals/device_details_page.js
[modify] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/chrome/browser/resources/bluetooth_internals/expandable_list.js
[modify] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/chrome/browser/resources/bluetooth_internals/service_list.js
[modify] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/chrome/test/data/webui/bluetooth_internals_browsertest.js
[modify] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/device/bluetooth/device.cc
[modify] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/device/bluetooth/device.h
[modify] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/device/bluetooth/device_unittest.cc
[modify] https://crrev.com/7da9cd89d4d18e171323ff7d0d2a93ede0c1d721/device/bluetooth/public/interfaces/device.mojom
Project Member

Comment 36 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb0f962b804ccacb423cb76a5a50505b4de6294a

commit bb0f962b804ccacb423cb76a5a50505b4de6294a
Author: mbrunson <mbrunson@chromium.org>
Date: Tue Jan 24 04:26:57 2017

bluetooth: Remove queuing of GetCharacteristicsCallbacks

Changes GetCharacteristics message implementation in Device to process
    calls immediately without queuing.
Changes return value of GetCharacteristics to an optional array.

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2643393002
Cr-Commit-Position: refs/heads/master@{#445641}

[modify] https://crrev.com/bb0f962b804ccacb423cb76a5a50505b4de6294a/chrome/browser/resources/bluetooth_internals/characteristic_list.js
[modify] https://crrev.com/bb0f962b804ccacb423cb76a5a50505b4de6294a/device/bluetooth/device.cc
[modify] https://crrev.com/bb0f962b804ccacb423cb76a5a50505b4de6294a/device/bluetooth/device.h
[modify] https://crrev.com/bb0f962b804ccacb423cb76a5a50505b4de6294a/device/bluetooth/device_unittest.cc
[modify] https://crrev.com/bb0f962b804ccacb423cb76a5a50505b4de6294a/device/bluetooth/public/interfaces/device.mojom
Project Member

Comment 37 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/114e4a2cdc28928c83a898d3b73e7c30dad437a1

commit 114e4a2cdc28928c83a898d3b73e7c30dad437a1
Author: mbrunson <mbrunson@chromium.org>
Date: Wed Jan 25 04:40:33 2017

bluetooth: Add descriptor list to DeviceDetailsPage on internals page.

Adds descriptor list to DeviceDetailsPage for displaying basic descriptor info
    for each characteristic.
Adds GetDescriptors message to Device interface.
Adds DescriptorInfo struct to wrap id and uuid of descriptor objects.

Screenshots: https://goo.gl/photos/vqSRubWag2P8iMzm7

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2640073004
Cr-Commit-Position: refs/heads/master@{#445947}

[modify] https://crrev.com/114e4a2cdc28928c83a898d3b73e7c30dad437a1/chrome/browser/browser_resources.grd
[modify] https://crrev.com/114e4a2cdc28928c83a898d3b73e7c30dad437a1/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/114e4a2cdc28928c83a898d3b73e7c30dad437a1/chrome/browser/resources/bluetooth_internals/characteristic_list.js
[add] https://crrev.com/114e4a2cdc28928c83a898d3b73e7c30dad437a1/chrome/browser/resources/bluetooth_internals/descriptor_list.js
[modify] https://crrev.com/114e4a2cdc28928c83a898d3b73e7c30dad437a1/chrome/browser/resources/bluetooth_internals/expandable_list.js
[modify] https://crrev.com/114e4a2cdc28928c83a898d3b73e7c30dad437a1/chrome/browser/resources/bluetooth_internals/service_list.js
[modify] https://crrev.com/114e4a2cdc28928c83a898d3b73e7c30dad437a1/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/114e4a2cdc28928c83a898d3b73e7c30dad437a1/device/bluetooth/device.cc
[modify] https://crrev.com/114e4a2cdc28928c83a898d3b73e7c30dad437a1/device/bluetooth/device.h
[modify] https://crrev.com/114e4a2cdc28928c83a898d3b73e7c30dad437a1/device/bluetooth/public/interfaces/device.mojom
Project Member

Comment 38 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91de29301d3e16e93a3789b737a4aa44af4a0bd0

commit 91de29301d3e16e93a3789b737a4aa44af4a0bd0
Author: mbrunson <mbrunson@chromium.org>
Date: Fri Jan 27 01:36:40 2017

bluetooth: Add control for reading/writing of characteristics to internals page.

Adds ValueControl to allow a user to read values from and write values to
    characteristics.
Adds Permission enum to device.mojom for allowing reading/writing based on
    permissions/properties specified by the characteristic.
Adds WriteValueForCharacteristic and ReadValueForCharacteristic to Device Mojo
    service.

GIF: https://goo.gl/photos/izDvvyH7d56Uh4kE7

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627243002
Cr-Commit-Position: refs/heads/master@{#446526}

[modify] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/chrome/browser/browser_resources.grd
[modify] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css
[modify] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html
[modify] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/chrome/browser/resources/bluetooth_internals/characteristic_list.js
[add] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/chrome/browser/resources/bluetooth_internals/value_control.js
[modify] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
[modify] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/chrome/test/data/webui/bluetooth_internals_browsertest.js
[modify] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/chrome/test/data/webui/test_api.js
[modify] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/device/bluetooth/BUILD.gn
[modify] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/device/bluetooth/device.cc
[modify] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/device/bluetooth/device.h
[modify] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/device/bluetooth/public/interfaces/device.mojom
[add] https://crrev.com/91de29301d3e16e93a3789b737a4aa44af4a0bd0/device/bluetooth/public/interfaces/gatt_result_type_converter.h
Project Member

Comment 41 by bugdroid1@chromium.org, Jan 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f191348744018beaea0aea98312b50cf7c90123

commit 8f191348744018beaea0aea98312b50cf7c90123
Author: mbrunson <mbrunson@chromium.org>
Date: Sat Jan 28 02:10:16 2017

bluetooth: Change internal page style to increase contrast of UI elements

Adds colors to list items so differentiating between list types is easier.
Removes padding on the edge of list items to fit more content in expandable
    list area.
Adds spacing between device table rows in the mobile layout.
Darkens divider lines in list and table.

Screenshots: https://goo.gl/photos/9cDMF9w1FfXymxXX8

BUG= 651282 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2662513005
Cr-Commit-Position: refs/heads/master@{#446884}

[modify] https://crrev.com/8f191348744018beaea0aea98312b50cf7c90123/chrome/browser/resources/bluetooth_internals/bluetooth_internals.css

Comment 42 by mbrunson@chromium.org, Jan 31 2017

Cc: scheib@chromium.org ortuno@chromium.org

Comment 43 by ortuno@chromium.org, Jan 31 2017

Cc: mbrunson@chromium.org
Owner: ----
Status: Available (was: Started)
See blocking issues for missing work.

Comment 44 by ortuno@chromium.org, Jan 31 2017

Blockedon: 686642

Comment 45 by ortuno@chromium.org, Jan 31 2017

Blockedon: 686623

Comment 46 by scheib@chromium.org, Feb 13 2017

Blockedon: 691484

Comment 47 by ortuno@chromium.org, Apr 3 2017

Blockedon: 707530

Comment 48 by ortuno@chromium.org, Apr 5 2017

Blockedon: 704549

Comment 49 by scheib@chromium.org, Jan 9 2018

Cc: -scheib@chromium.org

Comment 50 by dpa...@chromium.org, Oct 10 

What is the status of chrome://bluetooth-internals/ and this bug?

Is the page useful to existing devs? Should it be removed? Asking since there seem to be inactivity for almost 2 years.

Comment 51 by mbrunson@chromium.org, Oct 10

Status: Fixed (was: Available)
The chrome://bluetooth-internals page is effectively done and should be useful for any developer working on sites that use Web Bluetooth, so I've marked this bug as fixed now.

I don't think the Web Platform team is actively adding features, but contributions continue to be made by third parties.

Comment 52 by dpapad@google.com, Oct 11 

Ok. Thanks for the update. Perhaps you can help triage the remaining bugs that were marked as blocking this bug? Are all these still relevant?

Comment 53 by mbrunson@chromium.org, Oct 12 

I would say the remaining bugs are still relevant for usability: better error strings, troubleshooting hints, localization. But the functionality of the page is working as intended at this point.

reillyg@ would probably be the better person to contact about priority for Web Bluetooth issues or he could direct you to whoever works on it currently.
►

Sign in to add a comment