New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651272 link

Starred by 1 user
Status: Fixed
Owner:
tapted@chromium.org
Closed: Sep 2016
Cc:
█ mgiuca@chromium.org
█ scheib@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Failing (non-flaky) FullscreenControllerInteractiveTest

Project Member Reported by tapted@chromium.org, Sep 29 2016 
Chrome Version       : 55.0.2868.3
OS Version: OS X 10.11.6

Running buildr interactive_ui_tests --gtest_filter=FullscreenControllerInteractiveTest.* --gtest_also_run_disabled_tests has 3 failing tests on Mac:

    FullscreenControllerInteractiveTest.DISABLED_FullscreenFileURL
    FullscreenControllerInteractiveTest.DISABLED_TestTabDoesntExitFullscreenOnSubFrameNavigation
    FullscreenControllerInteractiveTest.DISABLED_ToggleFullscreenModeForTab


FullscreenFileURL and TestTabDoesntExitFullscreenOnSubFrameNavigation fail with "Check failed: !IsPathAbsolute(appended).". ToggleFullscreenModeForTab fails with "Check failed: Started(). You must start the server first."

Stacks attached.
FullscreenFileURL.stack.txt
10.7 KB View Download
TestTabDoesntExitFullscreenOnSubFrameNavigation.stack.txt
10.8 KB View Download
ToggleFullscreenModeForTab.stack.txt
10.3 KB View Download

Comment 1 by tapted@chromium.org, Sep 29 2016

Owner: tapted@chromium.org
Status: Started (was: Available)
If only all test fixes were this easy...

https://codereview.chromium.org/2378623003/
https://codereview.chromium.org/2375273003/
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86d5b6c3d7aa2e2c28becafe642fcc6d7be405c9

commit 86d5b6c3d7aa2e2c28becafe642fcc6d7be405c9
Author: tapted <tapted@chromium.org>
Date: Thu Sep 29 04:52:55 2016

Fix tests FullscreenFileURL, TestTabDoesntExitFullscreenOnSubFrameNavigation

These are failing with "Check failed: !IsPathAbsolute(appended)." when
run with --gtest_also_run_disabled_tests. Removing the leading slash
from the kSimpleFile constant fixes it.

BUG= 651272 

Review-Url: https://codereview.chromium.org/2375273003
Cr-Commit-Position: refs/heads/master@{#421748}

[modify] https://crrev.com/86d5b6c3d7aa2e2c28becafe642fcc6d7be405c9/chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e4dae4ab4eef8252d6dae8262960e1be7936b92

commit 6e4dae4ab4eef8252d6dae8262960e1be7936b92
Author: tapted <tapted@chromium.org>
Date: Thu Sep 29 06:50:57 2016

Fix FullscreenControllerInteractiveTest.ToggleFullscreenModeForTab

Test fails with "Check failed: Started(). You must start the server
first." when run with --gtest_also_run_disabled_tests.

Start it.

BUG= 651272 

Review-Url: https://codereview.chromium.org/2378623003
Cr-Commit-Position: refs/heads/master@{#421764}

[modify] https://crrev.com/6e4dae4ab4eef8252d6dae8262960e1be7936b92/chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc

Comment 4 by tapted@chromium.org, Sep 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment