Issue 651269 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	lijeffrey@chromium.org
Closed:	Oct 2016
Cc:	chanli@chromium.org st...@chromium.org █ robert...@chromium.org lijeffrey@chromium.org liaoyuke@chromium.org
Components:	Tools>Test>FindIt
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Bug

[Findit] Master flake analysis versioned entities save version as null

Project Member Reported by lijeffrey@chromium.org, Sep 29 2016

Issue description

It seems in master flake analysis after saving, the version property is set to null.

version simply accesses self.key.integer_id(), which returns None, yet when accessing the entity itself.key.integer_id(), the correct value is returned.

Also in local testing environment, the property is correct.

Comment 1 by lijeffrey@chromium.org, Sep 29 2016

Labels: -Pri-2 Pri-1

This is due to master_flake_analysis being a child class of BaseAnalysis, which has a string version property that seems to be taking precedence.

2 possible solutions: rename the version property for versioned models to version_number, or have MFA not be a child class of base_analysis.

Escalating to priority 1, as this is blocking the change for capturing metadata for master flake analysis.

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/661cbd1e045c5bf4d5f100a976e101ce71d5545c

commit 661cbd1e045c5bf4d5f100a976e101ce71d5545c
Author: lijeffrey <lijeffrey@chromium.org>
Date: Thu Sep 29 05:22:09 2016

[Findit] Renaming version property in versioned_model.py to avoid conflicts with base_analysis.py

BUG= 651269 

Review-Url: https://codereview.chromium.org/2376263002

[modify] https://crrev.com/661cbd1e045c5bf4d5f100a976e101ce71d5545c/appengine/findit/handlers/config.py
[modify] https://crrev.com/661cbd1e045c5bf4d5f100a976e101ce71d5545c/appengine/findit/model/test/versioned_config_test.py
[modify] https://crrev.com/661cbd1e045c5bf4d5f100a976e101ce71d5545c/appengine/findit/model/test/versioned_model_test.py
[modify] https://crrev.com/661cbd1e045c5bf4d5f100a976e101ce71d5545c/appengine/findit/model/versioned_model.py

Comment 3 by lijeffrey@chromium.org, Oct 3 2016

Status: Fixed (was: Assigned)

Comment 4 by lijeffrey@chromium.org, Oct 3 2016

Status: Verified (was: Fixed)

►

Issue 651269 link

Issue metadata

[Findit] Master flake analysis versioned entities save version as null

Issue description

Comment 1 by lijeffrey@chromium.org, Sep 29 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Sep 29 2016

Comment 2 Deleted

Comment 3 by lijeffrey@chromium.org, Oct 3 2016

Comment 3 Deleted

Comment 4 by lijeffrey@chromium.org, Oct 3 2016

Comment 4 Deleted

Sign in to add a comment